| Message ID | 1933b829b03a6e489494706792e813b8db693577.1678189056.git.fdmanana@suse.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | btrfs/286: add missing calls to _scratch_dev_pool_put and _spare_dev_put | expand |
On 07/03/2023 19:38, fdmanana@kernel.org wrote: > From: Filipe Manana <fdmanana@suse.com> > > The test is doing a _scratch_dev_pool_get, which shrinks the list of > devices in SCRATCH_DEV_POOL, but it's not calling _scratch_dev_pool_put > before it finishes. This will result in subsequent tests (none at the > moment however) getting a reduced list of devices in SCRATCH_DEV_POOL. > > The same goes for the spare device, the test calls _spare_dev_get but > it never calls _spare_dev_put. > > So add the missing calls. > > Signed-off-by: Filipe Manana <fdmanana@suse.com> > --- > tests/btrfs/286 | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/tests/btrfs/286 b/tests/btrfs/286 > index fb805256..f1ee129c 100755 > --- a/tests/btrfs/286 > +++ b/tests/btrfs/286 > @@ -71,6 +71,9 @@ for t in "${_btrfs_profile_configs[@]}"; do > workload "$t" > done > > +_spare_dev_put > +_scratch_dev_pool_put > + > echo "Silence is golden" > > # success, all done Looks good. Reviewed-by: Anand Jain <anand.jain@oracle.com>
diff --git a/tests/btrfs/286 b/tests/btrfs/286 index fb805256..f1ee129c 100755 --- a/tests/btrfs/286 +++ b/tests/btrfs/286 @@ -71,6 +71,9 @@ for t in "${_btrfs_profile_configs[@]}"; do workload "$t" done +_spare_dev_put +_scratch_dev_pool_put + echo "Silence is golden" # success, all done