From patchwork Wed Mar 7 19:02:51 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Diego Calleja X-Patchwork-Id: 10264711 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id A79176016D for ; Wed, 7 Mar 2018 19:03:01 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 9993F295F3 for ; Wed, 7 Mar 2018 19:03:01 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 8ED0529668; Wed, 7 Mar 2018 19:03:01 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=2.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, FREEMAIL_FROM, RCVD_IN_DNSWL_HI, T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 3C3E7295F3 for ; Wed, 7 Mar 2018 19:03:01 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754726AbeCGTC7 (ORCPT ); Wed, 7 Mar 2018 14:02:59 -0500 Received: from mail-wm0-f46.google.com ([74.125.82.46]:52276 "EHLO mail-wm0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754714AbeCGTC5 (ORCPT ); Wed, 7 Mar 2018 14:02:57 -0500 Received: by mail-wm0-f46.google.com with SMTP id t3so6823168wmc.2 for ; Wed, 07 Mar 2018 11:02:57 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=pOxKSsBjSZxA47z6To29sKV1NAY89Dje9kWvOMC8Vns=; b=bqtd1YO0puaY7iAtwBe+hAToWbKDShbgI4yg23hKebrh9a0aopIxqTf/LNV9WFVvTw Ysc/Af/jJKSMmusTbquZHLyfmMeli6bjfFHu77YF4IJXb5HLfI2l9kCjs3RPtnEtZ0Gh TpVX028ExnbuVWXG7MqL5mep0IcootsvGlXSW7CESucuvUgq26mEER2a5XJ+8ePsNkAA BBTNWJk09/Vrv8TrvAlx4jfPM9pEsTvCCqmVvE5+BCjIo74/D9CXwl9bFo2hWDhXZsbf NEUOJzUHYQS+DJflt1P5JbwZQuBLfaQBnAv6SUa1gI2jS+yVIdywf+JhoHHBfioqGWQ5 eEqg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=pOxKSsBjSZxA47z6To29sKV1NAY89Dje9kWvOMC8Vns=; b=oV+TESKzC8cH9U35GRRcHqt3AhmNv6PMGRVwoHEMuRCzrQByyTRt3fnpHM8xNmwdWu +ZGq5ijlw9MH7UT+wqmdxO3Vyk444WfF6QaXv0L8VsgoI0mKrhcc1gMypYiVrNRF+NqL X8JHIqhNpxvkmLoQ0W1JgwdrECX5pJl5m4gHmVkO1wUjkGgT/dldw6rtFXZfsqpCdVQG fv2uyLxWLqeJq2ZZ+JPQRECSj4Jh6mw1VC5HZMz+E2kIfpNSWcfG4aFbI9rz5z02R6pM w2VNtpJM4ppD9FiicmEnnxszbmaEClj2kNMtADzLvb+H4nz3H1l/4tyEgszJ42WbBcxg DaLA== X-Gm-Message-State: AElRT7EkXJJqql8a80cgpspzdzH/DkWn+1R6cBQEGJr9obUbcU6vqZ+q 5/wCt06Z3JnmgsFdNRWhKY4Fiw== X-Google-Smtp-Source: AG47ELt9PfhlFNVLXgJGtxOIZ0M1uSsL3q/Dt6uoT6YnVmgwthAVyvIPefzQVGMdsUBPHXCoRJRJRw== X-Received: by 10.28.168.86 with SMTP id r83mr5050990wme.37.1520449376386; Wed, 07 Mar 2018 11:02:56 -0800 (PST) Received: from archlinux.localnet (229.red-79-150-122.dynamicip.rima-tde.net. [79.150.122.229]) by smtp.gmail.com with ESMTPSA id x189sm11759581wmg.23.2018.03.07.11.02.53 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 07 Mar 2018 11:02:55 -0800 (PST) From: Diego To: Hugo Mills Cc: linux-btrfs@vger.kernel.org Subject: Re: [PATCH] Improve error stats message Date: Wed, 07 Mar 2018 20:02:51 +0100 Message-ID: <2011051.lkSedfDimf@archlinux> In-Reply-To: <20180307182453.GF20688@carfax.org.uk> References: <1588327.cr4xlG2VNd@archlinux> <20180307182453.GF20688@carfax.org.uk> MIME-Version: 1.0 Sender: linux-btrfs-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-btrfs@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP El miércoles, 7 de marzo de 2018 19:24:53 (CET) Hugo Mills escribió: > On multi-device filesystems, the two are not necessarily the same. Ouch. FWIW, I was moved to do this because I saw this conversation on IRC which made me think that people aren't understanding what the message means: hi! I noticed bdev rd 13 as a kernel message what does it mean Well, that's not the whole message. Can you paste the whole line in here? (Just one line) [ 3.404959] BTRFS info (device sda4): bdev /dev/sda4 errs: wr 0, rd 13, flush 0, corrupt 0, gen 0 Maybe something like this would be better: BTRFS info (device sda4): disk /dev/sda4 errors: write 0, read 13, flush 0, corrupt 0, generation 0 --- fs/btrfs/volumes.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/btrfs/volumes.c b/fs/btrfs/volumes.c index 2ceb924ca0d6..cfa029468585 100644 --- a/fs/btrfs/volumes.c +++ b/fs/btrfs/volumes.c @@ -7239,7 +7239,7 @@ static void btrfs_dev_stat_print_on_error(struct btrfs_device *dev) if (!dev->dev_stats_valid) return; btrfs_err_rl_in_rcu(dev->fs_info, - "bdev %s errs: wr %u, rd %u, flush %u, corrupt %u, gen %u", + "disk %s errors: write %u, read %u, flush %u, corrupt %u, generation %u", rcu_str_deref(dev->name), btrfs_dev_stat_read(dev, BTRFS_DEV_STAT_WRITE_ERRS), btrfs_dev_stat_read(dev, BTRFS_DEV_STAT_READ_ERRS),