| Message ID | 20121008161713.218a6eb1@leda (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Mon, Oct 08, 2012 at 08:17:13AM -0600, Christian Hesse wrote: > Hello everybody, > > man pages for btrfs-progs are compressed by gzip by default. In Makefile the > variable GZIP is use, this evaluates to 'gzip gzip' on my system. From man > gzip: > > > The environment variable GZIP can hold a set of default options for gzip. > > These options are interpreted first and can be overwritten by explicit > > command line parameters. > > So using any other variable name fixes this. Patch is attached. Ok, which system is this? Just curious, I'll pull in the patch. -chris -- To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Chris Mason <chris.mason@fusionio.com> on Mon, 2012/10/08 10:29: > On Mon, Oct 08, 2012 at 08:17:13AM -0600, Christian Hesse wrote: > > Hello everybody, > > > > man pages for btrfs-progs are compressed by gzip by default. In Makefile > > the variable GZIP is use, this evaluates to 'gzip gzip' on my system. > > From man gzip: > > > > > The environment variable GZIP can hold a set of default options for > > > gzip. These options are interpreted first and can be overwritten by > > > explicit command line parameters. > > > > So using any other variable name fixes this. Patch is attached. > > Ok, which system is this? Just curious, I'll pull in the patch. This is Arch Linux with gzip 1.5-1.
On Mon, Oct 08, 2012 at 08:30:31AM -0600, Christian Hesse wrote: > Chris Mason <chris.mason@fusionio.com> on Mon, 2012/10/08 10:29: > > On Mon, Oct 08, 2012 at 08:17:13AM -0600, Christian Hesse wrote: > > > Hello everybody, > > > > > > man pages for btrfs-progs are compressed by gzip by default. In Makefile > > > the variable GZIP is use, this evaluates to 'gzip gzip' on my system. > > > From man gzip: > > > > > > > The environment variable GZIP can hold a set of default options for > > > > gzip. These options are interpreted first and can be overwritten by > > > > explicit command line parameters. > > > > > > So using any other variable name fixes this. Patch is attached. > > > > Ok, which system is this? Just curious, I'll pull in the patch. > > This is Arch Linux with gzip 1.5-1. Strange, I'm running running arch linux with gzip 1.5-1 and it builds. I wonder if something else is expanding it. I'll take the patch regardless, there's no reason to add build problems when we don't need to. -chris -- To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Chris Mason <chris.mason@fusionio.com> on Mon, 2012/10/08 10:33: > On Mon, Oct 08, 2012 at 08:30:31AM -0600, Christian Hesse wrote: > > Chris Mason <chris.mason@fusionio.com> on Mon, 2012/10/08 10:29: > > > On Mon, Oct 08, 2012 at 08:17:13AM -0600, Christian Hesse wrote: > > > > Hello everybody, > > > > > > > > man pages for btrfs-progs are compressed by gzip by default. In > > > > Makefile the variable GZIP is use, this evaluates to 'gzip gzip' on > > > > my system. From man gzip: > > > > > > > > > The environment variable GZIP can hold a set of default options for > > > > > gzip. These options are interpreted first and can be overwritten by > > > > > explicit command line parameters. > > > > > > > > So using any other variable name fixes this. Patch is attached. > > > > > > Ok, which system is this? Just curious, I'll pull in the patch. > > > > This is Arch Linux with gzip 1.5-1. > > Strange, I'm running running arch linux with gzip 1.5-1 and it builds. > I wonder if something else is expanding it. I'll take the patch > regardless, there's no reason to add build problems when we don't need > to. This happens if you have exported GZIP to your environment. So probably most people are not effected.
diff --git a/man/Makefile b/man/Makefile index 4a90b75..f7b57f7 100644 --- a/man/Makefile +++ b/man/Makefile @@ -1,4 +1,4 @@ -GZIP=gzip +GZIPCMD=gzip INSTALL= install prefix ?= /usr/local @@ -12,22 +12,22 @@ MANPAGES = mkfs.btrfs.8.gz btrfsctl.8.gz btrfsck.8.gz btrfs-image.8.gz \ all: $(MANPAGES) mkfs.btrfs.8.gz: mkfs.btrfs.8.in - $(GZIP) -n -c mkfs.btrfs.8.in > mkfs.btrfs.8.gz + $(GZIPCMD) -n -c mkfs.btrfs.8.in > mkfs.btrfs.8.gz btrfs.8.gz: btrfs.8.in - $(GZIP) -n -c btrfs.8.in > btrfs.8.gz + $(GZIPCMD) -n -c btrfs.8.in > btrfs.8.gz btrfsctl.8.gz: btrfsctl.8.in - $(GZIP) -n -c btrfsctl.8.in > btrfsctl.8.gz + $(GZIPCMD) -n -c btrfsctl.8.in > btrfsctl.8.gz btrfsck.8.gz: btrfsck.8.in - $(GZIP) -n -c btrfsck.8.in > btrfsck.8.gz + $(GZIPCMD) -n -c btrfsck.8.in > btrfsck.8.gz btrfs-image.8.gz: btrfs-image.8.in - $(GZIP) -n -c btrfs-image.8.in > btrfs-image.8.gz + $(GZIPCMD) -n -c btrfs-image.8.in > btrfs-image.8.gz btrfs-show.8.gz: btrfs-show.8.in - $(GZIP) -n -c btrfs-show.8.in > btrfs-show.8.gz + $(GZIPCMD) -n -c btrfs-show.8.in > btrfs-show.8.gz clean : rm -f $(MANPAGES)