From patchwork Fri Mar 27 03:34:32 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Eryu Guan X-Patchwork-Id: 6103371 Return-Path: X-Original-To: patchwork-linux-btrfs@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork1.web.kernel.org (Postfix) with ESMTP id 144B19F399 for ; Fri, 27 Mar 2015 03:35:53 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 10F7820421 for ; Fri, 27 Mar 2015 03:35:52 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 1DF992041F for ; Fri, 27 Mar 2015 03:35:51 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752507AbbC0Dfm (ORCPT ); Thu, 26 Mar 2015 23:35:42 -0400 Received: from mail-pd0-f181.google.com ([209.85.192.181]:32967 "EHLO mail-pd0-f181.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751840AbbC0Dfl (ORCPT ); Thu, 26 Mar 2015 23:35:41 -0400 Received: by pdnc3 with SMTP id c3so83116203pdn.0 for ; Thu, 26 Mar 2015 20:35:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=date:from:to:cc:subject:message-id:references:mime-version :content-type:content-disposition:in-reply-to:user-agent; bh=5cK6INxyJu7+eIr/nzCjrBd7BqANF4D74X5z148VI3E=; b=IqHbE1FXGIbSrYLMsHt59Wn+JrdTeyoxoCxK4PEZNcr19ly7XRrNSWEGDtjNUZ7hOT l9mosu+h2J/D8cb+WV3kX9ya7WcdnH/OxFsCLCmRdRmaVuTTfWAXscm0pyVDeFDKe7z5 nuyYQAgvJKVl/R282OXuzZURG/NFBvDQfw5kqyyZLPMb8ZBLdiJ2c1vEKb+szEu2RyAN VZZd2IvzYjKJyoYIFEgGKCGoAw9wf4Vjp3F3FkrkLnKWv9Q4goHNcnyr+41/OrezKl8k 8Qjrk6xjJJIJdSaNgN5FpcI7TvuVz3+kWvtOQCjOAtnmlxA8ZUzRR/keTOg5fGBO8Bpj X0PA== X-Received: by 10.68.215.9 with SMTP id oe9mr9193630pbc.146.1427427341317; Thu, 26 Mar 2015 20:35:41 -0700 (PDT) Received: from localhost ([128.199.137.77]) by mx.google.com with ESMTPSA id o4sm511870pdh.6.2015.03.26.20.35.39 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 26 Mar 2015 20:35:40 -0700 (PDT) Date: Fri, 27 Mar 2015 11:34:32 +0800 From: Eryu Guan To: Eric Sandeen Cc: Chris Mason , fdmanana@gmail.com, linux-btrfs Subject: Re: I think "btrfs: fix leak of path in btrfs_find_item" broke stable trees ... Message-ID: <20150327033432.GB16812@dhcp-13-216.nay.redhat.com> References: <55137BE2.80603@redhat.com> <5514137E.6080804@redhat.com> <1427381284.28930.5@mail.thefacebook.com> <55143DD7.2020608@redhat.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <55143DD7.2020608@redhat.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-btrfs-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-btrfs@vger.kernel.org X-Spam-Status: No, score=-6.8 required=5.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, FREEMAIL_FROM, RCVD_IN_DNSWL_HI, T_DKIM_INVALID, T_RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP On Thu, Mar 26, 2015 at 12:11:51PM -0500, Eric Sandeen wrote: > On 3/26/15 9:48 AM, Chris Mason wrote: > > On Thu, Mar 26, 2015 at 10:11 AM, Eric Sandeen wrote: > > ... > > >>>> 9c4f61f btrfs: simplify insert_orphan_item > >>>> > >>>> made the whole path alloc/free go away. > >> > >> so I think there's no need for my patch; may as well just send the above to stable > >> and fix it that way, as long as 9c4f61f is deemed safe & correct, I think. > > > > Nice catch, thanks Eric. 9c4f61f looks fine for stable to me, but > > since he's already testing on stable, I talked Eric into giving it a > > pass through xfstests before I send it up. > > > > -chris > > ./check -g auto on 3.19-stable-ish seems fine-ish. Certainly no worse w/ the patch added :) > > Failures: btrfs/010 btrfs/017 btrfs/078 generic/015 generic/039 generic/040 generic/041 generic/065 generic/066 generic/071 generic/204 > Failed 11 of 202 tests Just FYI. I think generic/204 is a test case issue, _filter_mkfs failed to print isize and dbsize for btrfs and test failed because of divide by zero error. I'm working a patch for fstests. Eryu --- To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html --- /dev/fd/63 2015-03-25 12:17:05.987107715 -0400 +++ results/generic/204.out.bad 2015-03-25 12:17:05.423101244 -0400 @@ -1,2 +1,3 @@ QA output created by 204 +./tests/generic/204: line 76: space / (isize + dbsize): division by 0 (error token is ")") *** done