From patchwork Tue Jul 12 00:35:37 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Omar Sandoval X-Patchwork-Id: 9224473 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id E22DF60572 for ; Tue, 12 Jul 2016 00:35:45 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id D1C0627F17 for ; Tue, 12 Jul 2016 00:35:45 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id C582327F8C; Tue, 12 Jul 2016 00:35:45 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=2.0 tests=BAYES_00,DKIM_SIGNED, RCVD_IN_DNSWL_HI,T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 71E2627F17 for ; Tue, 12 Jul 2016 00:35:45 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752807AbcGLAfk (ORCPT ); Mon, 11 Jul 2016 20:35:40 -0400 Received: from mail-pa0-f43.google.com ([209.85.220.43]:36643 "EHLO mail-pa0-f43.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751887AbcGLAfj (ORCPT ); Mon, 11 Jul 2016 20:35:39 -0400 Received: by mail-pa0-f43.google.com with SMTP id hu1so279217pad.3 for ; Mon, 11 Jul 2016 17:35:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=osandov-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:mime-version:content-disposition :user-agent; bh=SZaTd5OeGpCstJL3bOCz4yxRkFWDHI32yO7Q6FMJlxU=; b=OH7rt46rnOymiXGMKBZoW93MNkmZ6cvoyOwfIBmbbTsxeCSF+I+N+NXT22oBQWAiVz dKjWJ8SGe/XRu9qd/kX/CaPpDs2+Soo5QkMDNReDNbjqfi52t3cDQEEZMGeikipsu30r +0cF1CqfkTlYTvxPzrkXGJt2fHpZBKntAfj/lWV/MUmSU3qKELpfaOtZZTCftHR1NAur NMuzds+L7fSjJvIlzdRGTCoiFwLQdRVz/njVxNREWqqd6Kx/uSfo8QMXBrft+rsWqwu3 P8F2v5Rub5nrIoDOWD+ZvF7MIUn/LUp1fxLp5YFltzFBVkWgrPf+cnOsX93JgDPYwMAP npyQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:date:from:to:cc:subject:message-id:mime-version :content-disposition:user-agent; bh=SZaTd5OeGpCstJL3bOCz4yxRkFWDHI32yO7Q6FMJlxU=; b=mkrvuqt6A5TWX6RG5gAuDp4Jx4OBAdPEkMhbD7RbQWVwsI/SlzUGGF70sR5q0qeNCq Bawxrb7DmHgcdf7hRwhXSxuabcRA2pSlUDIB4Fqj2owoLLf6Q1an/4L64pryd7B7LFQD keY+/EEUhBGY6YO4Tb3x/6qmIAk6j5iYj7UjFc01CVRXnYEPE8vav+n/ZVBRS75QqqC6 TA8K192LSIEKcqnpeGN81a/x+eJQlooEmGhpgWjq02VQghFh4BirEmv8JXUH9Pxk2vsQ ySbKePeHTED2wdd8eQ2ocNZqcKOAJoo7MzQ+6f3qVAJZuBLQLfNXQjNKV4xuTcNoov3+ Ko5g== X-Gm-Message-State: ALyK8tKChcZZG7fdu4PQaoV30JKs7PRu72MQBHw8HIN4CDU6l1CulP+8p94kVayxekzOdmrn X-Received: by 10.66.139.133 with SMTP id qy5mr39405486pab.4.1468283738783; Mon, 11 Jul 2016 17:35:38 -0700 (PDT) Received: from vader.dhcp.thefacebook.com ([2620:10d:c090:200::1:f4f7]) by smtp.gmail.com with ESMTPSA id 81sm6599780pfo.74.2016.07.11.17.35.37 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 11 Jul 2016 17:35:38 -0700 (PDT) Date: Mon, 11 Jul 2016 17:35:37 -0700 From: Omar Sandoval To: "Darrick J. Wong" , linux-btrfs@vger.kernel.org Cc: linux-fsdevel@vger.kernel.org Subject: FIDEDUPERANGE with src_length == 0 Message-ID: <20160712003537.GA27653@vader.dhcp.thefacebook.com> MIME-Version: 1.0 Content-Disposition: inline User-Agent: Mutt/1.6.2 (2016-07-01) Sender: linux-btrfs-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-btrfs@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Hey, Darrick, generic/182 is failing on Btrfs for me with the following output: It looks like that test is checking that a dedupe with length == 0 is treated as a dedupe to EOF, but Btrfs doesn't do that [1]. As far as I can tell, it never did, but maybe I'm just confused. What was the behavior when you introduced that test? That seems like a reasonable thing to do, but I wanted to clear this up before changing/fixing Btrfs. Thanks. 1: http://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/tree/fs/btrfs/ioctl.c?h=v4.7-rc7#n3122 --- tests/generic/182.out 2016-07-07 19:51:54.000000000 -0700 +++ /tmp/fixxfstests/xfstests/results//generic/182.out.bad 2016-07-11 17:28:28.230039216 -0700 @@ -1,12 +1,10 @@ QA output created by 182 Create the original files -dedupe: Extents did not match. f4820540fc0ac02750739896fe028d56 TEST_DIR/test-182/file1 69ad53078a16243d98e21d9f8704a071 TEST_DIR/test-182/file2 69ad53078a16243d98e21d9f8704a071 TEST_DIR/test-182/file2.chk Compare against check files Make the original file almost dedup-able -dedupe: Extents did not match. f4820540fc0ac02750739896fe028d56 TEST_DIR/test-182/file1 158d4e3578b94b89cbb44493a2110fb9 TEST_DIR/test-182/file2 158d4e3578b94b89cbb44493a2110fb9 TEST_DIR/test-182/file2.chk