From patchwork Thu Sep 22 02:13:08 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Xiaoguang Wang X-Patchwork-Id: 9344425 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 7360D60CDC for ; Thu, 22 Sep 2016 02:18:32 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 66B2A2A2D9 for ; Thu, 22 Sep 2016 02:18:32 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 5BA8E2A2DA; Thu, 22 Sep 2016 02:18:32 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=2.0 tests=BAYES_00,RCVD_IN_DNSWL_HI autolearn=unavailable version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id B990E2A2DB for ; Thu, 22 Sep 2016 02:18:28 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933517AbcIVCS1 (ORCPT ); Wed, 21 Sep 2016 22:18:27 -0400 Received: from cn.fujitsu.com ([222.73.24.84]:37744 "EHLO song.cn.fujitsu.com" rhost-flags-OK-FAIL-OK-OK) by vger.kernel.org with ESMTP id S932763AbcIVCSZ (ORCPT ); Wed, 21 Sep 2016 22:18:25 -0400 X-IronPort-AV: E=Sophos;i="5.20,367,1444665600"; d="scan'208";a="855115" Received: from unknown (HELO cn.fujitsu.com) ([10.167.250.3]) by song.cn.fujitsu.com with ESMTP; 22 Sep 2016 10:18:17 +0800 Received: from localhost.localdomain (unknown [10.167.226.107]) by cn.fujitsu.com (Postfix) with ESMTP id 78E724043CE5; Thu, 22 Sep 2016 10:18:15 +0800 (CST) From: Wang Xiaoguang To: fstests@vger.kernel.org Cc: linux-btrfs@vger.kernel.org Subject: [PATCH v2] generic: check whether we can truncate heavily reflinked file Date: Thu, 22 Sep 2016 10:13:08 +0800 Message-Id: <20160922021308.4594-1-wangxg.fnst@cn.fujitsu.com> X-Mailer: git-send-email 2.9.0 MIME-Version: 1.0 X-yoursite-MailScanner-ID: 78E724043CE5.A2DFD X-yoursite-MailScanner: Found to be clean X-yoursite-MailScanner-From: wangxg.fnst@cn.fujitsu.com Sender: linux-btrfs-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-btrfs@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP In btrfs, there is a bug about btrfs' truncate codes, it'll leak some fs space as the truncate operation proceeds. If this truncate operation is very large, later metadata request in this truncate operation may fail for enospc error. I also have sent a kernel patch fot btrfs to fix this issue. Signed-off-by: Wang Xiaoguang --- tests/generic/379 | 86 +++++++++++++++++++++++++++++++++++++++++++++++++++ tests/generic/379.out | 2 ++ tests/generic/group | 1 + 3 files changed, 89 insertions(+) create mode 100755 tests/generic/379 create mode 100644 tests/generic/379.out diff --git a/tests/generic/379 b/tests/generic/379 new file mode 100755 index 0000000..3d2918a --- /dev/null +++ b/tests/generic/379 @@ -0,0 +1,86 @@ +#! /bin/bash +# FS QA Test 379 +# +# Create a heavily reflinked file, then check whether we can truncate +# it correctly. +# +#----------------------------------------------------------------------- +# Copyright (c) 2016 Fujitsu. All Rights Reserved. +# +# This program is free software; you can redistribute it and/or +# modify it under the terms of the GNU General Public License as +# published by the Free Software Foundation. +# +# This program is distributed in the hope that it would be useful, +# but WITHOUT ANY WARRANTY; without even the implied warranty of +# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the +# GNU General Public License for more details. +# +# You should have received a copy of the GNU General Public License +# along with this program; if not, write the Free Software Foundation, +# Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA +#----------------------------------------------------------------------- +# + +seq=`basename $0` +seqres=$RESULT_DIR/$seq +echo "QA output created by $seq" + +here=`pwd` +tmp=/tmp/$$ +status=1 # failure is the default! +trap "_cleanup; exit \$status" 0 1 2 3 15 + +_cleanup() +{ + cd / + rm -f $tmp.* +} + +# get standard environment, filters and checks +. ./common/rc +. ./common/filter +. ./common/reflink + +# remove previous $seqres.full before test +rm -f $seqres.full + +# Modify as appropriate. +_supported_fs generic +_supported_os Linux +_require_scratch +_require_scratch_reflink + +_scratch_mkfs_sized $((32 * 1024 * 1024)) >> $seqres.full 2>&1 +_scratch_mount + +testfile=$SCRATCH_MNT/testfile +dummyfile1=$SCRATCH_MNT/dummyfile1 +dummyfile2=$SCRATCH_MNT/dummyfile2 +blocksize=$((128 * 1024)) + +# create two dummy files, which is used to occupy some fs space first. +_pwrite_byte 0xcdcdcdcd 0 $((8 * 1024 * 1024)) $dummyfile1 > /dev/null +_pwrite_byte 0xcdcdcdcd 0 $((1 * 1024 * 1024)) $dummyfile2 > /dev/null +_pwrite_byte 0xcdcdcdcd 0 $blocksize $testfile > /dev/null + +echo "Silence is golden" +# try to do reflink unless we get enospc error. +i=1 +while true; do + _reflink_range $testfile 0 $testfile $(($i * $blocksize)) $blocksize \ + 2>&1 | grep -q "No space left on device" + if [ $? -eq 0 ]; then + break + fi + i=$((i + 1)) +done + +# fs is almost full now and fs internal operations may need some free space, +# for example, in btrfs, transaction will need to reserve space first, so here +# free 1MB space. +rm -rf $dummyfile2 +$XFS_IO_PROG -f -c "truncate 0" $testfile + +status=0 +exit diff --git a/tests/generic/379.out b/tests/generic/379.out new file mode 100644 index 0000000..ec12148 --- /dev/null +++ b/tests/generic/379.out @@ -0,0 +1,2 @@ +QA output created by 379 +Silence is golden diff --git a/tests/generic/group b/tests/generic/group index a602b01..73fce91 100644 --- a/tests/generic/group +++ b/tests/generic/group @@ -381,3 +381,4 @@ 376 auto quick metadata 377 attr auto quick metadata 378 auto quick metadata +379 auto clone