From patchwork Mon Oct 17 01:27:32 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Qu Wenruo X-Patchwork-Id: 9378367 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 3FFAD60487 for ; Mon, 17 Oct 2016 01:28:22 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 3443728CCD for ; Mon, 17 Oct 2016 01:28:22 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 20C8128D78; Mon, 17 Oct 2016 01:28:22 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=2.0 tests=BAYES_00,RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 4489628E4A for ; Mon, 17 Oct 2016 01:28:21 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932180AbcJQB2O (ORCPT ); Sun, 16 Oct 2016 21:28:14 -0400 Received: from cn.fujitsu.com ([222.73.24.84]:57276 "EHLO song.cn.fujitsu.com" rhost-flags-OK-FAIL-OK-OK) by vger.kernel.org with ESMTP id S1756757AbcJQB2J (ORCPT ); Sun, 16 Oct 2016 21:28:09 -0400 X-IronPort-AV: E=Sophos;i="5.20,367,1444665600"; d="scan'208";a="901592" Received: from unknown (HELO cn.fujitsu.com) ([10.167.250.3]) by song.cn.fujitsu.com with ESMTP; 17 Oct 2016 09:27:52 +0800 Received: from adam-work.localdomain (unknown [10.167.226.34]) by cn.fujitsu.com (Postfix) with ESMTP id 9507E41B388A for ; Mon, 17 Oct 2016 09:27:47 +0800 (CST) From: Qu Wenruo To: linux-btrfs@vger.kernel.org Subject: [RFC PATCH v0.8 03/14] btrfs-progs: check/csum: Introduce function to read out one data csum Date: Mon, 17 Oct 2016 09:27:32 +0800 Message-Id: <20161017012743.9692-4-quwenruo@cn.fujitsu.com> X-Mailer: git-send-email 2.10.0 In-Reply-To: <20161017012743.9692-1-quwenruo@cn.fujitsu.com> References: <20161017012743.9692-1-quwenruo@cn.fujitsu.com> MIME-Version: 1.0 X-yoursite-MailScanner-ID: 9507E41B388A.AF10E X-yoursite-MailScanner: Found to be clean X-yoursite-MailScanner-From: quwenruo@cn.fujitsu.com Sender: linux-btrfs-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-btrfs@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Introduce a new function, btrfs_read_one_data_csum(), to read just one data csum for check usage. Unlike original implement in cmds-check.c which checks csum by one CSUM_EXTENT, this just read out one csum(4 bytes). It is not fast but makes code easier to read. And will be used in later fsck scrub codes. Signed-off-by: Qu Wenruo --- Makefile.in | 6 ++-- check/check.h | 21 +++++++++++++ check/csum.c | 96 +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ 3 files changed, 121 insertions(+), 2 deletions(-) create mode 100644 check/check.h create mode 100644 check/csum.c diff --git a/Makefile.in b/Makefile.in index b53cf2c..6e2407f 100644 --- a/Makefile.in +++ b/Makefile.in @@ -63,6 +63,7 @@ CFLAGS = @CFLAGS@ \ -fPIC \ -I$(TOPDIR) \ -I$(TOPDIR)/kernel-lib \ + -I$(TOPDIR)/check \ $(EXTRAWARN_CFLAGS) \ $(DEBUG_CFLAGS_INTERNAL) \ $(EXTRA_CFLAGS) @@ -93,7 +94,8 @@ objects = ctree.o disk-io.o kernel-lib/radix-tree.o extent-tree.o print-tree.o \ extent-cache.o extent_io.o volumes.o utils.o repair.o \ qgroup.o raid56.o free-space-cache.o kernel-lib/list_sort.o props.o \ ulist.o qgroup-verify.o backref.o string-table.o task-utils.o \ - inode.o file.o find-root.o free-space-tree.o help.o + inode.o file.o find-root.o free-space-tree.o help.o \ + check/csum.o cmds_objects = cmds-subvolume.o cmds-filesystem.o cmds-device.o cmds-scrub.o \ cmds-inspect.o cmds-balance.o cmds-send.o cmds-receive.o \ cmds-quota.o cmds-qgroup.o cmds-replace.o cmds-check.o \ @@ -463,7 +465,7 @@ clean-all: clean clean-doc clean-gen clean: $(CLEANDIRS) @echo "Cleaning" $(Q)$(RM) -f -- $(progs) cscope.out *.o *.o.d \ - kernel-lib/*.o kernel-lib/*.o.d \ + kernel-lib/*.o kernel-lib/*.o.d check/*.o check/*.o.d \ dir-test ioctl-test quick-test send-test library-test library-test-static \ btrfs.static mkfs.btrfs.static \ $(check_defs) \ diff --git a/check/check.h b/check/check.h new file mode 100644 index 0000000..61d1cac --- /dev/null +++ b/check/check.h @@ -0,0 +1,21 @@ +/* + * Copyright (C) 2016 Fujitsu. All rights reserved. + * + * This program is free software; you can redistribute it and/or + * modify it under the terms of the GNU General Public + * License v2 as published by the Free Software Foundation. + * + * This program is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU + * General Public License for more details. + * + * You should have received a copy of the GNU General Public + * License along with this program; if not, write to the + * Free Software Foundation, Inc., 59 Temple Place - Suite 330, + * Boston, MA 021110-1307, USA. + */ + +/* check/csum.c */ +int btrfs_read_one_data_csum(struct btrfs_fs_info *fs_info, u64 bytenr, + void *csum_ret); diff --git a/check/csum.c b/check/csum.c new file mode 100644 index 0000000..53195ea --- /dev/null +++ b/check/csum.c @@ -0,0 +1,96 @@ +/* + * Copyright (C) 2016 Fujitsu. All rights reserved. + * + * This program is free software; you can redistribute it and/or + * modify it under the terms of the GNU General Public + * License v2 as published by the Free Software Foundation. + * + * This program is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU + * General Public License for more details. + * + * You should have received a copy of the GNU General Public + * License along with this program; if not, write to the + * Free Software Foundation, Inc., 59 Temple Place - Suite 330, + * Boston, MA 021110-1307, USA. + */ + +#include "ctree.h" +#include "utils.h" +/* + * TODO: + * 1) Add write support for csum + * So we can write new data extents and add csum into csum tree + * 2) Add csum range search function + * So we don't need to search csum tree in a per-sectorsize loop. + */ + +int btrfs_read_one_data_csum(struct btrfs_fs_info *fs_info, u64 bytenr, + void *csum_ret) +{ + struct btrfs_path *path; + struct btrfs_key key; + struct btrfs_root *csum_root = fs_info->csum_root; + u32 item_offset; + u32 item_size; + u32 final_offset; + u32 sectorsize = fs_info->tree_root->sectorsize; + u16 csum_size = btrfs_super_csum_size(fs_info->super_copy); + int ret; + + if (!csum_ret) { + error("wrong parameter for %s", __func__); + return -EINVAL; + } + path = btrfs_alloc_path(); + if (!path) + return -ENOMEM; + + key.objectid = BTRFS_EXTENT_CSUM_OBJECTID; + key.type = BTRFS_EXTENT_CSUM_KEY; + key.offset = bytenr; + + ret = btrfs_search_slot(NULL, csum_root, &key, path, 0, 0); + if (ret < 0) + goto out; + if (ret == 0) { + btrfs_item_key_to_cpu(path->nodes[0], &key, path->slots[0]); + if (!IS_ALIGNED(key.offset, sectorsize)) { + error("csum item bytenr %llu is not aligned to %u", + key.offset, sectorsize); + ret = -EIO; + goto out; + } + u32 offset = btrfs_item_ptr_offset(path->nodes[0], + path->slots[0]); + + read_extent_buffer(path->nodes[0], csum_ret, offset, csum_size); + goto out; + } + ret = btrfs_previous_item(csum_root, path, BTRFS_EXTENT_CSUM_OBJECTID, + BTRFS_EXTENT_CSUM_KEY); + if (ret) + goto out; + btrfs_item_key_to_cpu(path->nodes[0], &key, path->slots[0]); + if (!IS_ALIGNED(key.offset, sectorsize)) { + error("csum item bytenr %llu is not aligned to %u", + key.offset, sectorsize); + ret = -EIO; + goto out; + } + item_offset = btrfs_item_ptr_offset(path->nodes[0], path->slots[0]); + item_size = btrfs_item_size_nr(path->nodes[0], path->slots[0]); + if (key.offset + item_size / csum_size * sectorsize <= bytenr) { + ret = 1; + goto out; + } + + final_offset = (bytenr - key.offset) / sectorsize * csum_size + + item_offset; + read_extent_buffer(path->nodes[0], csum_ret, final_offset, csum_size); + ret = 0; +out: + btrfs_free_path(path); + return ret; +};