diff mbox

btrfs-progs: Initialize btrfs_path before use

Message ID 20161024145754.7165-1-rgoldwyn@suse.de (mailing list archive)
State New, archived
Headers show

Commit Message

Goldwyn Rodrigues Oct. 24, 2016, 2:57 p.m. UTC 
From: Goldwyn Rodrigues <rgoldwyn@suse.com>

While performing an fsck, an assertion failure occurs because of reusing path in a loop.
ctree.c:1112: btrfs_search_slot: Warning: assertion `p->nodes[0] != NULL` failed, value 0

Signed-off-by: Goldwyn Rodrigues <rgoldwyn@suse.com>

--
To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Comments

Filipe Manana Oct. 24, 2016, 3:06 p.m. UTC | #1 
On Mon, Oct 24, 2016 at 3:57 PM, Goldwyn Rodrigues <rgoldwyn@suse.de> wrote:
> From: Goldwyn Rodrigues <rgoldwyn@suse.com>
>
> While performing an fsck, an assertion failure occurs because of reusing path in a loop.
> ctree.c:1112: btrfs_search_slot: Warning: assertion `p->nodes[0] != NULL` failed, value 0
>
> Signed-off-by: Goldwyn Rodrigues <rgoldwyn@suse.com>
>
> diff --git a/cmds-check.c b/cmds-check.c
> index 670ccd1..a6f281c 100644
> --- a/cmds-check.c
> +++ b/cmds-check.c
> @@ -7541,6 +7541,7 @@ static int record_orphan_data_extents(struct btrfs_fs_info *fs_info,
>                 key.objectid = dback->owner;
>                 key.type = BTRFS_EXTENT_DATA_KEY;
>                 key.offset = dback->offset;
> +               btrfs_init_path(path);

Hi Goldwyn,

You want to call btrfs_release_path(), otherwise you leak memory. And
it would be better placed before the 'continue' statement.

thanks

>
>                 ret = btrfs_search_slot(NULL, dest_root, &key, path, 0, 0);
>                 /*
> --
> To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
Goldwyn Rodrigues Oct. 24, 2016, 3:14 p.m. UTC | #2 
On 10/24/2016 09:57 AM, Goldwyn Rodrigues wrote:
> From: Goldwyn Rodrigues <rgoldwyn@suse.com>
> 
> While performing an fsck, an assertion failure occurs because of reusing path in a loop.
> ctree.c:1112: btrfs_search_slot: Warning: assertion `p->nodes[0] != NULL` failed, value 0
> 
> Signed-off-by: Goldwyn Rodrigues <rgoldwyn@suse.com>
> 
> diff --git a/cmds-check.c b/cmds-check.c
> index 670ccd1..a6f281c 100644
> --- a/cmds-check.c
> +++ b/cmds-check.c
> @@ -7541,6 +7541,7 @@ static int record_orphan_data_extents(struct btrfs_fs_info *fs_info,
>  		key.objectid = dback->owner;
>  		key.type = BTRFS_EXTENT_DATA_KEY;
>  		key.offset = dback->offset;
> +		btrfs_init_path(path);
>  
>  		ret = btrfs_search_slot(NULL, dest_root, &key, path, 0, 0);
>  		/*
> 

This is an incorrect fix. Please ignore. I shall send the correct fix
shortly. It should be release_path() instead.
diff mbox

Patch

diff --git a/cmds-check.c b/cmds-check.c
index 670ccd1..a6f281c 100644
--- a/cmds-check.c
+++ b/cmds-check.c
@@ -7541,6 +7541,7 @@  static int record_orphan_data_extents(struct btrfs_fs_info *fs_info,
 		key.objectid = dback->owner;
 		key.type = BTRFS_EXTENT_DATA_KEY;
 		key.offset = dback->offset;
+		btrfs_init_path(path);
 
 		ret = btrfs_search_slot(NULL, dest_root, &key, path, 0, 0);
 		/*