From patchwork Thu Mar 16 09:08:51 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Qu Wenruo X-Patchwork-Id: 9627705 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id AEF7B604A9 for ; Thu, 16 Mar 2017 09:09:08 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id A29AA28673 for ; Thu, 16 Mar 2017 09:09:08 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 979EA28674; Thu, 16 Mar 2017 09:09:08 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=2.0 tests=BAYES_00,RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 2DA922866E for ; Thu, 16 Mar 2017 09:09:08 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752090AbdCPJJG (ORCPT ); Thu, 16 Mar 2017 05:09:06 -0400 Received: from cn.fujitsu.com ([59.151.112.132]:11610 "EHLO heian.cn.fujitsu.com" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1752052AbdCPJJD (ORCPT ); Thu, 16 Mar 2017 05:09:03 -0400 X-IronPort-AV: E=Sophos;i="5.22,518,1449504000"; d="scan'208";a="16647191" Received: from unknown (HELO cn.fujitsu.com) ([10.167.33.5]) by heian.cn.fujitsu.com with ESMTP; 16 Mar 2017 17:09:00 +0800 Received: from G08CNEXCHPEKD01.g08.fujitsu.local (unknown [10.167.33.80]) by cn.fujitsu.com (Postfix) with ESMTP id AA06549F9A6E; Thu, 16 Mar 2017 17:08:59 +0800 (CST) Received: from localhost.localdomain (10.167.226.34) by G08CNEXCHPEKD01.g08.fujitsu.local (10.167.33.89) with Microsoft SMTP Server (TLS) id 14.3.319.2; Thu, 16 Mar 2017 17:08:58 +0800 From: Qu Wenruo To: CC: Subject: [PATCH v2 3/3] fstests: btrfs: Test inband dedupe with data balance. Date: Thu, 16 Mar 2017 17:08:51 +0800 Message-ID: <20170316090851.21608-4-quwenruo@cn.fujitsu.com> X-Mailer: git-send-email 2.12.0 In-Reply-To: <20170316090851.21608-1-quwenruo@cn.fujitsu.com> References: <20170316090851.21608-1-quwenruo@cn.fujitsu.com> MIME-Version: 1.0 X-Originating-IP: [10.167.226.34] X-yoursite-MailScanner-ID: AA06549F9A6E.A28A8 X-yoursite-MailScanner: Found to be clean X-yoursite-MailScanner-From: quwenruo@cn.fujitsu.com Sender: linux-btrfs-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-btrfs@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Btrfs balance will reloate date extent, but its hash is removed too late at run_delayed_ref() time, which will cause extent ref increased during balance, cause either find_data_references() gives WARN_ON() or even run_delayed_refs() fails and cause transaction abort. Add such concurrency test for inband dedupe and data balance. Signed-off-by: Qu Wenruo --- tests/btrfs/202 | 109 ++++++++++++++++++++++++++++++++++++++++++++++++++++ tests/btrfs/202.out | 3 ++ tests/btrfs/group | 1 + 3 files changed, 113 insertions(+) create mode 100755 tests/btrfs/202 create mode 100644 tests/btrfs/202.out diff --git a/tests/btrfs/202 b/tests/btrfs/202 new file mode 100755 index 0000000..60bb924 --- /dev/null +++ b/tests/btrfs/202 @@ -0,0 +1,109 @@ +#! /bin/bash +# FS QA Test 203 +# +# Btrfs inband dedupe with balance concurrency test +# +# This can spot inband dedupe error which will increase delayed ref on +# an data extent inside RO block group +# +#----------------------------------------------------------------------- +# Copyright (c) 2017 Fujitsu. All Rights Reserved. +# +# This program is free software; you can redistribute it and/or +# modify it under the terms of the GNU General Public License as +# published by the Free Software Foundation. +# +# This program is distributed in the hope that it would be useful, +# but WITHOUT ANY WARRANTY; without even the implied warranty of +# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the +# GNU General Public License for more details. +# +# You should have received a copy of the GNU General Public License +# along with this program; if not, write the Free Software Foundation, +# Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA +#----------------------------------------------------------------------- +# + +seq=`basename $0` +seqres=$RESULT_DIR/$seq +echo "QA output created by $seq" + +here=`pwd` +tmp=/tmp/$$ +status=1 # failure is the default! +trap "_cleanup; exit \$status" 0 1 2 3 15 + +_cleanup() +{ + cd / + kill $populate_pid &> /dev/null + kill $balance_pid &> /dev/null + wait + # Check later comment for reason + $BTRFS_UTIL_PROG balance cancel $SCRATCH_MNT &> /dev/null + rm -f $tmp.* +} + +# get standard environment, filters and checks +. ./common/rc +. ./common/filter +. ./common/reflink + +# remove previous $seqres.full before test +rm -f $seqres.full + +# real QA test starts here + +_supported_fs btrfs +_supported_os Linux +_require_scratch +_require_cp_reflink +_require_btrfs_command dedupe +_require_btrfs_fs_feature dedupe + +dedupe_bs=128k +file_size_in_kilo=4096 +init_file=$SCRATCH_MNT/foo +run_time=$((60 * $TIME_FACTOR)) + +_scratch_mkfs >> $seqres.full 2>&1 +_scratch_mount + +do_dedupe_balance_test() +{ + _run_btrfs_util_prog dedupe enable -b $dedupe_bs -s inmemory $SCRATCH_MNT + + # create the initial file and fill hash pool + $XFS_IO_PROG -f -c "pwrite -S 0x0 -b $dedupe_bs 0 $dedupe_bs" -c "fsync" \ + $init_file | _filter_xfs_io + + _btrfs_stress_balance $SCRATCH_MNT >/dev/null 2>&1 & + balance_pid=$! + + # Populate fs with all 0 data, to trigger enough in-band dedupe work + # to race with balance + _populate_fs -n 5 -f 10000000 -d 1 -r $SCRATCH_MNT \ + -s $file_size_in_kilo &> /dev/null & + populate_pid=$! + + sleep $run_time + + kill $populate_pid + kill $balance_pid + wait + + # Sometimes even we killed $balance_pid and wait returned, + # balance may still be running, use balance cancel to wait it. + # As this is just a workaround, we don't want it pollute seqres + # so call $BTRFS_UTIL_PROG directly + $BTRFS_UTIL_PROG balance cancel $SCRATCH_MNT &> /dev/null + + rm $SCRATCH_MNT/* -rf &> /dev/null + _run_btrfs_util_prog dedupe disable $SCRATCH_MNT +} + +do_dedupe_balance_test + +# success, all done +status=0 +exit diff --git a/tests/btrfs/202.out b/tests/btrfs/202.out new file mode 100644 index 0000000..ce03aa7 --- /dev/null +++ b/tests/btrfs/202.out @@ -0,0 +1,3 @@ +QA output created by 202 +wrote 131072/131072 bytes at offset 0 +XXX Bytes, X ops; XX:XX:XX.X (XXX YYY/sec and XXX ops/sec) diff --git a/tests/btrfs/group b/tests/btrfs/group index 1856d7e..930057a 100644 --- a/tests/btrfs/group +++ b/tests/btrfs/group @@ -143,3 +143,4 @@ 138 auto compress 200 auto ib-dedupe 201 auto ib-dedupe +202 auto ib-dedupe balance