From patchwork Mon Mar 27 21:07:20 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sergei Trofimovich X-Patchwork-Id: 9647459 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 9B126602BF for ; Mon, 27 Mar 2017 21:08:07 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 8995128364 for ; Mon, 27 Mar 2017 21:08:07 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 7E10B2843B; Mon, 27 Mar 2017 21:08:07 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.3 required=2.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, FREEMAIL_FROM, RCVD_IN_DNSWL_HI, RCVD_IN_SORBS_SPAM, T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 166BF28364 for ; Mon, 27 Mar 2017 21:08:06 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752215AbdC0VHd (ORCPT ); Mon, 27 Mar 2017 17:07:33 -0400 Received: from mail-wr0-f194.google.com ([209.85.128.194]:33303 "EHLO mail-wr0-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752452AbdC0VH3 (ORCPT ); Mon, 27 Mar 2017 17:07:29 -0400 Received: by mail-wr0-f194.google.com with SMTP id 20so16921799wrx.0 for ; Mon, 27 Mar 2017 14:07:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=bd6wUrXQdE2TkaUv86aknJp//ftVKRZRnRBeaH5d4cU=; b=ro5/CG9ToE9uKXBww2hektJ/h3PpTCQYpQeAppX7neZHMrZFYasneQE3CrU+X+mrnv 7qJMXLNBRAeC1t2y8WoP7IaTOStpI8w/7FXsT4FgIoiclDm/1ErwISqdngrwJ86lEmY0 RlQxts4dHcybDi/EnBu1q/jtq/ypeUmPMqygPlrzPVwBiHzyW69twUYu9BYzlVEgDQRz E2DLeYQV4jibwBkv7UCHObP8qb3Oo3l+0P22FiIkhup0Bkmbd6qrsqR3KjiG+CU7PbkA LYdglCksN2jIDrw8iEMWufaYYlbd4BcuARLHIdNVxQqc7y+kpWsHFpZY2la7RUzuil7g FeSA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=bd6wUrXQdE2TkaUv86aknJp//ftVKRZRnRBeaH5d4cU=; b=ZbFfaRdCSUsxa4Dj5GcKEf9lEM7GpHuIQzotP0EKvbtBAlUJ1B1RzL45+0NrCjKPoh skivXRu8V8pkNWIbItN505CSMjvNiL28uSIHaGUMOdyDLv2H5kFTDW47WmzBNOw5aovo 0p2g5WTikXV5bW+22YBTlUaE89tjps4CfdkCF+XNuTRIfMHg8+eJnz1SCaEFzW55pYdz Du+QBk+ABlwzVnn9qxXKPxStTQMg6IeqcgyEE5tPnimi+c9FYjQucNwRE34aelQ84hXx R7dkA8LwdsQOkVA+gnoThIaqRyOHcV73o2RzrSfEahVI8M0HzV+2/OFX7jNFPWK5WHrz Yobg== X-Gm-Message-State: AFeK/H2NRHWnP2giIS4TioXK1mb6OSycLpxIwZ09YH9LCVe+flLndOi6NrRDtINWdd+UKQ== X-Received: by 10.223.152.16 with SMTP id v16mr23438663wrb.8.1490648846859; Mon, 27 Mar 2017 14:07:26 -0700 (PDT) Received: from sf.home (host86-186-39-208.range86-186.btcentralplus.com. [86.186.39.208]) by smtp.gmail.com with ESMTPSA id k190sm921590wmg.10.2017.03.27.14.07.25 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 27 Mar 2017 14:07:26 -0700 (PDT) Received: by sf.home (Postfix, from userid 1000) id E12991AC4AE69; Mon, 27 Mar 2017 22:07:24 +0100 (BST) From: slyich@gmail.com To: David Sterba Cc: Sergei Trofimovich , linux-btrfs@vger.kernel.org, Mike Gilbert Subject: [PATCH] btrfs-progs: fix missing __error symbol in libbtrfs.so.0 Date: Mon, 27 Mar 2017 22:07:20 +0100 Message-Id: <20170327210720.10775-1-slyich@gmail.com> X-Mailer: git-send-email 2.12.1 In-Reply-To: <20170327114740.GA4781@twin.jikos.cz> References: <20170327114740.GA4781@twin.jikos.cz> Sender: linux-btrfs-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-btrfs@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP From: Sergei Trofimovich The easiest way to reproduce the error is to try to build btrfs-progs with $ make LDFLAGS=-Wl,--no-undefined btrfs-list.o: In function `lookup_ino_path': btrfs-list.c:(.text+0x7d2): undefined reference to `__error' Noticed by Denis Descheneaux when snapper tool stopped working after upgrade to btrfs-progs-4.10. As soname didn't change in 4.9 -> 4.10 release I assume it's just an object file omission in library depends and not the API/ABI change of the library error printing. Cc: linux-btrfs@vger.kernel.org Cc: Mike Gilbert Reported-by: Denis Descheneaux Bug: https://bugs.gentoo.org/show_bug.cgi?id=613890 Signed-off-by: Sergei Trofimovich --- Makefile | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/Makefile b/Makefile index fdc63c3a..35a8b47c 100644 --- a/Makefile +++ b/Makefile @@ -95,7 +95,7 @@ objects = ctree.o disk-io.o kernel-lib/radix-tree.o extent-tree.o print-tree.o \ qgroup.o raid56.o free-space-cache.o kernel-lib/list_sort.o props.o \ kernel-shared/ulist.o qgroup-verify.o backref.o string-table.o task-utils.o \ inode.o file.o find-root.o free-space-tree.o help.o send-dump.o \ - fsfeatures.o messages.o + fsfeatures.o cmds_objects = cmds-subvolume.o cmds-filesystem.o cmds-device.o cmds-scrub.o \ cmds-inspect.o cmds-balance.o cmds-send.o cmds-receive.o \ cmds-quota.o cmds-qgroup.o cmds-replace.o cmds-check.o \ @@ -104,7 +104,7 @@ cmds_objects = cmds-subvolume.o cmds-filesystem.o cmds-device.o cmds-scrub.o \ cmds-inspect-dump-super.o cmds-inspect-tree-stats.o cmds-fi-du.o \ mkfs/common.o libbtrfs_objects = send-stream.o send-utils.o kernel-lib/rbtree.o btrfs-list.o \ - kernel-lib/crc32c.o \ + kernel-lib/crc32c.o messages.o \ uuid-tree.o utils-lib.o rbtree-utils.o libbtrfs_headers = send-stream.h send-utils.h send.h kernel-lib/rbtree.h btrfs-list.h \ kernel-lib/crc32c.h kernel-lib/list.h kerncompat.h \ @@ -446,7 +446,7 @@ test-ioctl: ioctl-test ioctl-test-32 ioctl-test-64 $(Q)./ioctl-test-32 > ioctl-test-32.log $(Q)./ioctl-test-64 > ioctl-test-64.log -library-test: library-test.c messages.o $(libs_shared) +library-test: library-test.c $(libs_shared) @echo " [TEST PREP] $@"$(eval TMPD=$(shell mktemp -d)) $(Q)mkdir -p $(TMPD)/include/btrfs && \ cp $(libbtrfs_headers) $(TMPD)/include/btrfs && \ @@ -456,7 +456,7 @@ library-test: library-test.c messages.o $(libs_shared) @echo " [TEST CLEAN] $@" $(Q)$(RM) -rf -- $(TMPD) -library-test.static: library-test.c messages.static.o $(libs_static) +library-test.static: library-test.c $(libs_static) @echo " [TEST PREP] $@"$(eval TMPD=$(shell mktemp -d)) $(Q)mkdir -p $(TMPD)/include/btrfs && \ cp $(libbtrfs_headers) $(TMPD)/include/btrfs && \