From patchwork Fri Aug 11 02:13:17 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Adam Borowski X-Patchwork-Id: 9894819 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 4E25F60236 for ; Fri, 11 Aug 2017 02:13:42 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 3FBC328C62 for ; Fri, 11 Aug 2017 02:13:42 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 3337D28C64; Fri, 11 Aug 2017 02:13:42 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=2.0 tests=BAYES_00,RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id DDA1328C60 for ; Fri, 11 Aug 2017 02:13:41 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752208AbdHKCN1 (ORCPT ); Thu, 10 Aug 2017 22:13:27 -0400 Received: from tartarus.angband.pl ([89.206.35.136]:50743 "EHLO tartarus.angband.pl" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751715AbdHKCN0 (ORCPT ); Thu, 10 Aug 2017 22:13:26 -0400 Received: from kilobyte by tartarus.angband.pl with local (Exim 4.89) (envelope-from ) id 1dfzRt-00037w-5M; Fri, 11 Aug 2017 04:13:17 +0200 Date: Fri, 11 Aug 2017 04:13:17 +0200 From: Adam Borowski To: Nick Terrell Cc: "Austin S . Hemmelgarn" , kernel-team@fb.com, Chris Mason , Yann Collet , David Sterba , linux-btrfs@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v5 3/5] btrfs: Add zstd support Message-ID: <20170811021317.ykbpots4vinw7yjb@angband.pl> References: <20170810023553.3200875-1-terrelln@fb.com> <20170810023902.3231324-1-terrelln@fb.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20170810023902.3231324-1-terrelln@fb.com> X-Junkbait: aaron@angband.pl, zzyx@angband.pl User-Agent: NeoMutt/20170113 (1.7.2) X-SA-Exim-Connect-IP: X-SA-Exim-Mail-From: kilobyte@angband.pl X-SA-Exim-Scanned: No (on tartarus.angband.pl); SAEximRunCond expanded to false Sender: linux-btrfs-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-btrfs@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP On Wed, Aug 09, 2017 at 07:39:02PM -0700, Nick Terrell wrote: > Add zstd compression and decompression support to BtrFS. Re-tested on arm64, amd64 and i386, this time everything seems fine so far. As I'm too lazy to have a separate test setup for the zlib level patch, I'm using a dummy implementation: It might be worthwhile to do some early testing using different levels, though. 喵! --- a/fs/btrfs/zstd.c +++ b/fs/btrfs/zstd.c @@ -423,10 +423,16 @@ static int zstd_decompress(struct list_head *ws, unsigned char *data_in, return ret; } +static void zstd_set_level(struct list_head *ws, unsigned int type) +{ + // TODO +} + const struct btrfs_compress_op btrfs_zstd_compress = { .alloc_workspace = zstd_alloc_workspace, .free_workspace = zstd_free_workspace, .compress_pages = zstd_compress_pages, .decompress_bio = zstd_decompress_bio, .decompress = zstd_decompress, + .set_level = zstd_set_level, };