| Message ID | 20170917090226.GA30640@ircssh-2.c.rugged-nimbus-611.internal (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On 2017年09月17日 17:02, Sargun Dhillon wrote: > Previously, we were calling del_qgroup_item, and ignoring the return code > resulting in a potential to have divergent in-memory state without an > error. Perhaps, it makes sense to handle this error code, and put the > filesystem into a read only, or similar state. > > This patch only adds reporting of the error if the error is fatal, > (any error other than qgroup not found). > > Signed-off-by: Sargun Dhillon <sargun@sargun.me> Looks good to me. Reviewed-by: Qu Wenruo <quwenruo.btrfs@gmx.com> Thanks, Qu > --- > fs/btrfs/qgroup.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/fs/btrfs/qgroup.c b/fs/btrfs/qgroup.c > index 770f667269f5..e172d4843eae 100644 > --- a/fs/btrfs/qgroup.c > +++ b/fs/btrfs/qgroup.c > @@ -1305,6 +1305,8 @@ int btrfs_remove_qgroup(struct btrfs_trans_handle *trans, > } > } > ret = del_qgroup_item(trans, quota_root, qgroupid); > + if (ret && ret != -ENOENT) > + goto out > > while (!list_empty(&qgroup->groups)) { > list = list_first_entry(&qgroup->groups, > -- To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/fs/btrfs/qgroup.c b/fs/btrfs/qgroup.c index 770f667269f5..e172d4843eae 100644 --- a/fs/btrfs/qgroup.c +++ b/fs/btrfs/qgroup.c @@ -1305,6 +1305,8 @@ int btrfs_remove_qgroup(struct btrfs_trans_handle *trans, } } ret = del_qgroup_item(trans, quota_root, qgroupid); + if (ret && ret != -ENOENT) + goto out; while (!list_empty(&qgroup->groups)) { list = list_first_entry(&qgroup->groups,
Previously, we were calling del_qgroup_item, and ignoring the return code resulting in a potential to have divergent in-memory state without an error. Perhaps, it makes sense to handle this error code, and put the filesystem into a read only, or similar state. This patch only adds reporting of the error if the error is fatal, (any error other than qgroup not found). Signed-off-by: Sargun Dhillon <sargun@sargun.me> --- fs/btrfs/qgroup.c | 2 ++ 1 file changed, 2 insertions(+)