From patchwork Wed Sep 27 06:34:38 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Su Yue X-Patchwork-Id: 9973187 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 47F7560375 for ; Wed, 27 Sep 2017 06:31:51 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 3C626290A6 for ; Wed, 27 Sep 2017 06:31:51 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 3B0BC290C4; Wed, 27 Sep 2017 06:31:51 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=2.0 tests=BAYES_00,RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id ACBDF290C5 for ; Wed, 27 Sep 2017 06:31:49 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751873AbdI0Gbq (ORCPT ); Wed, 27 Sep 2017 02:31:46 -0400 Received: from mail.cn.fujitsu.com ([183.91.158.132]:15502 "EHLO heian.cn.fujitsu.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751782AbdI0Gbp (ORCPT ); Wed, 27 Sep 2017 02:31:45 -0400 X-IronPort-AV: E=Sophos;i="5.42,443,1500912000"; d="scan'208";a="28475933" Received: from localhost (HELO cn.fujitsu.com) ([10.167.33.5]) by heian.cn.fujitsu.com with ESMTP; 27 Sep 2017 14:31:43 +0800 Received: from G08CNEXCHPEKD02.g08.fujitsu.local (unknown [10.167.33.83]) by cn.fujitsu.com (Postfix) with ESMTP id 87FFC47CAAD4 for ; Wed, 27 Sep 2017 14:31:41 +0800 (CST) Received: from archlinux.g08.fujitsu.local (10.167.226.129) by G08CNEXCHPEKD02.g08.fujitsu.local (10.167.33.89) with Microsoft SMTP Server (TLS) id 14.3.361.1; Wed, 27 Sep 2017 14:31:41 +0800 From: Su Yue To: Subject: [PATCH 3/5] btrfs-progs: check: error or return value of repair_root_items() Date: Wed, 27 Sep 2017 14:34:38 +0800 Message-ID: <20170927063440.25961-4-suy.fnst@cn.fujitsu.com> X-Mailer: git-send-email 2.14.1 In-Reply-To: <20170927063440.25961-1-suy.fnst@cn.fujitsu.com> References: <20170927063440.25961-1-suy.fnst@cn.fujitsu.com> MIME-Version: 1.0 X-Originating-IP: [10.167.226.129] X-yoursite-MailScanner-ID: 87FFC47CAAD4.AD786 X-yoursite-MailScanner: Found to be clean X-yoursite-MailScanner-From: suy.fnst@cn.fujitsu.com Sender: linux-btrfs-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-btrfs@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Return value of repair_root_items(): <0 on error =0 does nothing >0 if repair is enable, N roots is repaired; else N roots is corrupted. In the repair mode, there should be no error if return value is bigger than 0. Signed-off-by: Su Yue --- cmds-check.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/cmds-check.c b/cmds-check.c index 3e2f9faa..adc4a934 100644 --- a/cmds-check.c +++ b/cmds-check.c @@ -14646,8 +14646,8 @@ int cmd_check(int argc, char **argv) if (!init_extent_tree) { ret = repair_root_items(info); - err |= !!ret; if (ret < 0) { + err = !!ret; error("failed to repair root items: %s", strerror(-ret)); goto close_out;