From patchwork Mon Oct 30 22:32:45 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Justin Maggard X-Patchwork-Id: 10033357 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id A05616039A for ; Mon, 30 Oct 2017 22:33:37 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 9246A288A2 for ; Mon, 30 Oct 2017 22:33:37 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 871952897D; Mon, 30 Oct 2017 22:33:37 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=2.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED,FREEMAIL_FROM,RCVD_IN_DNSWL_HI,T_DKIM_INVALID autolearn=unavailable version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 16458288A2 for ; Mon, 30 Oct 2017 22:33:36 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753035AbdJ3Wde (ORCPT ); Mon, 30 Oct 2017 18:33:34 -0400 Received: from mail-pf0-f174.google.com ([209.85.192.174]:49588 "EHLO mail-pf0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751615AbdJ3Wdc (ORCPT ); Mon, 30 Oct 2017 18:33:32 -0400 Received: by mail-pf0-f174.google.com with SMTP id i5so12166686pfe.6; Mon, 30 Oct 2017 15:33:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id; bh=8QD9uwQgd8wPP+kms2gccjJsA9hGGgFJaV60ghWDkCw=; b=tL7rEUfh2t2dCUlANLHbW8VEu75de7zMIRKznOAEax/COlSXPf7cDov7dlRrZuUXFR SGVUHXk4pV2mEdOn+eseVi2QS3es3q3e6eibdib17D/Dw2T8eNu1/G0qiUESemAeF12F 68vimGvENdTW5i29iIuL2TSEuA2FbKRSjZI4ykxAQt7KPDaD0bTYcUuUEDX+ajRYN1N+ BQpg7oyTq4iy2uGkLBRxM52+PUa9FneGMAtnZgmyU7+epYt4nq6ESI/XF4Ej83rdLx9R 5vbpa8hiaOi9ci3ZX7PNpOEk46dkIw7pjCZPa/yWXj/eVWBKQLHNm+dMgQtULXQBM6qi L3PA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=8QD9uwQgd8wPP+kms2gccjJsA9hGGgFJaV60ghWDkCw=; b=ffSzRotn949u2k+saehu/tNJ2P9rzbqf+7v4MewOHtkoJdhPKIlpUh4+ZwQ1sY+R0T 5y8T30NTw5qFW7E2nuAKKz57200m+vuWg7Z339iE0V+gwKe0YmPWLDRCt1DxTAbhGQoM Tg77ItYxdGaPPnNOpEo3DdNRHChGHx6nY2Vc2sV2MiU/wbmOgvId+pxLBYz7Xte++rCd P/GYL/1JsQM8wHpF1gJC78p3DwsWquOOot2yis9AbYT3TT7dc8kByx0b1DAVOYxZwtPf 94W8HDNx3IEjqtqKOZHjCEolGCzn5AgB2rqAqObi8f9p2gb2+BP8rcW1MsQsf4cK7IFc p7iA== X-Gm-Message-State: AMCzsaVbI7iTpj5aP6wt74TvIP7cRvcVCNS/ub7gf0vWWZM/lKSPI2s5 9glAZUljadNG0iboqZmW8J5njqxg X-Google-Smtp-Source: ABhQp+QN5/3E/CgDF+dXVte+bUWwWK1/QXzMV7uPbquLK86SDTniNqDxZNGPViEiD1SeoW66JK59NA== X-Received: by 10.84.241.1 with SMTP id a1mr8665991pll.365.1509402811563; Mon, 30 Oct 2017 15:33:31 -0700 (PDT) Received: from jmaggard-thinkpad-t450s.infrant-6.com (198-0-192-140-static.hfc.comcastbusiness.net. [198.0.192.140]) by smtp.gmail.com with ESMTPSA id u46sm26399944pgn.80.2017.10.30.15.33.30 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Mon, 30 Oct 2017 15:33:30 -0700 (PDT) From: Justin Maggard X-Google-Original-From: Justin Maggard To: fstests@vger.kernel.org, linux-btrfs@vger.kernel.org Cc: Justin Maggard Subject: [PATCH] btrfs: test if receive with qgroups corrupts metadata Date: Mon, 30 Oct 2017 15:32:45 -0700 Message-Id: <20171030223245.21877-1-jmaggard@netgear.com> X-Mailer: git-send-email 2.14.2 Sender: linux-btrfs-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-btrfs@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP This test case does some concurrent send/receives with qgroups enabled. Currently (4.14-rc7) this usually results in btrfs check errors, and often also results in a WARN_ON in record_root_in_trans(). Bisecting points to 6426c7ad697d (btrfs: qgroup: Fix qgroup accounting when creating snapshot) as the culprit. Signed-off-by: Justin Maggard --- tests/btrfs/152 | 102 ++++++++++++++++++++++++++++++++++++++++++++++++++++ tests/btrfs/152.out | 13 +++++++ tests/btrfs/group | 1 + 3 files changed, 116 insertions(+) create mode 100755 tests/btrfs/152 create mode 100644 tests/btrfs/152.out diff --git a/tests/btrfs/152 b/tests/btrfs/152 new file mode 100755 index 0000000..ebb88ed --- /dev/null +++ b/tests/btrfs/152 @@ -0,0 +1,102 @@ +#! /bin/bash +# FS QA Test No. btrfs/152 +# +# Test that incremental send/receive operations don't corrupt metadata when +# qgroups are enabled. +# +#----------------------------------------------------------------------- +# +# Copyright (c) 2017 NETGEAR, Inc. All Rights Reserved. +# +# This program is free software; you can redistribute it and/or +# modify it under the terms of the GNU General Public License as +# published by the Free Software Foundation. +# +# This program is distributed in the hope that it would be useful, +# but WITHOUT ANY WARRANTY; without even the implied warranty of +# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the +# GNU General Public License for more details. +# +# You should have received a copy of the GNU General Public License +# along with this program; if not, write the Free Software Foundation, +# Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA +#----------------------------------------------------------------------- +# + +seq=`basename $0` +seqres=$RESULT_DIR/$seq +echo "QA output created by $seq" + +tmp=/tmp/$$ +status=1 # failure is the default! +trap "_cleanup; exit \$status" 0 1 2 3 15 + +_cleanup() +{ + cd / + rm -f $tmp.* +} + +# get standard environment, filters and checks +. ./common/rc +. ./common/filter + +# real QA test starts here +_supported_fs btrfs +_supported_os Linux +_require_scratch + +rm -f $seqres.full + +_scratch_mkfs >>$seqres.full 2>&1 +_scratch_mount + +# Enable quotas +$BTRFS_UTIL_PROG quota enable $SCRATCH_MNT + +# Create 2 source and 4 destination subvolumes +for subvol in subvol1 subvol2 recv1_1 recv1_2 recv2_1 recv2_2; do + $BTRFS_UTIL_PROG subvolume create $SCRATCH_MNT/$subvol | _filter_scratch +done +mkdir $SCRATCH_MNT/subvol{1,2}/.snapshots +touch $SCRATCH_MNT/subvol{1,2}/foo + +# Create base snapshots and send them +$BTRFS_UTIL_PROG subvolume snapshot -r $SCRATCH_MNT/subvol1 \ + $SCRATCH_MNT/subvol1/.snapshots/1 | _filter_scratch +$BTRFS_UTIL_PROG subvolume snapshot -r $SCRATCH_MNT/subvol2 \ + $SCRATCH_MNT/subvol2/.snapshots/1 | _filter_scratch +for recv in recv1_1 recv1_2 recv2_1 recv2_2; do + $BTRFS_UTIL_PROG send $SCRATCH_MNT/subvol1/.snapshots/1 2> /dev/null | \ + $BTRFS_UTIL_PROG receive $SCRATCH_MNT/${recv} | _filter_scratch +done + +# Now do 10 loops of concurrent incremental send/receives +for i in `seq 1 10`; do + prev=$i + curr=$((i+1)) + + $BTRFS_UTIL_PROG subvolume snapshot -r $SCRATCH_MNT/subvol1 \ + $SCRATCH_MNT/subvol1/.snapshots/${curr} > /dev/null + ($BTRFS_UTIL_PROG send -p $SCRATCH_MNT/subvol1/.snapshots/${prev} \ + $SCRATCH_MNT/subvol1/.snapshots/${curr} 2> /dev/null | \ + $BTRFS_UTIL_PROG receive $SCRATCH_MNT/recv1_1) > /dev/null & + ($BTRFS_UTIL_PROG send -p $SCRATCH_MNT/subvol1/.snapshots/${prev} \ + $SCRATCH_MNT/subvol1/.snapshots/${curr} 2> /dev/null | \ + $BTRFS_UTIL_PROG receive $SCRATCH_MNT/recv1_2) > /dev/null & + + $BTRFS_UTIL_PROG subvolume snapshot -r $SCRATCH_MNT/subvol2 \ + $SCRATCH_MNT/subvol2/.snapshots/${curr} > /dev/null + ($BTRFS_UTIL_PROG send -p $SCRATCH_MNT/subvol2/.snapshots/${prev} \ + $SCRATCH_MNT/subvol2/.snapshots/${curr} 2> /dev/null | \ + $BTRFS_UTIL_PROG receive $SCRATCH_MNT/recv2_1) > /dev/null & + ($BTRFS_UTIL_PROG send -p $SCRATCH_MNT/subvol2/.snapshots/${prev} \ + $SCRATCH_MNT/subvol2/.snapshots/${curr} 2> /dev/null | \ + $BTRFS_UTIL_PROG receive $SCRATCH_MNT/recv2_2) > /dev/null & + wait +done + +_scratch_unmount + +status=0 +exit diff --git a/tests/btrfs/152.out b/tests/btrfs/152.out new file mode 100644 index 0000000..a95bb57 --- /dev/null +++ b/tests/btrfs/152.out @@ -0,0 +1,13 @@ +QA output created by 152 +Create subvolume 'SCRATCH_MNT/subvol1' +Create subvolume 'SCRATCH_MNT/subvol2' +Create subvolume 'SCRATCH_MNT/recv1_1' +Create subvolume 'SCRATCH_MNT/recv1_2' +Create subvolume 'SCRATCH_MNT/recv2_1' +Create subvolume 'SCRATCH_MNT/recv2_2' +Create a readonly snapshot of 'SCRATCH_MNT/subvol1' in 'SCRATCH_MNT/subvol1/.snapshots/1' +Create a readonly snapshot of 'SCRATCH_MNT/subvol2' in 'SCRATCH_MNT/subvol2/.snapshots/1' +At subvol 1 +At subvol 1 +At subvol 1 +At subvol 1 diff --git a/tests/btrfs/group b/tests/btrfs/group index e17c275..fb94461 100644 --- a/tests/btrfs/group +++ b/tests/btrfs/group @@ -154,3 +154,4 @@ 149 auto quick send compress 150 auto quick dangerous 151 auto quick +152 auto quick metadata qgroup send