| Message ID | 20180513180317.GR30522@ZenIV.linux.org.uk (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Sun, May 13, 2018 at 07:03:18PM +0100, Al Viro wrote: > [spotted while going through ->d_fsdata handling around d_splice_alias(); > don't really care which tree that goes through] > > The only thing even looking at ->d_fsdata in there (since 2012) > had been kfree(dentry->d_fsdata) in btrfs_dentry_delete(). Which, > incidentally, is all btrfs_dentry_delete() does. Right, it's a leftover after the DCACHE_NEED_LOOKUP removal. I'll add it to btrfs tree, thanks. -- To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/fs/btrfs/inode.c b/fs/btrfs/inode.c index e064c49c9a9a..c6b2b0a20561 100644 --- a/fs/btrfs/inode.c +++ b/fs/btrfs/inode.c @@ -5842,11 +5842,6 @@ static int btrfs_dentry_delete(const struct dentry *dentry) return 0; } -static void btrfs_dentry_release(struct dentry *dentry) -{ - kfree(dentry->d_fsdata); -} - static struct dentry *btrfs_lookup(struct inode *dir, struct dentry *dentry, unsigned int flags) { @@ -10665,5 +10660,4 @@ static const struct inode_operations btrfs_symlink_inode_operations = { const struct dentry_operations btrfs_dentry_operations = { .d_delete = btrfs_dentry_delete, - .d_release = btrfs_dentry_release, };
[spotted while going through ->d_fsdata handling around d_splice_alias(); don't really care which tree that goes through] The only thing even looking at ->d_fsdata in there (since 2012) had been kfree(dentry->d_fsdata) in btrfs_dentry_delete(). Which, incidentally, is all btrfs_dentry_delete() does. Signed-off-by: Al Viro <viro@zeniv.linux.org.uk> -- To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html