| Message ID | 20181123084227.25840-1-jthumshirn@suse.de (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | btrfs: remove btrfs_bio_end_io_t | expand |
On 23.11.18 г. 10:42 ч., Johannes Thumshirn wrote: > The btrfs_bio_end_io_t typedef was introduced with commit > a1d3c4786a4b ("btrfs: btrfs_multi_bio replaced with btrfs_bio") > but never used anywhere. This commit also introduced a forward declaration > of 'struct btrfs_bio' which is only needed for btrfs_bio_end_io_t. > > Remove both as they're not needed anywhere. > > Signed-off-by: Johannes Thumshirn <jthumshirn@suse.de> Reviewed-by: Nikolay Borisov <nborisov@suse.com> > --- > fs/btrfs/volumes.h | 3 --- > 1 file changed, 3 deletions(-) > > diff --git a/fs/btrfs/volumes.h b/fs/btrfs/volumes.h > index 8b092bb1e2ee..c93097b0b469 100644 > --- a/fs/btrfs/volumes.h > +++ b/fs/btrfs/volumes.h > @@ -295,9 +295,6 @@ struct btrfs_bio_stripe { > u64 length; /* only used for discard mappings */ > }; > > -struct btrfs_bio; > -typedef void (btrfs_bio_end_io_t) (struct btrfs_bio *bio, int err); > - > struct btrfs_bio { > refcount_t refs; > atomic_t stripes_pending; >
On Fri, Nov 23, 2018 at 09:42:27AM +0100, Johannes Thumshirn wrote: > The btrfs_bio_end_io_t typedef was introduced with commit > a1d3c4786a4b ("btrfs: btrfs_multi_bio replaced with btrfs_bio") > but never used anywhere. This commit also introduced a forward declaration > of 'struct btrfs_bio' which is only needed for btrfs_bio_end_io_t. > > Remove both as they're not needed anywhere. > > Signed-off-by: Johannes Thumshirn <jthumshirn@suse.de> Added to misc-next, thanks.
diff --git a/fs/btrfs/volumes.h b/fs/btrfs/volumes.h index 8b092bb1e2ee..c93097b0b469 100644 --- a/fs/btrfs/volumes.h +++ b/fs/btrfs/volumes.h @@ -295,9 +295,6 @@ struct btrfs_bio_stripe { u64 length; /* only used for discard mappings */ }; -struct btrfs_bio; -typedef void (btrfs_bio_end_io_t) (struct btrfs_bio *bio, int err); - struct btrfs_bio { refcount_t refs; atomic_t stripes_pending;
The btrfs_bio_end_io_t typedef was introduced with commit a1d3c4786a4b ("btrfs: btrfs_multi_bio replaced with btrfs_bio") but never used anywhere. This commit also introduced a forward declaration of 'struct btrfs_bio' which is only needed for btrfs_bio_end_io_t. Remove both as they're not needed anywhere. Signed-off-by: Johannes Thumshirn <jthumshirn@suse.de> --- fs/btrfs/volumes.h | 3 --- 1 file changed, 3 deletions(-)