| Message ID | 20191210204429.3383471-1-arnd@arndb.de (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | btrfs: fix format string warning | expand |
On 12/10/19 3:44 PM, Arnd Bergmann wrote: > To print a size_t, the format string modifier %z should be used instead > of %l: > > fs/btrfs/tree-checker.c: In function 'check_extent_data_item': > fs/btrfs/tree-checker.c:230:43: error: format '%lu' expects argument of type 'long unsigned int', but argument 5 has type 'unsigned int' [-Werror=format=] > "invalid item size, have %u expect [%lu, %u)", > ~~^ > %u > > Fixes: 153a6d299956 ("btrfs: tree-checker: Check item size before reading file extent type") > Signed-off-by: Arnd Bergmann <arnd@arndb.de> Reviewed-by: Josef Bacik <josef@toxicpanda.com> Thanks, Josef
On Tue, Dec 10, 2019 at 09:44:16PM +0100, Arnd Bergmann wrote: > To print a size_t, the format string modifier %z should be used instead > of %l: > > fs/btrfs/tree-checker.c: In function 'check_extent_data_item': > fs/btrfs/tree-checker.c:230:43: error: format '%lu' expects argument of type 'long unsigned int', but argument 5 has type 'unsigned int' [-Werror=format=] > "invalid item size, have %u expect [%lu, %u)", > ~~^ > %u > > Fixes: 153a6d299956 ("btrfs: tree-checker: Check item size before reading file extent type") > Signed-off-by: Arnd Bergmann <arnd@arndb.de> Thanks, there's already fix for that in our devel queue, I'm going to send it to the next rc.
diff --git a/fs/btrfs/tree-checker.c b/fs/btrfs/tree-checker.c index 493d4d9e0f79..092b8ece36d7 100644 --- a/fs/btrfs/tree-checker.c +++ b/fs/btrfs/tree-checker.c @@ -227,7 +227,7 @@ static int check_extent_data_item(struct extent_buffer *leaf, */ if (item_size < BTRFS_FILE_EXTENT_INLINE_DATA_START) { file_extent_err(leaf, slot, - "invalid item size, have %u expect [%lu, %u)", + "invalid item size, have %u expect [%zu, %u)", item_size, BTRFS_FILE_EXTENT_INLINE_DATA_START, SZ_4K); return -EUCLEAN;
To print a size_t, the format string modifier %z should be used instead of %l: fs/btrfs/tree-checker.c: In function 'check_extent_data_item': fs/btrfs/tree-checker.c:230:43: error: format '%lu' expects argument of type 'long unsigned int', but argument 5 has type 'unsigned int' [-Werror=format=] "invalid item size, have %u expect [%lu, %u)", ~~^ %u Fixes: 153a6d299956 ("btrfs: tree-checker: Check item size before reading file extent type") Signed-off-by: Arnd Bergmann <arnd@arndb.de> --- fs/btrfs/tree-checker.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)