| Message ID | 20200702122335.9117-7-nborisov@suse.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | Corrupt counter improvement | expand |
On 7/2/20 8:23 AM, Nikolay Borisov wrote: > compressed_bio::orig_bio is always set in btrfs_submit_compressed_read > before any bio submission is performed. Since that function is always > called with a valid bio it renders the ASSERT unnecessary. > > Signed-off-by: Nikolay Borisov <nborisov@suse.com> > --- > fs/btrfs/compression.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/fs/btrfs/compression.c b/fs/btrfs/compression.c > index c2d5ca583dbf..db80c3fa6c08 100644 > --- a/fs/btrfs/compression.c > +++ b/fs/btrfs/compression.c > @@ -244,7 +244,6 @@ static void end_compressed_bio_read(struct bio *bio) > * Record the correct mirror_num in cb->orig_bio so that > * read-repair can work properly. > */ > - ASSERT(btrfs_io_bio(cb->orig_bio)); > btrfs_io_bio(cb->orig_bio)->mirror_num = mirror; > cb->mirror_num = mirror; > > Reviewed-by: Josef Bacik <josef@toxicpanda.com> Thanks, Josef
Looks good,
Reviewed-by: Johannes Thumshirn <johannes.thumshirn@wdc.com>
diff --git a/fs/btrfs/compression.c b/fs/btrfs/compression.c index c2d5ca583dbf..db80c3fa6c08 100644 --- a/fs/btrfs/compression.c +++ b/fs/btrfs/compression.c @@ -244,7 +244,6 @@ static void end_compressed_bio_read(struct bio *bio) * Record the correct mirror_num in cb->orig_bio so that * read-repair can work properly. */ - ASSERT(btrfs_io_bio(cb->orig_bio)); btrfs_io_bio(cb->orig_bio)->mirror_num = mirror; cb->mirror_num = mirror;
compressed_bio::orig_bio is always set in btrfs_submit_compressed_read before any bio submission is performed. Since that function is always called with a valid bio it renders the ASSERT unnecessary. Signed-off-by: Nikolay Borisov <nborisov@suse.com> --- fs/btrfs/compression.c | 1 - 1 file changed, 1 deletion(-)