diff mbox series

btrfs: block-group: Make read_block_group_item return void

Message ID 20200817135610.29338-1-marcos@mpdesouza.com (mailing list archive)
State New, archived
Headers show
Series btrfs: block-group: Make read_block_group_item return void | expand

Commit Message

Marcos Paulo de Souza Aug. 17, 2020, 1:56 p.m. UTC 
From: Marcos Paulo de Souza <mpdesouza@suse.com>

Since it's inclusion on 9afc66498a0b
("btrfs: block-group: refactor how we read one block group item") this
function always returned 0, so there is no need to check for the
returned value.

Signed-off-by: Marcos Paulo de Souza <mpdesouza@suse.com>
---
 fs/btrfs/block-group.c | 8 ++------
 1 file changed, 2 insertions(+), 6 deletions(-)

Comments

Nikolay Borisov Aug. 17, 2020, 1:59 p.m. UTC | #1 
On 17.08.20 г. 16:56 ч., Marcos Paulo de Souza wrote:
> From: Marcos Paulo de Souza <mpdesouza@suse.com>
> 
> Since it's inclusion on 9afc66498a0b
> ("btrfs: block-group: refactor how we read one block group item") this
> function always returned 0, so there is no need to check for the
> returned value.
> 
> Signed-off-by: Marcos Paulo de Souza <mpdesouza@suse.com>

Reviewed-by: Nikolay Borisov <nborisov@suse.com>
David Sterba Aug. 19, 2020, 3:53 p.m. UTC | #2 
On Mon, Aug 17, 2020 at 10:56:10AM -0300, Marcos Paulo de Souza wrote:
> From: Marcos Paulo de Souza <mpdesouza@suse.com>
> 
> Since it's inclusion on 9afc66498a0b
> ("btrfs: block-group: refactor how we read one block group item") this
> function always returned 0, so there is no need to check for the
> returned value.
> 
> Signed-off-by: Marcos Paulo de Souza <mpdesouza@suse.com>

Added to misc-next, thanks.
diff mbox series

Patch

diff --git a/fs/btrfs/block-group.c b/fs/btrfs/block-group.c
index 5b49e23e10d0..3891a1f731ba 100644
--- a/fs/btrfs/block-group.c
+++ b/fs/btrfs/block-group.c
@@ -1874,7 +1874,7 @@  static int check_chunk_block_group_mappings(struct btrfs_fs_info *fs_info)
 	return ret;
 }
 
-static int read_block_group_item(struct btrfs_block_group *cache,
+static void read_block_group_item(struct btrfs_block_group *cache,
 				 struct btrfs_path *path,
 				 const struct btrfs_key *key)
 {
@@ -1888,8 +1888,6 @@  static int read_block_group_item(struct btrfs_block_group *cache,
 			   sizeof(bgi));
 	cache->used = btrfs_stack_block_group_used(&bgi);
 	cache->flags = btrfs_stack_block_group_flags(&bgi);
-
-	return 0;
 }
 
 static int read_one_block_group(struct btrfs_fs_info *info,
@@ -1908,9 +1906,7 @@  static int read_one_block_group(struct btrfs_fs_info *info,
 	if (!cache)
 		return -ENOMEM;
 
-	ret = read_block_group_item(cache, path, key);
-	if (ret < 0)
-		goto error;
+	read_block_group_item(cache, path, key);
 
 	if (need_clear) {
 		/*