| Message ID | 20210809043230.3033804-1-naohiro.aota@wdc.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | btrfs: zoned: suppress reclaim error message on EAGAIN | expand |
For those following along at home:
btrfs_reclaim_bgs_work()
`-> btrfs_relocate_chunk()
`-> btrfs_relocate_block_group()
`-> reloc_chunk_start()
`-> if (fs_info->send_in_progress)
`-> return -EAGAIN
Looks good,
Reviewed-by: Johannes Thumshirn <johannes.thumshirn@wdc.com>
On 10/08/2021 12:32, Johannes Thumshirn wrote: > For those following along at home: > > btrfs_reclaim_bgs_work() > `-> btrfs_relocate_chunk() > `-> btrfs_relocate_block_group() > `-> reloc_chunk_start() > `-> if (fs_info->send_in_progress) > `-> return -EAGAIN > > > Looks good, > Reviewed-by: Johannes Thumshirn <johannes.thumshirn@wdc.com> > Totally forgot, this should probably also have: Fixes: 18bb8bbf13c1 ("btrfs: zoned: automatically reclaim zones")
On Mon, Aug 09, 2021 at 01:32:30PM +0900, Naohiro Aota wrote: > btrfs_relocate_chunk() can fail with -EAGAIN when e.g. send operations are > running. The message can fail btrfs/187 and it's unnecessary because we > anyway add it back to the reclaim list. > > Cc: Johannes Thumshirn <johannes.thumshirn@wdc.com> > Signed-off-by: Naohiro Aota <naohiro.aota@wdc.com> With the stacktrace and Fixes: added to misc-next, thanks.
diff --git a/fs/btrfs/block-group.c b/fs/btrfs/block-group.c index d5421ee0d366..a3b830b8410a 100644 --- a/fs/btrfs/block-group.c +++ b/fs/btrfs/block-group.c @@ -1561,7 +1561,7 @@ void btrfs_reclaim_bgs_work(struct work_struct *work) div64_u64(zone_unusable * 100, bg->length)); trace_btrfs_reclaim_block_group(bg); ret = btrfs_relocate_chunk(fs_info, bg->start); - if (ret) + if (ret && ret != -EAGAIN) btrfs_err(fs_info, "error relocating chunk %llu", bg->start);
btrfs_relocate_chunk() can fail with -EAGAIN when e.g. send operations are running. The message can fail btrfs/187 and it's unnecessary because we anyway add it back to the reclaim list. Cc: Johannes Thumshirn <johannes.thumshirn@wdc.com> Signed-off-by: Naohiro Aota <naohiro.aota@wdc.com> --- fs/btrfs/block-group.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)