From patchwork Thu Feb 20 11:04:38 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Filipe Manana X-Patchwork-Id: 13983774 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 675EA1F1913 for ; Thu, 20 Feb 2025 11:05:13 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1740049513; cv=none; b=djKgj1UgcPxCZsPTIsEHyKpGMmqaJIjXGl0fqDYggtGh6OwmVCpPKYshlA+fmvRhVkxTZbpe9W8HI/8W2NbwsJjTqdAS673MioAhCJVoGSQenR6ZX/n4yb08U/c7AtiP30wiVdPAVA3jGDn7nJ5KRwoLDxrh4+GbAgtlfP+bnvM= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1740049513; c=relaxed/simple; bh=YRwbdZySKM3CEdobzlcWa7QWhdjG3B8FlMUrlCzFH6U=; h=From:To:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=eRjWNPJnNownySbPa5nrSLKJMNdg6Xi4RGNb0mknMnZNIsZ5dXyAk5bTk9/SvUYLTBtivacqo8d72FQPu34l4Fl9j3uR/WNDsoSWkBP8qQpKpGZCKdhi/oQ0jGU21Qx9jho3zWADbTVIT+OuZQSReVKocYvmmYBAp0Jq7q95fQQ= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=m+HWilIS; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="m+HWilIS" Received: by smtp.kernel.org (Postfix) with ESMTPSA id B75CEC4CEE3 for ; Thu, 20 Feb 2025 11:05:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1740049513; bh=YRwbdZySKM3CEdobzlcWa7QWhdjG3B8FlMUrlCzFH6U=; h=From:To:Subject:Date:In-Reply-To:References:From; b=m+HWilISCi1zKKMd6goABkMRLH8LyaUnjSQyta/sQ+FRFo8JPUXndcq/+NrNk0k+y Hdzt6/uUgZ6m8uBILmGTh31i0Sprixm53lvntkytBbRNFtDK/UlsCy4GgWxoVSxsJN KrHVruFEnfGtZmbUDeq9tlRJ6L+C7aIXln+aCfi0mZ7AJWb1Dh/TfcJdwi6t0MxWI5 zfoo+iKfiyo1sr37EpqDqivIpEO+7QLKTWVUlvEHRma5jGgUqPsSDr1JqmUtJkJLaj t1IEYqeqCEjNwyLCaPU9zKRuLh/1baGkiELff4ovNqEHM4pc4iNoZ15b52VgX7MkAM tc0R32PU3sgLA== From: fdmanana@kernel.org To: linux-btrfs@vger.kernel.org Subject: [PATCH v2 25/30] btrfs: send: simplify return logic from send_link() Date: Thu, 20 Feb 2025 11:04:38 +0000 Message-Id: <3f719e4e989a54bf8cf671d5227969a8e61fc0a1.1740049233.git.fdmanana@suse.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: References: Precedence: bulk X-Mailing-List: linux-btrfs@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 From: Filipe Manana There is no need to have an 'out' label and jump into it since there are no resource cleanups to perform (release locks, free memory, etc), so make this simpler by removing the label and goto and instead return directly. Signed-off-by: Filipe Manana --- fs/btrfs/send.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/fs/btrfs/send.c b/fs/btrfs/send.c index d5c151651d07..bda229c7084b 100644 --- a/fs/btrfs/send.c +++ b/fs/btrfs/send.c @@ -833,7 +833,7 @@ static int send_link(struct send_ctx *sctx, ret = begin_cmd(sctx, BTRFS_SEND_C_LINK); if (ret < 0) - goto out; + return ret; TLV_PUT_PATH(sctx, BTRFS_SEND_A_PATH, path); TLV_PUT_PATH(sctx, BTRFS_SEND_A_PATH_LINK, lnk); @@ -841,7 +841,6 @@ static int send_link(struct send_ctx *sctx, ret = send_cmd(sctx); tlv_put_failure: -out: return ret; }