From patchwork Fri Jul 29 17:42:44 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: David Sterba X-Patchwork-Id: 12932757 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3F7EEC00144 for ; Fri, 29 Jul 2022 17:47:50 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238091AbiG2Rrq (ORCPT ); Fri, 29 Jul 2022 13:47:46 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58016 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238067AbiG2Rrp (ORCPT ); Fri, 29 Jul 2022 13:47:45 -0400 Received: from smtp-out1.suse.de (smtp-out1.suse.de [IPv6:2001:67c:2178:6::1c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2B00578221 for ; Fri, 29 Jul 2022 10:47:44 -0700 (PDT) Received: from relay2.suse.de (relay2.suse.de [149.44.160.134]) by smtp-out1.suse.de (Postfix) with ESMTP id D3A5834EB9; Fri, 29 Jul 2022 17:47:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1659116862; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=2CmiGUD32KJuNwiZ7RC5DjMMpuook+8acby188BqW6Y=; b=kZD2WTdmooNpIdgc80YSdTZRc7ZK1C5quBlrnWf5a3h4V8MCnSHtK9UG30XdXTeoQ33h/k XgLo9n02kvbtW+gMysJaqXJpEJm6t2+Rx1VlVrHXlXzMHqJJ1BRbSvW7DjUqAelKOqlOmd g/DdU3zjYnQwG9wECRBsw6M7Ki8d2Ns= Received: from ds.suse.cz (ds.suse.cz [10.100.12.205]) by relay2.suse.de (Postfix) with ESMTP id C90832C141; Fri, 29 Jul 2022 17:47:42 +0000 (UTC) Received: by ds.suse.cz (Postfix, from userid 10065) id BBC69DA85A; Fri, 29 Jul 2022 19:42:44 +0200 (CEST) From: David Sterba To: linux-btrfs@vger.kernel.org Cc: David Sterba Subject: [PATCH v2 1/4] btrfs: prepare more slots for checksum shash Date: Fri, 29 Jul 2022 19:42:44 +0200 Message-Id: <42f231d8d6f95fdc731b423fdc7c3ae2a6685318.1659116355.git.dsterba@suse.com> X-Mailer: git-send-email 2.36.1 In-Reply-To: References: MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-btrfs@vger.kernel.org There's now one checksum template fs_info::csum_shash that contains whatever the crypto API decides is the best available implementation. To allow loading other implementations after mount add more slots and symbolic names. The slot 0 is always used when calculating checksum, other slots may be set later or left empty. Signed-off-by: David Sterba --- fs/btrfs/check-integrity.c | 4 ++-- fs/btrfs/ctree.h | 13 ++++++++++++- fs/btrfs/disk-io.c | 19 ++++++++++--------- fs/btrfs/file-item.c | 4 ++-- fs/btrfs/inode.c | 2 +- fs/btrfs/scrub.c | 12 ++++++------ fs/btrfs/sysfs.c | 2 +- 7 files changed, 34 insertions(+), 22 deletions(-) diff --git a/fs/btrfs/check-integrity.c b/fs/btrfs/check-integrity.c index 5d20137b7b67..dbabdd01ed66 100644 --- a/fs/btrfs/check-integrity.c +++ b/fs/btrfs/check-integrity.c @@ -1647,7 +1647,7 @@ static noinline_for_stack int btrfsic_test_for_metadata( char **datav, unsigned int num_pages) { struct btrfs_fs_info *fs_info = state->fs_info; - SHASH_DESC_ON_STACK(shash, fs_info->csum_shash); + SHASH_DESC_ON_STACK(shash, fs_info->csum_shash[CSUM_DEFAULT]); struct btrfs_header *h; u8 csum[BTRFS_CSUM_SIZE]; unsigned int i; @@ -1660,7 +1660,7 @@ static noinline_for_stack int btrfsic_test_for_metadata( if (memcmp(h->fsid, fs_info->fs_devices->fsid, BTRFS_FSID_SIZE)) return 1; - shash->tfm = fs_info->csum_shash; + shash->tfm = fs_info->csum_shash[CSUM_DEFAULT]; crypto_shash_init(shash); for (i = 0; i < num_pages; i++) { diff --git a/fs/btrfs/ctree.h b/fs/btrfs/ctree.h index e6a084a9214c..1e55dfa49827 100644 --- a/fs/btrfs/ctree.h +++ b/fs/btrfs/ctree.h @@ -674,6 +674,13 @@ struct btrfs_commit_stats { u64 total_commit_dur; }; +enum btrfs_csum_impl { + CSUM_DEFAULT, + CSUM_GENERIC, + CSUM_ACCEL, + CSUM_COUNT +}; + struct btrfs_fs_info { u8 chunk_tree_uuid[BTRFS_UUID_SIZE]; unsigned long flags; @@ -1061,7 +1068,11 @@ struct btrfs_fs_info { spinlock_t swapfile_pins_lock; struct rb_root swapfile_pins; - struct crypto_shash *csum_shash; + /* + * Templates for checksum calculation, slot 0 is for the currently used + * one, other slots are optional for available implementations. + */ + struct crypto_shash *csum_shash[CSUM_COUNT]; /* Type of exclusive operation running, protected by super_lock */ enum btrfs_exclusive_operation exclusive_operation; diff --git a/fs/btrfs/disk-io.c b/fs/btrfs/disk-io.c index 6ac8d73d4b51..3c2251199f0c 100644 --- a/fs/btrfs/disk-io.c +++ b/fs/btrfs/disk-io.c @@ -65,8 +65,9 @@ static void btrfs_error_commit_super(struct btrfs_fs_info *fs_info); static void btrfs_free_csum_hash(struct btrfs_fs_info *fs_info) { - if (fs_info->csum_shash) - crypto_free_shash(fs_info->csum_shash); + for (int i = 0; i < CSUM_COUNT; i++) + if (fs_info->csum_shash[i]) + crypto_free_shash(fs_info->csum_shash[i]); } /* @@ -176,11 +177,11 @@ static void csum_tree_block(struct extent_buffer *buf, u8 *result) struct btrfs_fs_info *fs_info = buf->fs_info; const int num_pages = num_extent_pages(buf); const int first_page_part = min_t(u32, PAGE_SIZE, fs_info->nodesize); - SHASH_DESC_ON_STACK(shash, fs_info->csum_shash); + SHASH_DESC_ON_STACK(shash, fs_info->csum_shash[CSUM_DEFAULT]); char *kaddr; int i; - shash->tfm = fs_info->csum_shash; + shash->tfm = fs_info->csum_shash[CSUM_DEFAULT]; crypto_shash_init(shash); kaddr = page_address(buf->pages[0]) + offset_in_page(buf->start); crypto_shash_update(shash, kaddr + BTRFS_CSUM_SIZE, @@ -255,9 +256,9 @@ static int btrfs_check_super_csum(struct btrfs_fs_info *fs_info, struct btrfs_super_block *disk_sb = (struct btrfs_super_block *)raw_disk_sb; char result[BTRFS_CSUM_SIZE]; - SHASH_DESC_ON_STACK(shash, fs_info->csum_shash); + SHASH_DESC_ON_STACK(shash, fs_info->csum_shash[CSUM_DEFAULT]); - shash->tfm = fs_info->csum_shash; + shash->tfm = fs_info->csum_shash[CSUM_DEFAULT]; /* * The super_block structure does not span the whole @@ -2429,7 +2430,7 @@ static int btrfs_init_csum_hash(struct btrfs_fs_info *fs_info, u16 csum_type) return PTR_ERR(csum_shash); } - fs_info->csum_shash = csum_shash; + fs_info->csum_shash[CSUM_DEFAULT] = csum_shash; btrfs_info(fs_info, "using %s (%s) checksum algorithm", btrfs_super_csum_name(csum_type), @@ -4012,7 +4013,7 @@ static int write_dev_supers(struct btrfs_device *device, { struct btrfs_fs_info *fs_info = device->fs_info; struct address_space *mapping = device->bdev->bd_inode->i_mapping; - SHASH_DESC_ON_STACK(shash, fs_info->csum_shash); + SHASH_DESC_ON_STACK(shash, fs_info->csum_shash[CSUM_DEFAULT]); int i; int errors = 0; int ret; @@ -4021,7 +4022,7 @@ static int write_dev_supers(struct btrfs_device *device, if (max_mirrors == 0) max_mirrors = BTRFS_SUPER_MIRROR_MAX; - shash->tfm = fs_info->csum_shash; + shash->tfm = fs_info->csum_shash[CSUM_DEFAULT]; for (i = 0; i < max_mirrors; i++) { struct page *page; diff --git a/fs/btrfs/file-item.c b/fs/btrfs/file-item.c index c828f971a346..6e416230733b 100644 --- a/fs/btrfs/file-item.c +++ b/fs/btrfs/file-item.c @@ -635,7 +635,7 @@ blk_status_t btrfs_csum_one_bio(struct btrfs_inode *inode, struct bio *bio, u64 offset, bool one_ordered) { struct btrfs_fs_info *fs_info = inode->root->fs_info; - SHASH_DESC_ON_STACK(shash, fs_info->csum_shash); + SHASH_DESC_ON_STACK(shash, fs_info->csum_shash[CSUM_DEFAULT]); struct btrfs_ordered_sum *sums; struct btrfs_ordered_extent *ordered = NULL; const bool use_page_offsets = (offset == (u64)-1); @@ -663,7 +663,7 @@ blk_status_t btrfs_csum_one_bio(struct btrfs_inode *inode, struct bio *bio, sums->bytenr = bio->bi_iter.bi_sector << 9; index = 0; - shash->tfm = fs_info->csum_shash; + shash->tfm = fs_info->csum_shash[CSUM_DEFAULT]; bio_for_each_segment(bvec, bio, iter) { if (use_page_offsets) diff --git a/fs/btrfs/inode.c b/fs/btrfs/inode.c index ecc5fa3343fc..a16a7379c58d 100644 --- a/fs/btrfs/inode.c +++ b/fs/btrfs/inode.c @@ -3429,7 +3429,7 @@ int btrfs_check_sector_csum(struct btrfs_fs_info *fs_info, struct page *page, ASSERT(pgoff + fs_info->sectorsize <= PAGE_SIZE); - shash->tfm = fs_info->csum_shash; + shash->tfm = fs_info->csum_shash[CSUM_DEFAULT]; kaddr = kmap_local_page(page) + pgoff; crypto_shash_digest(shash, kaddr, fs_info->sectorsize, csum); diff --git a/fs/btrfs/scrub.c b/fs/btrfs/scrub.c index 3afe5fa50a63..f67a35cf0446 100644 --- a/fs/btrfs/scrub.c +++ b/fs/btrfs/scrub.c @@ -1775,7 +1775,7 @@ static int scrub_checksum_data(struct scrub_block *sblock) { struct scrub_ctx *sctx = sblock->sctx; struct btrfs_fs_info *fs_info = sctx->fs_info; - SHASH_DESC_ON_STACK(shash, fs_info->csum_shash); + SHASH_DESC_ON_STACK(shash, fs_info->csum_shash[CSUM_DEFAULT]); u8 csum[BTRFS_CSUM_SIZE]; struct scrub_sector *sector; char *kaddr; @@ -1787,7 +1787,7 @@ static int scrub_checksum_data(struct scrub_block *sblock) kaddr = page_address(sector->page); - shash->tfm = fs_info->csum_shash; + shash->tfm = fs_info->csum_shash[CSUM_DEFAULT]; crypto_shash_init(shash); /* @@ -1806,7 +1806,7 @@ static int scrub_checksum_tree_block(struct scrub_block *sblock) struct scrub_ctx *sctx = sblock->sctx; struct btrfs_header *h; struct btrfs_fs_info *fs_info = sctx->fs_info; - SHASH_DESC_ON_STACK(shash, fs_info->csum_shash); + SHASH_DESC_ON_STACK(shash, fs_info->csum_shash[CSUM_DEFAULT]); u8 calculated_csum[BTRFS_CSUM_SIZE]; u8 on_disk_csum[BTRFS_CSUM_SIZE]; /* @@ -1850,7 +1850,7 @@ static int scrub_checksum_tree_block(struct scrub_block *sblock) BTRFS_UUID_SIZE)) sblock->header_error = 1; - shash->tfm = fs_info->csum_shash; + shash->tfm = fs_info->csum_shash[CSUM_DEFAULT]; crypto_shash_init(shash); crypto_shash_update(shash, kaddr + BTRFS_CSUM_SIZE, sectorsize - BTRFS_CSUM_SIZE); @@ -1872,7 +1872,7 @@ static int scrub_checksum_super(struct scrub_block *sblock) struct btrfs_super_block *s; struct scrub_ctx *sctx = sblock->sctx; struct btrfs_fs_info *fs_info = sctx->fs_info; - SHASH_DESC_ON_STACK(shash, fs_info->csum_shash); + SHASH_DESC_ON_STACK(shash, fs_info->csum_shash[CSUM_DEFAULT]); u8 calculated_csum[BTRFS_CSUM_SIZE]; struct scrub_sector *sector; char *kaddr; @@ -1893,7 +1893,7 @@ static int scrub_checksum_super(struct scrub_block *sblock) if (!scrub_check_fsid(s->fsid, sector)) ++fail_cor; - shash->tfm = fs_info->csum_shash; + shash->tfm = fs_info->csum_shash[CSUM_DEFAULT]; crypto_shash_init(shash); crypto_shash_digest(shash, kaddr + BTRFS_CSUM_SIZE, BTRFS_SUPER_INFO_SIZE - BTRFS_CSUM_SIZE, calculated_csum); diff --git a/fs/btrfs/sysfs.c b/fs/btrfs/sysfs.c index 32714ef8e22b..cc943b236c92 100644 --- a/fs/btrfs/sysfs.c +++ b/fs/btrfs/sysfs.c @@ -1097,7 +1097,7 @@ static ssize_t btrfs_checksum_show(struct kobject *kobj, return sysfs_emit(buf, "%s (%s)\n", btrfs_super_csum_name(csum_type), - crypto_shash_driver_name(fs_info->csum_shash)); + crypto_shash_driver_name(fs_info->csum_shash[CSUM_DEFAULT])); } BTRFS_ATTR(, checksum, btrfs_checksum_show);