| Message ID | 505FADA5.3070500@gmail.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Mon, Sep 24, 2012 at 08:47:33AM +0800, Wang Sheng-Hui wrote: > trivial code cleanup. > - ret =btrfs_drop_snapshot(root, NULL, 1, 0); > + ret = btrfs_drop_snapshot(root, NULL, 1, 0); Sorry but this is too trivial. Unless it really bugs you when you're going through code, I don't think that cleanups at this level are necessary. Reading through commit history of some code via 'git blame' and seeing such cleanups is not welcome. I have a patchet in testing that updates a few things around snapshot cleaning and this line will get fixed, so it'll not stay forever. david -- To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On 2012?09?24? 21:15, David Sterba wrote: > On Mon, Sep 24, 2012 at 08:47:33AM +0800, Wang Sheng-Hui wrote: >> trivial code cleanup. > >> - ret =btrfs_drop_snapshot(root, NULL, 1, 0); >> + ret = btrfs_drop_snapshot(root, NULL, 1, 0); > > Sorry but this is too trivial. > > Unless it really bugs you when you're going through code, I don't think > that cleanups at this level are necessary. Reading through commit > history of some code via 'git blame' and seeing such cleanups is not > welcome. > Got it. Thanks, > I have a patchet in testing that updates a few things around snapshot > cleaning and this line will get fixed, so it'll not stay forever. > > david -- To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/fs/btrfs/transaction.c b/fs/btrfs/transaction.c index 675d813..3279df2 100644 --- a/fs/btrfs/transaction.c +++ b/fs/btrfs/transaction.c @@ -1619,7 +1619,7 @@ int btrfs_clean_old_snapshots(struct btrfs_root *root) BTRFS_MIXED_BACKREF_REV) ret = btrfs_drop_snapshot(root, NULL, 0, 0); else - ret =btrfs_drop_snapshot(root, NULL, 1, 0); + ret = btrfs_drop_snapshot(root, NULL, 1, 0); BUG_ON(ret < 0); } return 0;
trivial code cleanup. Signed-off-by: Wang Sheng-Hui <shhuiw@gmail.com> --- fs/btrfs/transaction.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)