From patchwork Wed Jan 8 10:46:19 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Kusanagi Kouichi X-Patchwork-Id: 3453411 Return-Path: X-Original-To: patchwork-linux-btrfs@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork1.web.kernel.org (Postfix) with ESMTP id 6EF119F2E9 for ; Wed, 8 Jan 2014 11:08:21 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 69EA02010E for ; Wed, 8 Jan 2014 11:08:20 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 5E5CC20120 for ; Wed, 8 Jan 2014 11:08:19 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755866AbaAHLID (ORCPT ); Wed, 8 Jan 2014 06:08:03 -0500 Received: from mail-ae0-f53.auone-net.jp ([106.187.230.53]:33131 "EHLO dmta02.auone-net.jp" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1755605AbaAHLIB (ORCPT ); Wed, 8 Jan 2014 06:08:01 -0500 X-Greylist: delayed 721 seconds by postgrey-1.27 at vger.kernel.org; Wed, 08 Jan 2014 06:08:01 EST Received: from amlmta033.auone-net.jp (amlmta033-MM [10.188.22.39]) by dmta02.auone-net.jp (au one net mail) with ESMTP id 5F097400452; Wed, 8 Jan 2014 19:46:20 +0900 (JST) Received: from ppp.dion.ne.jp ([222.14.171.59]) by amlmta033.auone-net.jp id 52cd2c7c00011d8a00004f4e0000743e400004e23b8c; Wed, 08 Jan 2014 19:46:20 +0900 Date: Wed, 8 Jan 2014 19:46:19 +0900 From: Kusanagi Kouichi To: linux-btrfs@vger.kernel.org Cc: linux-kernel@vger.kernel.org Subject: [PATCH] btrfs: Return EXDEV for cross file system snapshot MIME-Version: 1.0 Content-Disposition: inline User-Agent: Mutt/1.5.21 (2010-09-15) Message-Id: <52cd2c7c00011d8a00004f4e0000743e400004e23b8c@amlmta033.auone-net.jp> X-MXM-DELIVERY-TYPE: 3 Sender: linux-btrfs-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-btrfs@vger.kernel.org X-Spam-Status: No, score=-7.0 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_HI, RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP EXDEV seems an appropriate error if an operation fails bacause it crosses file system boundaries. Signed-off-by: Kusanagi Kouichi Reviewed-by: David Sterba --- fs/btrfs/ioctl.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/btrfs/ioctl.c b/fs/btrfs/ioctl.c index 21da576..15d35cb 100644 --- a/fs/btrfs/ioctl.c +++ b/fs/btrfs/ioctl.c @@ -1544,7 +1544,7 @@ static noinline int btrfs_ioctl_snap_create_transid(struct file *file, if (src_inode->i_sb != file_inode(file)->i_sb) { printk(KERN_INFO "btrfs: Snapshot src from " "another FS\n"); - ret = -EINVAL; + ret = -EXDEV; } else { ret = btrfs_mksubvol(&file->f_path, name, namelen, BTRFS_I(src_inode)->root,