btrfs: avoid transaction commit on any fsync after subvolume creation

Commit Message

Filipe Manana June 11, 2024, 11:10 a.m. UTC

From: Filipe Manana <[e-mail]>

As of commit 1b53e51a4a8f ("btrfs: don't commit transaction for every
subvol create") we started to make any fsync after creating a subvolume
to fallback to a transaction commit if the fsync is performed in the
same transaction that was used to create the subvolume. This happens
with the following at ioctl.c:create_subvol():

  $ cat fs/btrfs/ioctl.c
  (...)
      /* Tree log can't currently deal with an inode which is a new root. */
      btrfs_set_log_full_commit(trans);
  (...)

Note that the comment is misleading as the problem is not that fsync can
not deal with the root inode of a new root, but that we can not log any
inode that belongs to a root that was not yet persisted because that would
make log replay fail since the root doesn't exist at log replay time.

The above simply makes any fsync fallback to a full transaction commit if
it happens in the same transaction used to create the subvolume - even if
it's an inode that belongs to any other subvolume. This is a brute force
solution and it doesn't necessarily improve performance for every workload
out there - it just moves a full transaction commit from one place, the
subvolume creation, to another - an fsync for any inode.

Just improve on this by making the fallback to a transacton commit only
for an fsync against an inode of the new subvolume, or for the directory
that contains the dentry that points to the new subvolume (in case anyone
attempts to fsync the directory in the same transaction).

Signed-off-by: Filipe Manana <[e-mail]>
---
 fs/btrfs/ioctl.c    |  4 ++--
 fs/btrfs/tree-log.c | 27 +++++++++++++++++++++++++++
 fs/btrfs/tree-log.h |  2 ++
 3 files changed, 31 insertions(+), 2 deletions(-)

Comments

Josef Bacik June 11, 2024, 4:48 p.m. UTC | #1

On Tue, Jun 11, 2024 at 12:10:24PM +0100, [e-mail] wrote:
> From: Filipe Manana <[e-mail]>
> 
> As of commit 1b53e51a4a8f ("btrfs: don't commit transaction for every
> subvol create") we started to make any fsync after creating a subvolume
> to fallback to a transaction commit if the fsync is performed in the
> same transaction that was used to create the subvolume. This happens
> with the following at ioctl.c:create_subvol():
> 
>   $ cat fs/btrfs/ioctl.c
>   (...)
>       /* Tree log can't currently deal with an inode which is a new root. */
>       btrfs_set_log_full_commit(trans);
>   (...)
> 
> Note that the comment is misleading as the problem is not that fsync can
> not deal with the root inode of a new root, but that we can not log any
> inode that belongs to a root that was not yet persisted because that would
> make log replay fail since the root doesn't exist at log replay time.
> 
> The above simply makes any fsync fallback to a full transaction commit if
> it happens in the same transaction used to create the subvolume - even if
> it's an inode that belongs to any other subvolume. This is a brute force
> solution and it doesn't necessarily improve performance for every workload
> out there - it just moves a full transaction commit from one place, the
> subvolume creation, to another - an fsync for any inode.
> 
> Just improve on this by making the fallback to a transacton commit only
> for an fsync against an inode of the new subvolume, or for the directory
> that contains the dentry that points to the new subvolume (in case anyone
> attempts to fsync the directory in the same transaction).
> 
> Signed-off-by: Filipe Manana <[e-mail]>

Reviewed-by: Josef Bacik <[e-mail]>

Thanks,

Josef

Patch

diff --git a/fs/btrfs/ioctl.c b/fs/btrfs/ioctl.c
index d00d49338ecb..1dca986943f0 100644
--- a/fs/btrfs/ioctl.c
+++ b/fs/btrfs/ioctl.c
@@ -662,8 +662,6 @@  static noinline int create_subvol(struct mnt_idmap *idmap,
 	qgroup_reserved = 0;
 	trans->block_rsv = &block_rsv;
 	trans->bytes_reserved = block_rsv.size;
-	/* Tree log can't currently deal with an inode which is a new root. */
-	btrfs_set_log_full_commit(trans);
 
 	ret = btrfs_qgroup_inherit(trans, 0, objectid, btrfs_root_id(root), inherit);
 	if (ret)
@@ -764,6 +762,8 @@  static noinline int create_subvol(struct mnt_idmap *idmap,
 		goto out;
 	}
 
+	btrfs_record_new_subvolume(trans, BTRFS_I(dir));
+
 	d_instantiate_new(dentry, new_inode_args.inode);
 	new_inode_args.inode = NULL;
 
diff --git a/fs/btrfs/tree-log.c b/fs/btrfs/tree-log.c
index d3142d55875a..cf384f32d5fe 100644
--- a/fs/btrfs/tree-log.c
+++ b/fs/btrfs/tree-log.c
@@ -7065,6 +7065,15 @@  static int btrfs_log_inode_parent(struct btrfs_trans_handle *trans,
 		goto end_no_trans;
 	}
 
+	/*
+	 * If we're logging an inode from a subvolume created in the current
+	 * transaction we must force a commit since the root is not persisted.
+	 */
+	if (btrfs_root_generation(&root->root_item) == trans->transid) {
+		ret = BTRFS_LOG_FORCE_COMMIT;
+		goto end_no_trans;
+	}
+
 	/*
 	 * Skip already logged inodes or inodes corresponding to tmpfiles
 	 * (since logging them is pointless, a link count of 0 means they
@@ -7445,6 +7454,24 @@  void btrfs_record_snapshot_destroy(struct btrfs_trans_handle *trans,
 	mutex_unlock(&dir->log_mutex);
 }
 
+/*
+ * Call this when creating a subvolume in a directory.
+ * Because we don't commit a transaction when creating a subvolume, we can't
+ * allow the directory pointing to the subvolume to be logged with an entry that
+ * points to an unpersisted root if we are still in the transaction used to
+ * create the subvolume, so make any attempt to log the directory to result in a
+ * full log sync.
+ * Also we don't need to worry with renames, since btrfs_rename() marks the log
+ * for full commit when renaming a subvolume.
+ */
+void btrfs_record_new_subvolume(struct btrfs_trans_handle *trans,
+				struct btrfs_inode *dir)
+{
+	mutex_lock(&dir->log_mutex);
+	dir->last_unlink_trans = trans->transid;
+	mutex_unlock(&dir->log_mutex);
+}
+
 /*
  * Update the log after adding a new name for an inode.
  *
diff --git a/fs/btrfs/tree-log.h b/fs/btrfs/tree-log.h
index fa0a689259b1..ec99975a0fff 100644
--- a/fs/btrfs/tree-log.h
+++ b/fs/btrfs/tree-log.h
@@ -94,6 +94,8 @@  void btrfs_record_unlink_dir(struct btrfs_trans_handle *trans,
 			     bool for_rename);
 void btrfs_record_snapshot_destroy(struct btrfs_trans_handle *trans,
 				   struct btrfs_inode *dir);
+void btrfs_record_new_subvolume(struct btrfs_trans_handle *trans,
+				struct btrfs_inode *dir);
 void btrfs_log_new_name(struct btrfs_trans_handle *trans,
 			struct dentry *old_dentry, struct btrfs_inode *old_dir,
 			u64 old_dir_index, struct dentry *parent);