From patchwork Sun May 7 16:51:50 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?b?5oi05ZGo?= X-Patchwork-Id: 9715613 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 3414860365 for ; Sun, 7 May 2017 22:56:10 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 2FC2C223C7 for ; Sun, 7 May 2017 22:56:10 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 2471326224; Sun, 7 May 2017 22:56:10 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.7 required=2.0 tests=BAYES_00, DATE_IN_PAST_06_12, DKIM_ADSP_CUSTOM_MED,DKIM_SIGNED,FREEMAIL_FROM,RCVD_IN_DNSWL_HI, RCVD_IN_SORBS_SPAM,T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 86A1A223C7 for ; Sun, 7 May 2017 22:56:09 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753042AbdEGW4B (ORCPT ); Sun, 7 May 2017 18:56:01 -0400 Received: from mail-wm0-f65.google.com ([74.125.82.65]:36572 "EHLO mail-wm0-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750991AbdEGW4A (ORCPT ); Sun, 7 May 2017 18:56:00 -0400 Received: by mail-wm0-f65.google.com with SMTP id u65so11819206wmu.3 for ; Sun, 07 May 2017 15:56:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :content-transfer-encoding; bh=kaeWiCS+/FwtZZiOAXwHzPjAchmxNim+do7eFBgnH48=; b=UG5QJfxvklj8wN0Q8daEHQAZkpC7scKuQ0HmX9+4FDVna3Q+4sL+I9hvMfjLunNcKE 0SkgN9yNGp+y1p34S4nmeyn27epk7j0bsavlVNumegrLMZwrbla/u3zyMhzbErEtLXr2 HXyxx5E0OKvuc6Ryohy5bX7MV1tyj5QGVYI6A8C7irrHOhTPhSnueg+MXLyfQUAozX0A R6SHtRCC+foxa97/14JcjggcW8cepacHUeWYyE8QvD82DvEf6ZI0TeerMifPodtmkWV5 e4slYBct3LaO8FkYHQuwuCt7xLCnXyzHtZTCrC8aMrDJc97iZ/X5u8x0E12XKiJxEJQB eO0A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:content-transfer-encoding; bh=kaeWiCS+/FwtZZiOAXwHzPjAchmxNim+do7eFBgnH48=; b=AHo19663RHZlPiaYQXbm72AbKF2XL9OWSPBWU2QzSBYpCFHOSKCiA8RhGRovvTHYNp BWn7bEpIB8BTfy+cYcZmTbDXMA2havcCFOIMkhy6Hyyd18k8jWFTvMr1PIyWZJp7+dfW Cp4PbY6Xy3ipVA//tAHSoRmAP8FhAHH8mJ1TMTCrc81kZP0IUqvXoohKJTbXqBAWPGkH xGcNzkspi5As1Fe2hmklV2jbE10fnwF6RkCGicgukmwynuf72vDIxzfpgra1VY1lchIP WL/K4gTlPaVeYotjA3bdCz90Kz5paG7j0WSYdTV57RjEUULuSUkYaju0qk8BKt5rNhPS Lxwg== X-Gm-Message-State: AN3rC/5m6m7iyoKfSdjMLf6Qa73rMY6xVYGf2MyrPEeLYnLn8dJRIg+m ZvaXef4qA9l420aDq0+2AOygZ+brMuJa X-Received: by 10.25.74.215 with SMTP id x206mr22743592lfa.67.1494175911476; Sun, 07 May 2017 09:51:51 -0700 (PDT) MIME-Version: 1.0 Received: by 10.25.203.76 with HTTP; Sun, 7 May 2017 09:51:50 -0700 (PDT) In-Reply-To: References: From: =?UTF-8?B?5oi05ZGo?= Date: Mon, 8 May 2017 00:51:50 +0800 Message-ID: Subject: Fwd: [PATCH] Btrfs:Unused comments:"FIXME: check if the IDs really exist" in ioctl.c To: lbtrfs Sender: linux-btrfs-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-btrfs@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP From: 戴周 Date: Mon, May 8, 2017 at 12:38 AM Subject: [PATCH] Btrfs:Unused comments:"FIXME: check if the IDs really exist" in ioctl.c To: Chris Mason , Josef Bacik , David Sterba From 0adb51c1fd6afde399e8f9307bff831b508892d1 Mon Sep 17 00:00:00 2001 From: Daichou Date: Mon, 8 May 2017 00:03:25 +0800 Subject: [PATCH] Btrfs:Unused comments:"FIXME: check if the IDs really exist" in ioctl.c These comments were already fixed in 2013. btrfs_add_qgroup_relation, btrfs_ioctl_qgroup_create, btrfs_limit_qgroup btrfs_add_qgroup_relation, btrfs_del_qgroup_relation have checked qgroupid existed. Signed-off-by: Daichou --- fs/btrfs/ioctl.c | 3 --- 1 file changed, 3 deletions(-) sa->src, sa->dst); @@ -4959,7 +4958,6 @@ static long btrfs_ioctl_qgroup_create(struct file *file, void __user *arg) goto out; } - /* FIXME: check if the IDs really exist */ if (sa->create) { ret = btrfs_create_qgroup(trans, fs_info, sa->qgroupid); } else { @@ -5013,7 +5011,6 @@ static long btrfs_ioctl_qgroup_limit(struct file *file, void __user *arg) qgroupid = root->root_key.objectid; } - /* FIXME: check if the IDs really exist */ ret = btrfs_limit_qgroup(trans, fs_info, qgroupid, &sa->lim); err = btrfs_end_transaction(trans); -- 2.12.2 -- To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/fs/btrfs/ioctl.c b/fs/btrfs/ioctl.c index a29dc3fd7152..6db06f4708f7 100644 --- a/fs/btrfs/ioctl.c +++ b/fs/btrfs/ioctl.c @@ -4900,7 +4900,6 @@ static long btrfs_ioctl_qgroup_assign(struct file *file, void __user *arg) goto out; } - /* FIXME: check if the IDs really exist */ if (sa->assign) { ret = btrfs_add_qgroup_relation(trans, fs_info,