From patchwork Sun May 7 17:07:42 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: =?utf-8?b?5oi05ZGo?= X-Patchwork-Id: 9715569 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id BC25160365 for ; Sun, 7 May 2017 22:20:47 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id AFDDF22B26 for ; Sun, 7 May 2017 22:20:47 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id A4A7F24151; Sun, 7 May 2017 22:20:47 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.7 required=2.0 tests=BAYES_00, DATE_IN_PAST_03_06, DKIM_ADSP_CUSTOM_MED,DKIM_SIGNED,FREEMAIL_FROM,RCVD_IN_DNSWL_HI, RCVD_IN_SORBS_SPAM,T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 535E822B26 for ; Sun, 7 May 2017 22:20:47 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756331AbdEGWUo (ORCPT ); Sun, 7 May 2017 18:20:44 -0400 Received: from mail-wr0-f194.google.com ([209.85.128.194]:36822 "EHLO mail-wr0-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753111AbdEGWUo (ORCPT ); Sun, 7 May 2017 18:20:44 -0400 Received: by mail-wr0-f194.google.com with SMTP id v42so6123230wrc.3 for ; Sun, 07 May 2017 15:20:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:from:date:message-id:subject:to; bh=9cn1wL0pjvJd4ooCj4kJEZ+qBuuavjn3m0MLokfO7ZI=; b=kTh2R58SMBa2D+YOVnXJw6Z4vSxKKKfD5ylVYYcAljWPS1Y+Dn1VRLjxYrhREytTk3 bTLFMCFo8tBDeIbEbidQqzxTQEsAoZ74KzUb08UuIkxqbFQ/VKL9kZXINab/dtKlSgn8 nPcr63mcIrCWZjlca/twPC1bmECBlAmJ+3A5SGS5Jx0f9nuf5juiEIfLEJdIxs1jmFK8 U/ILYQl1DfecgU2AFvMmSKRSZ/JDJikfSOK+ZGWgsw27T18gzPYC5Zjp4Ba18TGFiTX8 GuZDrWDO2XwAATLqfmbG3AlSHaSWPB527PnipBWXRor9wCkKm1ouYZMK823/mcX/vFXr cRYA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:from:date:message-id:subject:to; bh=9cn1wL0pjvJd4ooCj4kJEZ+qBuuavjn3m0MLokfO7ZI=; b=hpFKVteWwCPmZ9seoOnJAQVNk8rw6x4Y60aAdNygZ128BKW1z+TqI3E9kBaAD4xRge 19c7PD4nkIdHNQB61sZIBgWtXuYhUtzU7UnKOwGVfiyG58MSUrfpF0Mp1Eh2e/3FSU0w DVgmiQAKSjXt8ntvO3c/WWxiRgS6JNeRt6Ty/nawOLW/2gWLADqtnjRBjiC56LrkV5O4 dtvSimsmHLY/M1l9a77JKYCFw99rXdNNu2Rns5xWnbBoZ5xKKudImY4SApvdClsJ5WeV 9h70fc0Fh0wVYwFMWVeNCII27yjyQUnHY4M6xywiVgmtLVl3hx+9dtQgiRMwI47stc7/ e+kQ== X-Gm-Message-State: AODbwcApwpkHA558GiWhRYjXCrix+TcZZ1A6rvgMCdNSgsnuNSNuqm7n 8pCrBzPU+fJw9iPVsXitKLssL77Q8+YDFH4= X-Received: by 10.46.15.18 with SMTP id 18mr4274938ljp.64.1494176863477; Sun, 07 May 2017 10:07:43 -0700 (PDT) MIME-Version: 1.0 Received: by 10.25.203.76 with HTTP; Sun, 7 May 2017 10:07:42 -0700 (PDT) From: =?UTF-8?B?5oi05ZGo?= Date: Mon, 8 May 2017 01:07:42 +0800 Message-ID: Subject: [PATCH] Btrfs:Unused comments:"FIXME: check if the IDs really exist" in ioctl.c To: lbtrfs Sender: linux-btrfs-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-btrfs@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP [PATCH] Btrfs:Unused comments:"FIXME: check if the IDs really exist" in ioctl.c These comments were already fixed in 2013. btrfs_add_qgroup_relation, btrfs_ioctl_qgroup_create, btrfs_limit_qgroup btrfs_add_qgroup_relation, btrfs_del_qgroup_relation have checked qgroupid existed. Signed-off-by: Daichou --- fs/btrfs/ioctl.c | 3 --- 1 file changed, 3 deletions(-) sa->src, sa->dst); @@ -4959,7 +4958,6 @@ static long btrfs_ioctl_qgroup_create(struct file *file, void __user *arg) goto out; } - /* FIXME: check if the IDs really exist */ if (sa->create) { ret = btrfs_create_qgroup(trans, fs_info, sa->qgroupid); } else { @@ -5013,7 +5011,6 @@ static long btrfs_ioctl_qgroup_limit(struct file *file, void __user *arg) qgroupid = root->root_key.objectid; } - /* FIXME: check if the IDs really exist */ ret = btrfs_limit_qgroup(trans, fs_info, qgroupid, &sa->lim); err = btrfs_end_transaction(trans); -- To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/fs/btrfs/ioctl.c b/fs/btrfs/ioctl.c index a29dc3fd7152..6db06f4708f7 100644 --- a/fs/btrfs/ioctl.c +++ b/fs/btrfs/ioctl.c @@ -4900,7 +4900,6 @@ static long btrfs_ioctl_qgroup_assign(struct file *file, void __user *arg) goto out; } - /* FIXME: check if the IDs really exist */ if (sa->assign) { ret = btrfs_add_qgroup_relation(trans, fs_info,