[15/21] btrfs: return -EUCLEAN if extent item is missing when searching inline backref

Commit Message

Filipe Manana Sept. 8, 2023, 12:09 p.m. UTC

From: Filipe Manana <[e-mail]>

At lookup_inline_extent_backref() when trying to insert an inline backref,
if we don't find the extent item we log an error and then return -EIO.
This error code is confusing because there was actually no IO error, and
this means we have some corruption, either caused by a bug or something
like a memory bitflip for example. So change the error code from -EIO to
-EUCLEAN.

Signed-off-by: Filipe Manana <[e-mail]>
---
 fs/btrfs/extent-tree.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Josef Bacik Sept. 8, 2023, 3:10 p.m. UTC | #1

On Fri, Sep 08, 2023 at 01:09:17PM +0100, [e-mail] wrote:
> From: Filipe Manana <[e-mail]>
> 
> At lookup_inline_extent_backref() when trying to insert an inline backref,
> if we don't find the extent item we log an error and then return -EIO.
> This error code is confusing because there was actually no IO error, and
> this means we have some corruption, either caused by a bug or something
> like a memory bitflip for example. So change the error code from -EIO to
> -EUCLEAN.
> 
> Signed-off-by: Filipe Manana <[e-mail]>

Reviewed-by: Josef Bacik <[e-mail]>

Thanks,

Josef

Patch

diff --git a/fs/btrfs/extent-tree.c b/fs/btrfs/extent-tree.c
index e57061106860..756589195ed7 100644
--- a/fs/btrfs/extent-tree.c
+++ b/fs/btrfs/extent-tree.c
@@ -851,7 +851,7 @@  int lookup_inline_extent_backref(struct btrfs_trans_handle *trans,
 "extent item not found for insert, bytenr %llu num_bytes %llu parent %llu root_objectid %llu owner %llu offset %llu",
 			  bytenr, num_bytes, parent, root_objectid, owner,
 			  offset);
-		ret = -EIO;
+		ret = -EUCLEAN;
 		goto out;
 	}