From patchwork Fri May 17 16:52:38 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Filipe Manana X-Patchwork-Id: 13667182 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 40D3813D8B6 for ; Fri, 17 May 2024 16:52:43 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1715964763; cv=none; b=UCOdmVLj4CuGTLxqH2pHVoceeT/cqJE57PIFUOrWSF+8aBUKpDm+w0Ru4XqKO7C9JXhofJwa5J8wfyj7mMdhnT82UAcrYmxWJBXjBY3xrnKyoIprkWhNaRNd0ZRsPUIfayLizMgnnTKFY0RdI3ks0el38AG+gmMpnNR7Talnk0g= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1715964763; c=relaxed/simple; bh=giaF07HsS/o92Sx8QlESt03wiFeVuvpcaqG+P8qleA0=; h=From:To:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=JH8/6JYamzmarIUY7gzPbHg8pc6U9NnimRpdhV8vORfakaXlnK1XZ9/Wc17IPDDFWL8b6aAspvtwZEGdH4I2C6WRPhM6xDhDJFEMZ/BKfYbLHzxsnjog+3JSntEo1b7diDtVgdolB5DRAFSLSZCwAWRd37bDTT5Gg/RxIZHQRGE= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=uGgQiiLI; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="uGgQiiLI" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 90361C32781 for ; Fri, 17 May 2024 16:52:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1715964763; bh=giaF07HsS/o92Sx8QlESt03wiFeVuvpcaqG+P8qleA0=; h=From:To:Subject:Date:In-Reply-To:References:From; b=uGgQiiLIV3KWqLtdaH1g1GuDcEokLU1l25DvaMiIucsyJHbCLqAX25GxobxIKagTk FQHYV3J2bSSanFtBGduC43wsBn1jjMYjx6GoPGxJYIiH68cawCEVt/tlRIAFJdkhxZ ispbjJrRIOCjLvdoZiQFS1vzIgVS52r0exCSGGTWlBDERm5utBPco3J+eznBY1frz1 y95oXbsFzlKt3GFbK/o2+AuDEYmqWQaYjOFE0cDhKovO6tHYmpfalAF/0SbaHDHkJn TV9o8a5si4pSL3mAZKwynaL9n7+LVtU/XaMrUtpwOgf49H8hNspvlYFGhyoMWUbhv9 kI4nwXujuPldg== From: fdmanana@kernel.org To: linux-btrfs@vger.kernel.org Subject: [PATCH v3 2/2] btrfs: make btrfs_finish_ordered_extent() return void Date: Fri, 17 May 2024 17:52:38 +0100 Message-Id: X-Mailer: git-send-email 2.34.1 In-Reply-To: References: Precedence: bulk X-Mailing-List: linux-btrfs@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 From: Filipe Manana Currently btrfs_finish_ordered_extent() returns a boolean indicating if the ordered extent was added to the work queue for completion, but none of its callers cares about it, so make it return void. Reviewed-by: Qu Wenruo Signed-off-by: Filipe Manana Signed-off-by: David Sterba --- fs/btrfs/ordered-data.c | 3 +-- fs/btrfs/ordered-data.h | 2 +- 2 files changed, 2 insertions(+), 3 deletions(-) diff --git a/fs/btrfs/ordered-data.c b/fs/btrfs/ordered-data.c index 55a9aeed7344..adc274605776 100644 --- a/fs/btrfs/ordered-data.c +++ b/fs/btrfs/ordered-data.c @@ -374,7 +374,7 @@ static void btrfs_queue_ordered_fn(struct btrfs_ordered_extent *ordered) btrfs_queue_work(wq, &ordered->work); } -bool btrfs_finish_ordered_extent(struct btrfs_ordered_extent *ordered, +void btrfs_finish_ordered_extent(struct btrfs_ordered_extent *ordered, struct page *page, u64 file_offset, u64 len, bool uptodate) { @@ -421,7 +421,6 @@ bool btrfs_finish_ordered_extent(struct btrfs_ordered_extent *ordered, if (ret) btrfs_queue_ordered_fn(ordered); - return ret; } /* diff --git a/fs/btrfs/ordered-data.h b/fs/btrfs/ordered-data.h index b6f6c6b91732..bef22179e7c5 100644 --- a/fs/btrfs/ordered-data.h +++ b/fs/btrfs/ordered-data.h @@ -162,7 +162,7 @@ int btrfs_finish_ordered_io(struct btrfs_ordered_extent *ordered_extent); void btrfs_put_ordered_extent(struct btrfs_ordered_extent *entry); void btrfs_remove_ordered_extent(struct btrfs_inode *btrfs_inode, struct btrfs_ordered_extent *entry); -bool btrfs_finish_ordered_extent(struct btrfs_ordered_extent *ordered, +void btrfs_finish_ordered_extent(struct btrfs_ordered_extent *ordered, struct page *page, u64 file_offset, u64 len, bool uptodate); void btrfs_mark_ordered_io_finished(struct btrfs_inode *inode,