From patchwork Wed Jun 7 06:57:10 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Omar Sandoval X-Patchwork-Id: 9770641 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 5837660234 for ; Wed, 7 Jun 2017 06:57:25 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 42F2428472 for ; Wed, 7 Jun 2017 06:57:25 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 32901284ED; Wed, 7 Jun 2017 06:57:25 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=2.0 tests=BAYES_00,DKIM_SIGNED, RCVD_IN_DNSWL_HI,T_DKIM_INVALID autolearn=unavailable version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id CAF8328472 for ; Wed, 7 Jun 2017 06:57:24 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751448AbdFGG5V (ORCPT ); Wed, 7 Jun 2017 02:57:21 -0400 Received: from mail-pf0-f170.google.com ([209.85.192.170]:36458 "EHLO mail-pf0-f170.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750730AbdFGG5U (ORCPT ); Wed, 7 Jun 2017 02:57:20 -0400 Received: by mail-pf0-f170.google.com with SMTP id x63so2305952pff.3 for ; Tue, 06 Jun 2017 23:57:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=osandov-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id; bh=JLUqNREHmzF+GmrVVdhb6ekM1TipIZqy4PfE6DO3i2k=; b=w9eMt309IhmLLiEDIkAZ5aIke9dPdup4nJxqthRPG5kT1FTZRjfg6N/m9kV97V3g9U DvRN7arN6rHLiunm0pN5L06FlaqKC0n2MUXo6I8uvo9l1zZAIqpIx+WCcMSuaWnwiRvp MjV/bdWotPyRhGPtCTfUB5+a6scy/uRs1tHHwyIsTE+SgkrEhCesEcrHjkcs995rFldj JY8gv0S7QK1kH2Y6qW4d+Kybgtvmcz1I42evQjot3kbgj6QHKGlrZI0nwPdtvI0aRBlZ jMv9TNVVey3wNKS2euDz0RS2ORFGh9mb4Yhf2bgQS9c0Vj3Te9PW3j+iPT24Ksjholab LI4A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=JLUqNREHmzF+GmrVVdhb6ekM1TipIZqy4PfE6DO3i2k=; b=KvvE+QZBekx2lnHAr7TdGk6Dshl1sDkwllgxDDWv5RryGXFdfGoI6SBHELHEKDWkf6 FSAhaEJ8WSpKZQe5RfMC0h4x9LSkyyfLwEJBYwfFU9zUuLbRDpYcjALi1bKDEMA8Ro81 kjPrYUIq1PGtsznY7PfBiLnDdlFjfMRoU0RSWv2X9CXkafNQzQfOsYMjgHIu+7++6z4R H1fqM1W7lWYjdJA75GNQVOpE3/XTJXfMy8c7IoqSc3p9Dqm0hxS8hFdp9UDkDEWmDQQ0 REHO0bKPnJHvT1NpMIuQ3FtIYprlxFVZLNjY4zbZ2F8W8sByYCC6F8IPrZEmim+ef7Cx DzBg== X-Gm-Message-State: AODbwcDZecDuiw4LiIcbcmH8ZtI7WdZI81ZgWkIqX1cCGQw/D++J4Ure KbE5ov8FD4inxFLR X-Received: by 10.99.4.87 with SMTP id 84mr31333737pge.138.1496818639688; Tue, 06 Jun 2017 23:57:19 -0700 (PDT) Received: from localhost.localdomain ([2601:602:8801:8110:e6a7:a0ff:fe0b:c9a8]) by smtp.gmail.com with ESMTPSA id h28sm1642644pfd.55.2017.06.06.23.57.18 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 06 Jun 2017 23:57:19 -0700 (PDT) From: Omar Sandoval To: fstests@vger.kernel.org, linux-btrfs@vger.kernel.org Cc: kernel-team@fb.com Subject: [PATCH] btrfs: test Btrfs delalloc accounting overflow Date: Tue, 6 Jun 2017 23:57:10 -0700 Message-Id: X-Mailer: git-send-email 2.13.0 Sender: linux-btrfs-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-btrfs@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP From: Omar Sandoval This is a regression test for "[PATCH] Btrfs: fix delalloc accounting leak caused by u32 overflow". It creates a bunch of delalloc extents and merges them together to make sure the accounting is done right. Signed-off-by: Omar Sandoval --- tests/btrfs/010 | 75 +++++++++++++++++++++++++++++++++++++++++++++++++++++ tests/btrfs/010.out | 2 ++ tests/btrfs/group | 1 + 3 files changed, 78 insertions(+) create mode 100755 tests/btrfs/010 create mode 100644 tests/btrfs/010.out diff --git a/tests/btrfs/010 b/tests/btrfs/010 new file mode 100755 index 00000000..a5d10880 --- /dev/null +++ b/tests/btrfs/010 @@ -0,0 +1,75 @@ +#! /bin/bash +# FS QA Test 10 +# +# Test delayed allocation with a large number of extents that are merged. +# Regression test for patch "Btrfs: fix delalloc accounting leak caused by u32 +# overflow". +# +#----------------------------------------------------------------------- +# Copyright (c) 2017 Facebook. All Rights Reserved. +# +# This program is free software; you can redistribute it and/or +# modify it under the terms of the GNU General Public License as +# published by the Free Software Foundation. +# +# This program is distributed in the hope that it would be useful, +# but WITHOUT ANY WARRANTY; without even the implied warranty of +# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the +# GNU General Public License for more details. +# +# You should have received a copy of the GNU General Public License +# along with this program; if not, write the Free Software Foundation, +# Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA +#----------------------------------------------------------------------- +# + +seq=`basename $0` +seqres=$RESULT_DIR/$seq +echo "QA output created by $seq" + +here=`pwd` +tmp=/tmp/$$ +status=1 # failure is the default! +trap "_cleanup; exit \$status" 0 1 2 3 15 + +test_file="$TEST_DIR/$seq" + +_cleanup() +{ + cd / + rm -f $tmp.* "$test_file" +} + +. ./common/rc +. ./common/filter + +rm -f $seqres.full + +_supported_fs btrfs +_supported_os Linux +_require_test + +# Create 32k extents. All of these extents will be accounted as outstanding and +# reserved. +for ((i = 0; i < 32 * 1024; i++)); do + xfs_io -f -c "pwrite $((2 * 4096 * i)) 4096" "$test_file" >>"$seqres.full" +done + +# Fill in the gaps between the created extents. The outstanding extents will +# all be merged into 1, but there will still be 32k reserved. +for ((i = 0; i < 32 * 1024; i++)); do + xfs_io -f -c "pwrite $((2 * 4096 * i + 1)) 4096" "$test_file" >>"$seqres.full" +done + +# Flush the delayed allocations. +sync + +# Make sure that we didn't leak any metadata space. +uuid="$(findmnt -n -o UUID "$TEST_DIR")" +cd "/sys/fs/btrfs/$uuid/allocation" +echo "$(($(cat metadata/bytes_may_use) - $(cat global_rsv_reserved))) bytes leaked" | grep -v '^0 ' + +echo "Silence is golden" + +status=0 +exit diff --git a/tests/btrfs/010.out b/tests/btrfs/010.out new file mode 100644 index 00000000..1d83a8d6 --- /dev/null +++ b/tests/btrfs/010.out @@ -0,0 +1,2 @@ +QA output created by 010 +Silence is golden diff --git a/tests/btrfs/group b/tests/btrfs/group index 6f19619e..1fa6c781 100644 --- a/tests/btrfs/group +++ b/tests/btrfs/group @@ -12,6 +12,7 @@ 007 auto quick rw metadata send 008 auto quick send 009 auto quick subvol +010 auto 011 auto replace 012 auto convert 013 auto quick balance