From patchwork Fri Aug 19 17:28:37 2011 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bernd Schubert X-Patchwork-Id: 1081582 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by demeter2.kernel.org (8.14.4/8.14.4) with ESMTP id p7JHSsNV022367 for ; Fri, 19 Aug 2011 17:28:55 GMT Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756599Ab1HSR2v (ORCPT ); Fri, 19 Aug 2011 13:28:51 -0400 Received: from lo.gmane.org ([80.91.229.12]:40383 "EHLO lo.gmane.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756597Ab1HSR2v (ORCPT ); Fri, 19 Aug 2011 13:28:51 -0400 Received: from list by lo.gmane.org with local (Exim 4.69) (envelope-from ) id 1QuSsE-00051C-BI for linux-btrfs@vger.kernel.org; Fri, 19 Aug 2011 19:28:50 +0200 Received: from tc-gate2.pci.uni-heidelberg.de ([129.206.21.242]) by main.gmane.org with esmtp (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Fri, 19 Aug 2011 19:28:50 +0200 Received: from bernd.schubert by tc-gate2.pci.uni-heidelberg.de with local (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Fri, 19 Aug 2011 19:28:50 +0200 X-Injected-Via-Gmane: http://gmane.org/ To: linux-btrfs@vger.kernel.org From: Bernd Schubert Subject: Re: bonnie triggers and endless numbers of stack traces Date: Fri, 19 Aug 2011 19:28:37 +0200 Lines: 31 Message-ID: References: Mime-Version: 1.0 X-Complaints-To: usenet@dough.gmane.org X-Gmane-NNTP-Posting-Host: tc-gate2.pci.uni-heidelberg.de User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.2.18) Gecko/20110626 Iceowl/1.0b2 Icedove/3.1.11 In-Reply-To: Sender: linux-btrfs-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-btrfs@vger.kernel.org X-Greylist: IP, sender and recipient auto-whitelisted, not delayed by milter-greylist-4.2.6 (demeter2.kernel.org [140.211.167.43]); Fri, 19 Aug 2011 17:28:55 +0000 (UTC) I think we either should remove it or replace by WARN_ON_ONCE() Remove WARN_ON(1) in a common code path From: Bernd Schubert Something like bonnie++ -d /mnt/btrfs -s0 -n 1:256:256:1 -r 0 will trigger lots of those WARN_ON(1), so lets remove it. Signed-off-by: Bernd Schubert --- fs/btrfs/extent-tree.c | 1 - 1 files changed, 0 insertions(+), 1 deletions(-) -- To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/fs/btrfs/extent-tree.c b/fs/btrfs/extent-tree.c index 80d6148..1d1a8d0 100644 --- a/fs/btrfs/extent-tree.c +++ b/fs/btrfs/extent-tree.c @@ -5708,7 +5708,6 @@ use_block_rsv(struct btrfs_trans_handle *trans, if (!ret) return block_rsv; if (ret) { - WARN_ON(1); ret = reserve_metadata_bytes(trans, root, block_rsv, blocksize, 0); if (!ret) {