From patchwork Sat Dec 7 20:36:01 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bjorn Andersson X-Patchwork-Id: 11277769 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id A4A32139A for ; Sat, 7 Dec 2019 20:36:32 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 8358E24687 for ; Sat, 7 Dec 2019 20:36:32 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="vINxdpIC" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726626AbfLGUgb (ORCPT ); Sat, 7 Dec 2019 15:36:31 -0500 Received: from mail-pf1-f193.google.com ([209.85.210.193]:33273 "EHLO mail-pf1-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726811AbfLGUgb (ORCPT ); Sat, 7 Dec 2019 15:36:31 -0500 Received: by mail-pf1-f193.google.com with SMTP id y206so5162576pfb.0 for ; Sat, 07 Dec 2019 12:36:30 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=4pU0TgCEVu3iILUXjS64n8D0+VYiF/iGQ/CEZMcyyRk=; b=vINxdpICYteO6gJRGK9ywPvLKgr/9A0DCY7QWTX859IXm3YJ+TN4esbzO3tuv7YCS9 G6Rsl8hL06+MiFFFYuMe+02yjgJJWIdp541Jpkr2rSg8/0JnbyYH48EKE9l+Ogft/jWJ cnPo/mk+bg82Q32iz5cCwIN2CVkvg1fOVfxakwgLFFsQUQqeWSRbZVoXFpm3HR5FKeaG ulLl0iMW1hZrzIzdb27BUqmGh4OJ5ZRVObBBqQ9rTq+MYnC4ycnoJGApHS0ApBk+qfdr dqJjjvS+TV0Q2nsQ0PyXiU0WFQUAGc9gWT2blEQsXucKCGZtpBLcRyjkY/igtSZ22CbX LJaQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=4pU0TgCEVu3iILUXjS64n8D0+VYiF/iGQ/CEZMcyyRk=; b=POYVwIDlhXC9ybWqnDU7PYOirB8YR4tuHuvKpyl7xZPJf0MNwdCp71wt3BbfOFQXDw 4cBGWoBikDWqrqo8ljDuPXAtJ0+vhB6D/xLGP74OgKlDiPbhftmxZdbx+EW7f+HONuHW iJFg8t2ESYq8HjYdIZOJup18szmF7dW3x6eVmxrM83+Rc7/ekCdG5JU/NCSSDYf9Vk7k TheS5gOJ6R754SepaXwEfHUwhZ1Hb7Szd8UCuaHOmvY57hVli8W1qttWPq+0JFKkBMHu H2sKxrL2FJr2QwX2Z9LNiZm8+XLg+eJA9q9+ksrt8lkGQtgGiufURQcC+4SDXIYNdxJ4 ArBg== X-Gm-Message-State: APjAAAULRs+omZoluAnc2xr2SchMPXXKnSPIekCgRR/uvSchg6FJwjHg fvk0qK8lTANWN+Hteu4Gbt60lQ== X-Google-Smtp-Source: APXvYqw901GjcbHTK90oZG2kYPsObEYLR/h3mKtSJ01x0JdZ6I2G5a44GfZhkTBXFwXydT3dY6rdWw== X-Received: by 2002:a62:6086:: with SMTP id u128mr21734365pfb.4.1575750990366; Sat, 07 Dec 2019 12:36:30 -0800 (PST) Received: from localhost.localdomain (104-188-17-28.lightspeed.sndgca.sbcglobal.net. [104.188.17.28]) by smtp.gmail.com with ESMTPSA id d14sm22982186pfq.117.2019.12.07.12.36.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 07 Dec 2019 12:36:29 -0800 (PST) From: Bjorn Andersson To: Michael Turquette , Stephen Boyd Cc: Andy Gross , Rob Herring , Mark Rutland , linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Paolo Pisati Subject: [PATCH 0/2] clk: qcom: gcc-msm8996: Fix CLKREF parenting Date: Sat, 7 Dec 2019 12:36:01 -0800 Message-Id: <20191207203603.2314424-1-bjorn.andersson@linaro.org> X-Mailer: git-send-email 2.24.0 MIME-Version: 1.0 Sender: linux-clk-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-clk@vger.kernel.org We've always seen intermittent resets of msm8996 during boot, seemingly related to PCIe somehow. The likely cause of these errors are the fact that the CLKREF of all PHYs are parented by LN_BB, which while being on during boot is disabled by the UFS host driver if it fails to find its PHY. As such, depending on the timeing (and success) of the UFS initialization PCIe might loose its clocking. These two patches ensures that LN_BB, connected to the CXO2 pad on the SoC, is described as parent for all the CLKREF clocks. So that they all vote for this clock appropriately. Bjorn Andersson (2): clk: qcom: gcc-msm8996: Fix parent for CLKREF clocks arm64: dts: qcom: msm8996: Define parent clocks for gcc .../devicetree/bindings/clock/qcom,gcc.yaml | 6 ++-- arch/arm64/boot/dts/qcom/msm8996.dtsi | 3 ++ drivers/clk/qcom/gcc-msm8996.c | 35 +++++++++++++++---- 3 files changed, 35 insertions(+), 9 deletions(-)