mbox series

[0/5,v2] U8500 clkout clocks v2

Message ID 20220319225156.1451636-1-linus.walleij@linaro.org (mailing list archive)
Headers show
Series U8500 clkout clocks v2 | expand

Message

Linus Walleij March 19, 2022, 10:51 p.m. UTC 
This second iteration adds patches that:

- Drops custom .is_enabled and .is_prepared implementations
  for the U8500 PRCMU clocks.
- Rewrite the PRCMU clocks to use clk_hw
- Then adds the new clkout clocks in the same style

Modernizing the PRCMU clock was necessary so the new clock
would not look off.

We can go on and fix the rest of the ux500 clocks to use
clk_hw style registration on top of this series if there
is desire.

Linus Walleij (5):
  dt-bindings: clock: u8500: Add clkout clock bindings
  clk: ux500: Drop .is_enabled state from PRCMU clocks
  clk: ux500: Drop .is_prepared state from PRCMU clocks
  clk: ux500: Rewrite PRCMU clocks to use clk_hw_*
  clk: ux500: Implement the missing CLKOUT clocks

 .../bindings/clock/stericsson,u8500-clks.yaml |  57 +++
 drivers/clk/ux500/clk-prcmu.c                 | 253 ++++++++-----
 drivers/clk/ux500/clk.h                       |  70 ++--
 drivers/clk/ux500/u8500_of_clk.c              | 349 ++++++++++--------
 include/dt-bindings/clock/ste-db8500-clkout.h |  17 +
 5 files changed, 464 insertions(+), 282 deletions(-)
 create mode 100644 include/dt-bindings/clock/ste-db8500-clkout.h

Comments

Ulf Hansson April 4, 2022, 10:15 a.m. UTC | #1 
On Sat, 19 Mar 2022 at 23:53, Linus Walleij <linus.walleij@linaro.org> wrote:
>
> This second iteration adds patches that:
>
> - Drops custom .is_enabled and .is_prepared implementations
>   for the U8500 PRCMU clocks.
> - Rewrite the PRCMU clocks to use clk_hw
> - Then adds the new clkout clocks in the same style
>
> Modernizing the PRCMU clock was necessary so the new clock
> would not look off.
>
> We can go on and fix the rest of the ux500 clocks to use
> clk_hw style registration on top of this series if there
> is desire.
>
> Linus Walleij (5):
>   dt-bindings: clock: u8500: Add clkout clock bindings
>   clk: ux500: Drop .is_enabled state from PRCMU clocks
>   clk: ux500: Drop .is_prepared state from PRCMU clocks
>   clk: ux500: Rewrite PRCMU clocks to use clk_hw_*
>   clk: ux500: Implement the missing CLKOUT clocks
>
>  .../bindings/clock/stericsson,u8500-clks.yaml |  57 +++
>  drivers/clk/ux500/clk-prcmu.c                 | 253 ++++++++-----
>  drivers/clk/ux500/clk.h                       |  70 ++--
>  drivers/clk/ux500/u8500_of_clk.c              | 349 ++++++++++--------
>  include/dt-bindings/clock/ste-db8500-clkout.h |  17 +
>  5 files changed, 464 insertions(+), 282 deletions(-)
>  create mode 100644 include/dt-bindings/clock/ste-db8500-clkout.h
>

For the series (besides the minor nitpick at patch5):

Reviewed-by: Ulf Hansson <ulf.hansson@linaro.org>

Kind regards
Uffe