[RESEND,v2,0/4] DONOTMERGE: ep93xx-clk from ep93xx device tree conversion

Message

Nikita Shubin via B4 Relay May 6, 2024, 9:49 a.m. UTC

The goal is to recieve ACKs.

This is a fraction of v9 "ep93xx device tree conversion" series:

https://lore.kernel.org/all/[e-mail]/

The clk driver for ep93xx was converted to AUX device, as suggested
originally by Stephen Boyd.

Signed-off-by: Nikita Shubin <[e-mail]>
---
Changes in v2:
- soc: Add SoC driver for Cirrus ep93xx:
  - added __init for ep93xx_adev_alloc(), ep93xx_controller_register()
  - added static, __initconst for pinctrl_names[]
  - clk revision for SPI is now resolved here through differently named
    clk device
  - more verbose Kconfig description

  NOTE: "of" includes are required unfortunately.

- clk: ep93xx: add DT support for Cirrus EP93xx:
  - dropped includes
  - dropped ep93xx_soc_table[]
  - add different named clk and dropped involved includes
  - moved pll's and fclk, hclk, pclk init to separate function
  - fixed ep93xx_clk_ids[] explicit lines

  NOTE: clk_hw_register_div() is clk-ep9xx internal function which uses
  devm.

---
Nikita Shubin (4):
      ARM: ep93xx: add regmap aux_dev
      clk: ep93xx: add DT support for Cirrus EP93xx
      dt-bindings: soc: Add Cirrus EP93xx
      soc: Add SoC driver for Cirrus ep93xx

 .../bindings/arm/cirrus/cirrus,ep9301.yaml         |  38 +
 .../bindings/soc/cirrus/cirrus,ep9301-syscon.yaml  |  94 +++
 drivers/clk/Kconfig                                |   8 +
 drivers/clk/Makefile                               |   1 +
 drivers/clk/clk-ep93xx.c                           | 834 +++++++++++++++++++++
 drivers/soc/Kconfig                                |   1 +
 drivers/soc/Makefile                               |   1 +
 drivers/soc/cirrus/Kconfig                         |  17 +
 drivers/soc/cirrus/Makefile                        |   2 +
 drivers/soc/cirrus/soc-ep93xx.c                    | 252 +++++++
 include/dt-bindings/clock/cirrus,ep9301-syscon.h   |  46 ++
 include/linux/soc/cirrus/ep93xx.h                  |  26 +
 12 files changed, 1320 insertions(+)
---
base-commit: fec50db7033ea478773b159e0e2efb135270e3b7
change-id: 20240408-ep93xx-clk-657a1357de67

Best regards,

Comments

Nikita Shubin May 17, 2024, 7:39 a.m. UTC | #1

Hello Stephen!

A gentle remainder, can i hope you'll look into my changes for v2 ?

On Mon, 2024-05-06 at 12:49 +0300, Nikita Shubin via B4 Relay wrote:
> The goal is to recieve ACKs.
> 
> This is a fraction of v9 "ep93xx device tree conversion" series:
> 
> https://lore.kernel.org/all/[e-mail]/
> 
> The clk driver for ep93xx was converted to AUX device, as suggested
> originally by Stephen Boyd.
> 
> Signed-off-by: Nikita Shubin <[e-mail]>
> ---
> Changes in v2:
> - soc: Add SoC driver for Cirrus ep93xx:
>   - added __init for ep93xx_adev_alloc(),
> ep93xx_controller_register()
>   - added static, __initconst for pinctrl_names[]
>   - clk revision for SPI is now resolved here through differently
> named
>     clk device
>   - more verbose Kconfig description
> 
>   NOTE: "of" includes are required unfortunately.
> 
> - clk: ep93xx: add DT support for Cirrus EP93xx:
>   - dropped includes
>   - dropped ep93xx_soc_table[]
>   - add different named clk and dropped involved includes
>   - moved pll's and fclk, hclk, pclk init to separate function
>   - fixed ep93xx_clk_ids[] explicit lines
> 
>   NOTE: clk_hw_register_div() is clk-ep9xx internal function which
> uses
>   devm.
> 
> ---
> Nikita Shubin (4):
>       ARM: ep93xx: add regmap aux_dev
>       clk: ep93xx: add DT support for Cirrus EP93xx
>       dt-bindings: soc: Add Cirrus EP93xx
>       soc: Add SoC driver for Cirrus ep93xx
> 
>  .../bindings/arm/cirrus/cirrus,ep9301.yaml         |  38 +
>  .../bindings/soc/cirrus/cirrus,ep9301-syscon.yaml  |  94 +++
>  drivers/clk/Kconfig                                |   8 +
>  drivers/clk/Makefile                               |   1 +
>  drivers/clk/clk-ep93xx.c                           | 834
> +++++++++++++++++++++
>  drivers/soc/Kconfig                                |   1 +
>  drivers/soc/Makefile                               |   1 +
>  drivers/soc/cirrus/Kconfig                         |  17 +
>  drivers/soc/cirrus/Makefile                        |   2 +
>  drivers/soc/cirrus/soc-ep93xx.c                    | 252 +++++++
>  include/dt-bindings/clock/cirrus,ep9301-syscon.h   |  46 ++
>  include/linux/soc/cirrus/ep93xx.h                  |  26 +
>  12 files changed, 1320 insertions(+)
> ---
> base-commit: fec50db7033ea478773b159e0e2efb135270e3b7
> change-id: 20240408-ep93xx-clk-657a1357de67
> 
> Best regards,

Nikita Shubin May 30, 2024, 12:29 p.m. UTC | #2

Hello Stephen!

On Fri, 2024-05-17 at 10:39 +0300, Nikita Shubin wrote:
> Hello Stephen!
> 
> A gentle remainder, can i hope you'll look into my changes for v2 ?

Could you please look into "clk: ep93xx: add DT support for Cirrus
EP93xx" ?

It's the only one that has left not reviewed.

> 
> On Mon, 2024-05-06 at 12:49 +0300, Nikita Shubin via B4 Relay wrote:
> > The goal is to recieve ACKs.
> > 
> > This is a fraction of v9 "ep93xx device tree conversion" series:
> > 
> > https://lore.kernel.org/all/[e-mail]/
> > 
> > The clk driver for ep93xx was converted to AUX device, as suggested
> > originally by Stephen Boyd.
> > 
> > Signed-off-by: Nikita Shubin <[e-mail]>
> > ---
> > Changes in v2:
> > - soc: Add SoC driver for Cirrus ep93xx:
> >   - added __init for ep93xx_adev_alloc(),
> > ep93xx_controller_register()
> >   - added static, __initconst for pinctrl_names[]
> >   - clk revision for SPI is now resolved here through differently
> > named
> >     clk device
> >   - more verbose Kconfig description
> > 
> >   NOTE: "of" includes are required unfortunately.
> > 
> > - clk: ep93xx: add DT support for Cirrus EP93xx:
> >   - dropped includes
> >   - dropped ep93xx_soc_table[]
> >   - add different named clk and dropped involved includes
> >   - moved pll's and fclk, hclk, pclk init to separate function
> >   - fixed ep93xx_clk_ids[] explicit lines
> > 
> >   NOTE: clk_hw_register_div() is clk-ep9xx internal function which
> > uses
> >   devm.
> > 
> > ---
> > Nikita Shubin (4):
> >       ARM: ep93xx: add regmap aux_dev
> >       clk: ep93xx: add DT support for Cirrus EP93xx
> >       dt-bindings: soc: Add Cirrus EP93xx
> >       soc: Add SoC driver for Cirrus ep93xx
> > 
> >  .../bindings/arm/cirrus/cirrus,ep9301.yaml         |  38 +
> >  .../bindings/soc/cirrus/cirrus,ep9301-syscon.yaml  |  94 +++
> >  drivers/clk/Kconfig                                |   8 +
> >  drivers/clk/Makefile                               |   1 +
> >  drivers/clk/clk-ep93xx.c                           | 834
> > +++++++++++++++++++++
> >  drivers/soc/Kconfig                                |   1 +
> >  drivers/soc/Makefile                               |   1 +
> >  drivers/soc/cirrus/Kconfig                         |  17 +
> >  drivers/soc/cirrus/Makefile                        |   2 +
> >  drivers/soc/cirrus/soc-ep93xx.c                    | 252 +++++++
> >  include/dt-bindings/clock/cirrus,ep9301-syscon.h   |  46 ++
> >  include/linux/soc/cirrus/ep93xx.h                  |  26 +
> >  12 files changed, 1320 insertions(+)
> > ---
> > base-commit: fec50db7033ea478773b159e0e2efb135270e3b7
> > change-id: 20240408-ep93xx-clk-657a1357de67
> > 
> > Best regards,
>