diff mbox

clk: stm32f4: fix error handling

Message ID 1467526003-13318-1-git-send-email-christophe.jaillet@wanadoo.fr (mailing list archive)
State Accepted, archived
Delegated to: Michael Turquette
Headers show

Commit Message

Christophe JAILLET July 3, 2016, 6:06 a.m. UTC
This is likely that checking 'clks[idx]' instead of 'clks[n]' is
expected here.

Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
---
 drivers/clk/clk-stm32f4.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Michael Turquette July 7, 2016, 12:55 a.m. UTC | #1
Quoting Christophe JAILLET (2016-07-02 23:06:43)
> This is likely that checking 'clks[idx]' instead of 'clks[n]' is
> expected here.
> 
> Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>

Applied.

Regards,
Mike

> ---
>  drivers/clk/clk-stm32f4.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/clk/clk-stm32f4.c b/drivers/clk/clk-stm32f4.c
> index b6ca33f..02d6810 100644
> --- a/drivers/clk/clk-stm32f4.c
> +++ b/drivers/clk/clk-stm32f4.c
> @@ -364,7 +364,7 @@ static void __init stm32f4_rcc_init(struct device_node *np)
>                     NULL, gd->name, gd->parent_name, gd->flags,
>                     base + gd->offset, gd->bit_idx, 0, &stm32f4_clk_lock);
>  
> -               if (IS_ERR(clks[n])) {
> +               if (IS_ERR(clks[idx])) {
>                         pr_err("%s: Unable to register leaf clock %s\n",
>                                np->full_name, gd->name);
>                         goto fail;
> -- 
> 2.7.4
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-clk" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

diff --git a/drivers/clk/clk-stm32f4.c b/drivers/clk/clk-stm32f4.c
index b6ca33f..02d6810 100644
--- a/drivers/clk/clk-stm32f4.c
+++ b/drivers/clk/clk-stm32f4.c
@@ -364,7 +364,7 @@  static void __init stm32f4_rcc_init(struct device_node *np)
 		    NULL, gd->name, gd->parent_name, gd->flags,
 		    base + gd->offset, gd->bit_idx, 0, &stm32f4_clk_lock);
 
-		if (IS_ERR(clks[n])) {
+		if (IS_ERR(clks[idx])) {
 			pr_err("%s: Unable to register leaf clock %s\n",
 			       np->full_name, gd->name);
 			goto fail;