From patchwork Fri Jul 8 12:47:38 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andi Shyti X-Patchwork-Id: 9220807 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 954CD60572 for ; Fri, 8 Jul 2016 12:48:06 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 865B72877F for ; Fri, 8 Jul 2016 12:48:06 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 7B06028783; Fri, 8 Jul 2016 12:48:06 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=2.0 tests=BAYES_00,RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 9D14928780 for ; Fri, 8 Jul 2016 12:48:04 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754931AbcGHMrz (ORCPT ); Fri, 8 Jul 2016 08:47:55 -0400 Received: from mailout1.samsung.com ([203.254.224.24]:47589 "EHLO mailout1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755178AbcGHMry (ORCPT ); Fri, 8 Jul 2016 08:47:54 -0400 Received: from epcpsbgr3.samsung.com (u143.gpu120.samsung.co.kr [203.254.230.143]) by mailout1.samsung.com (Oracle Communications Messaging Server 7.0.5.31.0 64bit (built May 5 2014)) with ESMTP id <0O9Z01E93Y7RVJ00@mailout1.samsung.com>; Fri, 08 Jul 2016 21:47:51 +0900 (KST) Received: from epcpsbgm1new.samsung.com ( [172.20.52.113]) by epcpsbgr3.samsung.com (EPCPMTA) with SMTP id 1C.09.05161.7F0AF775; Fri, 8 Jul 2016 21:47:51 +0900 (KST) X-AuditID: cbfee68f-f79476d000001429-fa-577fa0f752cb Received: from epmmp2 ( [203.254.227.17]) by epcpsbgm1new.samsung.com (EPCPMTA) with SMTP id 3B.6D.02101.6F0AF775; Fri, 8 Jul 2016 21:47:50 +0900 (KST) Received: from samsunx.samsung ([10.113.63.54]) by mmp2.samsung.com (Oracle Communications Messaging Server 7.0.5.31.0 64bit (built May 5 2014)) with ESMTPA id <0O9Z00IN1Y7N1W70@mmp2.samsung.com>; Fri, 08 Jul 2016 21:47:50 +0900 (KST) From: Andi Shyti To: Chanwoo Choi , Sylwester Nawrocki Cc: Jaehoon Chung , Tomasz Figa , Michael Turquette , Stephen Boyd , Kukjin Kim , Krzysztof Kozlowski , linux-samsung-soc@vger.kernel.org, linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Andi Shyti , Andi Shyti Subject: [PATCH v5] clk: exynos5433: remove CLK_IGNORE_UNUSED flag from SPI clocks Date: Fri, 08 Jul 2016 21:47:38 +0900 Message-id: <1467982058-14339-1-git-send-email-andi.shyti@samsung.com> X-Mailer: git-send-email 2.8.1 X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFvrCLMWRmVeSWpSXmKPExsWyRsSkUPf7gvpwgwtPmS22H3nGarH4x3Mm i+tfnrNa3PjVxmrx+oWhRf/j18wWmx5fY7X42HOP1eLyrjlsFjPO72OyuHjK1eLwm3ZWix9n ulksVu36w+jA5/H+Riu7x+W+XiaP60s+MXvsnHWX3WPTqk42j81L6j36tqxi9Pi8SS6AI4rL JiU1J7MstUjfLoEro2vBLNaCPUIV94/NYmtgvMzfxcjJISFgInH/VSc7hC0mceHeerYuRi4O IYEVjBLLX65ghCk6+bUZKjGLUeJpXwsThPORUeL5lH8sIFVsApoSTbd/sIHYIgLhElP+/GQE KWIWOMwssbvvKlhCWCBE4szqe0wgNouAqsSB3o9gNq+Am8TVZzNZINbJSVye/gBsnYTAMXaJ z/372CEaBCS+TT4EVMQBlJCV2HSAGaJeUuLgihssExgFFzAyrGIUTS1ILihOSi8y1itOzC0u zUvXS87P3cQIjIzT/57172C8e8D6EKMAB6MSD6+BeH24EGtiWXFl7iFGU6ANE5mlRJPzgfGX VxJvaGxmZGFqYmpsZG5ppiTOu1DqZ7CQQHpiSWp2ampBalF8UWlOavEhRiYOTqkGxuQHMvv+ LuifNLsm81vs2/BzbQsyqp/x/tk5J7znsfeKBTtKW01mJtxvyl9k2CBgbrit7PpyPceHZlP/ 66n80bOuvNXI4eVRtabnfuov9s2MZnxL9uyKqouNq51oM8f/eXaV8wf7a1d/TEu/8U7o3mSO 7iVudfY7FrpdZT1+4exqrpO2F5umTFNiKc5INNRiLipOBAAj5KhmhwIAAA== X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFjrIIsWRmVeSWpSXmKPExsVy+t9jQd1vC+rDDabtsbLYfuQZq8XiH8+Z LK5/ec5qceNXG6vF6xeGFv2PXzNbbHp8jdXiY889VovLu+awWcw4v4/J4uIpV4vDb9pZLX6c 6WaxWLXrD6MDn8f7G63sHpf7epk8ri/5xOyxc9Zddo9NqzrZPDYvqffo27KK0ePzJrkAjqgG RpuM1MSU1CKF1Lzk/JTMvHRbJe/geOd4UzMDQ11DSwtzJYW8xNxUWyUXnwBdt8wcoLOVFMoS c0qBQgGJxcVK+naYJoSGuOlawDRG6PqGBMH1GBmggYQ1jBldC2axFuwRqrh/bBZbA+Nl/i5G Tg4JAROJk1+b2SBsMYkL99YD2VwcQgKzGCWe9rUwQTgfGSWeT/nHAlLFJqAp0XT7B1iHiEC4 xJQ/PxlBipgFDjNL7O67CpYQFgiROLP6HhOIzSKgKnGg9yOYzSvgJnH12UwWiHVyEpenP2Cb wMi9gJFhFaNEakFyQXFSeq5hXmq5XnFibnFpXrpecn7uJkZw9D2T2sF4cJf7IUYBDkYlHt4Z 6vXhQqyJZcWVuYcYJTiYlUR4mecDhXhTEiurUovy44tKc1KLDzGaAh0wkVlKNDkfmBjySuIN jU3MjCyNzA0tjIzNlcR5H/9fFyYkkJ5YkpqdmlqQWgTTx8TBKdXAeKZ4+QRHl+vR5rb7X7TG SuUXrfy9I36Z0eTC9ymztpu/L5USEzKeYp/h9V6/6O6dM0ZXeG5k2q+y2GSgax+htvvq3GKt 0/efNXiHrI5hPKng8myz9uLuCTe42oKnpFyKY3r8sMXsfu7s+9UL/jV4BWVtWF32Vey94DdZ SwvWgt0RX199nBnwVomlOCPRUIu5qDgRAI8PUGfUAgAA DLP-Filter: Pass X-MTR: 20000000000000000@CPGS X-CFilter-Loop: Reflected Sender: linux-clk-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-clk@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Commit b82ec4e and a9e93e8 have added support in the spi device driver for the three clock lines required by the SPI controller and handles the dependency between the three (by not disabling any after resume). This way none of the SPI clocks require any criticality: remove, then the CLK_IGNORE_UNUSED flag for the SPI related clocks. Signed-off-by: Andi Shyti Reviewed-by: Krzysztof Kozlowski --- Hi, With this, I hope to have reached the end of this patch series :) After some discussions with Tomasz first and Sylwester later, we agreed to move all the clock management to the spi driver, here are the patches that do that: http://marc.info/?l=linux-kernel&m=146787645626318&w=2 http://marc.info/?l=linux-kernel&m=146798033221943&w=2 With the above modifications to the spi driver we don't need any of the SPI related clocks to be marked either as critical or as ignore unused. Thanks, Andi drivers/clk/samsung/clk-exynos5433.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/clk/samsung/clk-exynos5433.c b/drivers/clk/samsung/clk-exynos5433.c index c3a5318..fb19525 100644 --- a/drivers/clk/samsung/clk-exynos5433.c +++ b/drivers/clk/samsung/clk-exynos5433.c @@ -1661,8 +1661,7 @@ static struct samsung_gate_clock peric_gate_clks[] __initdata = { GATE(CLK_SCLK_IOCLK_SPI2, "sclk_ioclk_spi2", "ioclk_spi2_clk_in", ENABLE_SCLK_PERIC, 13, CLK_SET_RATE_PARENT, 0), GATE(CLK_SCLK_IOCLK_SPI1, "sclk_ioclk_spi1", "ioclk_spi1_clk_in", - ENABLE_SCLK_PERIC, 12, - CLK_IGNORE_UNUSED | CLK_SET_RATE_PARENT, 0), + ENABLE_SCLK_PERIC, 12, CLK_SET_RATE_PARENT, 0), GATE(CLK_SCLK_IOCLK_SPI0, "sclk_ioclk_spi0", "ioclk_spi0_clk_in", ENABLE_SCLK_PERIC, 11, CLK_SET_RATE_PARENT, 0), GATE(CLK_SCLK_IOCLK_I2S1_BCLK, "sclk_ioclk_i2s1_bclk", @@ -1677,7 +1676,7 @@ static struct samsung_gate_clock peric_gate_clks[] __initdata = { GATE(CLK_SCLK_SPI2, "sclk_spi2", "sclk_spi2_peric", ENABLE_SCLK_PERIC, 5, CLK_SET_RATE_PARENT, 0), GATE(CLK_SCLK_SPI1, "sclk_spi1", "sclk_spi1_peric", ENABLE_SCLK_PERIC, - 4, CLK_IGNORE_UNUSED | CLK_SET_RATE_PARENT, 0), + 4, CLK_SET_RATE_PARENT, 0), GATE(CLK_SCLK_SPI0, "sclk_spi0", "sclk_spi0_peric", ENABLE_SCLK_PERIC, 3, CLK_SET_RATE_PARENT, 0), GATE(CLK_SCLK_UART2, "sclk_uart2", "sclk_uart2_peric",