| Message ID | 1471101978-1881-1-git-send-email-arvind.yadav.cs@gmail.com (mailing list archive) |
|---|---|
| State | Not Applicable, archived |
| Delegated to: | Stephen Boyd |
| Headers | show |
Hi Arvind, Am Samstag, 13. August 2016, 20:56:18 schrieb Arvind Yadav: > -check return of 'of_iomap'.if It's falied to remap then abort. > > -Unmap a region obtained by remap. iounmap frees the mapping when failed > to allocate the memory. > > Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com> > --- > drivers/clk/rockchip/clk-rockchip.c | 7 ++++++- I've applied the patch, after rewording both patch subject and message [0]. That driver is deprecated for quite some time, see Documenation/devicetree/bindings/clock/rockchip.txt - so I'm hoping this is more of a random find and you're not actually using it? Thanks Heiko [0] https://git.kernel.org/cgit/linux/kernel/git/mmind/linux-rockchip.git/commit/?id=023a8280b8355a0aebe094299afec8d8b7b264cd -- To unsubscribe from this list: send the line "unsubscribe linux-clk" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
yes, I am referring this code for clock control. --Arvind On Tuesday 23 August 2016 09:45 PM, Heiko Stübner wrote: > Hi Arvind, > > Am Samstag, 13. August 2016, 20:56:18 schrieb Arvind Yadav: >> -check return of 'of_iomap'.if It's falied to remap then abort. >> >> -Unmap a region obtained by remap. iounmap frees the mapping when failed >> to allocate the memory. >> >> Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com> >> --- >> drivers/clk/rockchip/clk-rockchip.c | 7 ++++++- > I've applied the patch, after rewording both patch subject and message [0]. > > That driver is deprecated for quite some time, see > Documenation/devicetree/bindings/clock/rockchip.txt - so I'm hoping this is > more of a random find and you're not actually using it? > > > Thanks > Heiko > > [0] https://git.kernel.org/cgit/linux/kernel/git/mmind/linux-rockchip.git/commit/?id=023a8280b8355a0aebe094299afec8d8b7b264cd > -- To unsubscribe from this list: send the line "unsubscribe linux-clk" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Hi Arvind, Am Mittwoch, 24. August 2016, 19:52:45 schrieb arvind Yadav: > yes, I am referring this code for clock control. Please definitly do not use that old gate driver anymore! Instead please look at the real clock drivers for specific Rockchip socs in the same directory. Which Rockchip soc are you working on? Heiko > On Tuesday 23 August 2016 09:45 PM, Heiko Stübner wrote: > > Hi Arvind, > > > > Am Samstag, 13. August 2016, 20:56:18 schrieb Arvind Yadav: > >> -check return of 'of_iomap'.if It's falied to remap then abort. > >> > >> -Unmap a region obtained by remap. iounmap frees the mapping when failed > >> to allocate the memory. > >> > >> Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com> > >> --- > >> > >> drivers/clk/rockchip/clk-rockchip.c | 7 ++++++- > > > > I've applied the patch, after rewording both patch subject and message > > [0]. > > > > That driver is deprecated for quite some time, see > > Documenation/devicetree/bindings/clock/rockchip.txt - so I'm hoping this > > is > > more of a random find and you're not actually using it? > > > > > > Thanks > > Heiko > > > > [0] > > https://git.kernel.org/cgit/linux/kernel/git/mmind/linux-rockchip.git/com > > mit/?id=023a8280b8355a0aebe094299afec8d8b7b264cd -- To unsubscribe from this list: send the line "unsubscribe linux-clk" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/clk/rockchip/clk-rockchip.c b/drivers/clk/rockchip/clk-rockchip.c index 4cf838d5..2c9bb81 100644 --- a/drivers/clk/rockchip/clk-rockchip.c +++ b/drivers/clk/rockchip/clk-rockchip.c @@ -49,14 +49,19 @@ static void __init rk2928_gate_clk_init(struct device_node *node) } reg = of_iomap(node, 0); + if (!reg) + return; clk_data = kzalloc(sizeof(struct clk_onecell_data), GFP_KERNEL); - if (!clk_data) + if (!clk_data) { + iounmap(reg); return; + } clk_data->clks = kzalloc(qty * sizeof(struct clk *), GFP_KERNEL); if (!clk_data->clks) { kfree(clk_data); + iounmap(reg); return; }
-check return of 'of_iomap'.if It's falied to remap then abort. -Unmap a region obtained by remap. iounmap frees the mapping when failed to allocate the memory. Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com> --- drivers/clk/rockchip/clk-rockchip.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-)