| Message ID | 1478070296-23080-1-git-send-email-jay.xu@rock-chips.com (mailing list archive) |
|---|---|
| State | Rejected, archived |
| Headers | show |
On 2016/11/2 15:04, Jianqun Xu wrote: > Fix aclk_emmcgrf to aclk_emmc_grf, and fix aclk_emmccore to be > aclk_emmc_core. > What is the standard style should be? TRM uses aclk_emmccore but not aclk_emmc_core, so should it be more standrad to keep it as-is? > Signed-off-by: Jianqun Xu <jay.xu@rock-chips.com> > --- > drivers/clk/rockchip/clk-rk3399.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/clk/rockchip/clk-rk3399.c b/drivers/clk/rockchip/clk-rk3399.c > index 2c7cba7..b3df2c6 100644 > --- a/drivers/clk/rockchip/clk-rk3399.c > +++ b/drivers/clk/rockchip/clk-rk3399.c > @@ -935,11 +935,11 @@ static struct rockchip_clk_branch rk3399_clk_branches[] __initdata = { > RK3399_CLKGATE_CON(6), 13, GFLAGS), > COMPOSITE_NOGATE(ACLK_EMMC, "aclk_emmc", mux_aclk_emmc_p, CLK_IGNORE_UNUSED, > RK3399_CLKSEL_CON(21), 7, 1, MFLAGS, 0, 5, DFLAGS), > - GATE(ACLK_EMMC_CORE, "aclk_emmccore", "aclk_emmc", CLK_IGNORE_UNUSED, > + GATE(ACLK_EMMC_CORE, "aclk_emmc_core", "aclk_emmc", CLK_IGNORE_UNUSED, > RK3399_CLKGATE_CON(32), 8, GFLAGS), > GATE(ACLK_EMMC_NOC, "aclk_emmc_noc", "aclk_emmc", CLK_IGNORE_UNUSED, > RK3399_CLKGATE_CON(32), 9, GFLAGS), > - GATE(ACLK_EMMC_GRF, "aclk_emmcgrf", "aclk_emmc", CLK_IGNORE_UNUSED, > + GATE(ACLK_EMMC_GRF, "aclk_emmc_grf", "aclk_emmc", CLK_IGNORE_UNUSED, > RK3399_CLKGATE_CON(32), 10, GFLAGS), > > /* perilp0 */ >
Am Donnerstag, 3. November 2016, 16:52:48 schrieb Shawn Lin: > On 2016/11/2 15:04, Jianqun Xu wrote: > > Fix aclk_emmcgrf to aclk_emmc_grf, and fix aclk_emmccore to be > > aclk_emmc_core. > > What is the standard style should be? > > TRM uses aclk_emmccore but not aclk_emmc_core, so should it be more > standrad to keep it as-is? I tend to agree with Shawn. While it looks like the missing "_" is some sort of mistake, we should strive to follow TRM naming, so grepping so it becomes easier to look for informations in these things in the TRM. Same reason for naming our regulators and pinctrl after the names used in device schematics, if available. Heiko -- To unsubscribe from this list: send the line "unsubscribe linux-clk" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Hi Heiko and Shawn: ok, I agree with you, and the root fix seems to fix it in the TRM first. I'll feedback to TRM makers. Thanks. On 2016年11月03日 22:32, Heiko Stübner wrote: > Am Donnerstag, 3. November 2016, 16:52:48 schrieb Shawn Lin: >> On 2016/11/2 15:04, Jianqun Xu wrote: >>> Fix aclk_emmcgrf to aclk_emmc_grf, and fix aclk_emmccore to be >>> aclk_emmc_core. >> >> What is the standard style should be? >> >> TRM uses aclk_emmccore but not aclk_emmc_core, so should it be more >> standrad to keep it as-is? > > I tend to agree with Shawn. While it looks like the missing "_" is some sort > of mistake, we should strive to follow TRM naming, so grepping so it becomes > easier to look for informations in these things in the TRM. > > Same reason for naming our regulators and pinctrl after the names used in > device schematics, if available. > > > Heiko > > > -- To unsubscribe from this list: send the line "unsubscribe linux-clk" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/clk/rockchip/clk-rk3399.c b/drivers/clk/rockchip/clk-rk3399.c index 2c7cba7..b3df2c6 100644 --- a/drivers/clk/rockchip/clk-rk3399.c +++ b/drivers/clk/rockchip/clk-rk3399.c @@ -935,11 +935,11 @@ static struct rockchip_clk_branch rk3399_clk_branches[] __initdata = { RK3399_CLKGATE_CON(6), 13, GFLAGS), COMPOSITE_NOGATE(ACLK_EMMC, "aclk_emmc", mux_aclk_emmc_p, CLK_IGNORE_UNUSED, RK3399_CLKSEL_CON(21), 7, 1, MFLAGS, 0, 5, DFLAGS), - GATE(ACLK_EMMC_CORE, "aclk_emmccore", "aclk_emmc", CLK_IGNORE_UNUSED, + GATE(ACLK_EMMC_CORE, "aclk_emmc_core", "aclk_emmc", CLK_IGNORE_UNUSED, RK3399_CLKGATE_CON(32), 8, GFLAGS), GATE(ACLK_EMMC_NOC, "aclk_emmc_noc", "aclk_emmc", CLK_IGNORE_UNUSED, RK3399_CLKGATE_CON(32), 9, GFLAGS), - GATE(ACLK_EMMC_GRF, "aclk_emmcgrf", "aclk_emmc", CLK_IGNORE_UNUSED, + GATE(ACLK_EMMC_GRF, "aclk_emmc_grf", "aclk_emmc", CLK_IGNORE_UNUSED, RK3399_CLKGATE_CON(32), 10, GFLAGS), /* perilp0 */
Fix aclk_emmcgrf to aclk_emmc_grf, and fix aclk_emmccore to be aclk_emmc_core. Signed-off-by: Jianqun Xu <jay.xu@rock-chips.com> --- drivers/clk/rockchip/clk-rk3399.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)