| Message ID | 1493141328-28201-1-git-send-email-geert+renesas@glider.be (mailing list archive) |
|---|---|
| State | Changes Requested |
| Headers | show |
On Tue, Apr 25, 2017 at 7:28 PM, Geert Uytterhoeven <geert+renesas@glider.be> wrote: > When CONFIG_ON=n, dummies are provided for of_clk_get() and > of_clk_get_by_name(), but not for of_clk_get_from_provider(). > > Provide a dummy for the latter, to improve the ability to do > compile-testing. > > Fixes: 766e6a4ec602d0c1 ("clk: add DT clock binding support") > Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be> > --- > include/linux/clk.h | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/include/linux/clk.h b/include/linux/clk.h > index e9d36b3e49de5b1b..3ed97abb5cbb7f94 100644 > --- a/include/linux/clk.h > +++ b/include/linux/clk.h > @@ -539,6 +539,10 @@ static inline struct clk *of_clk_get_by_name(struct device_node *np, > { > return ERR_PTR(-ENOENT); > } > +static inline struct clk *of_clk_get_from_provider(struct of_phandle_args *clkspec) > +{ > + return ERR_PTR(-ENOENT); > +} > #endif 0day reported an issue with arch/mips/lantiq/clk.c, which defines its own dummy version: | arch/mips//lantiq/clk.c:163:13: error: redefinition of 'of_clk_get_from_provider' I will add its removal to my v2. Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds -- To unsubscribe from this list: send the line "unsubscribe linux-clk" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/include/linux/clk.h b/include/linux/clk.h index e9d36b3e49de5b1b..3ed97abb5cbb7f94 100644 --- a/include/linux/clk.h +++ b/include/linux/clk.h @@ -539,6 +539,10 @@ static inline struct clk *of_clk_get_by_name(struct device_node *np, { return ERR_PTR(-ENOENT); } +static inline struct clk *of_clk_get_from_provider(struct of_phandle_args *clkspec) +{ + return ERR_PTR(-ENOENT); +} #endif #endif
When CONFIG_ON=n, dummies are provided for of_clk_get() and of_clk_get_by_name(), but not for of_clk_get_from_provider(). Provide a dummy for the latter, to improve the ability to do compile-testing. Fixes: 766e6a4ec602d0c1 ("clk: add DT clock binding support") Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be> --- include/linux/clk.h | 4 ++++ 1 file changed, 4 insertions(+)