| Message ID | 1494845939-30724-1-git-send-email-pure.logic@nexus-software.ie (mailing list archive) |
|---|---|
| State | Accepted |
| Headers | show |
On 05/15, Bryan O'Donoghue wrote: > When failing to set a clock the printout emitted is incorrect. > "u32 rate" is formatted as %d and should be %u whereas "unsigned long > clk_set_rate()" is formatted as %ld and should be %lu as per > Documentation/printk-formats.txt. > > Fixes: 2885c3b2a3da ("clk: Show correct information when fail to set clock > rate") > > Signed-off-by: Bryan O'Donoghue <pure.logic@nexus-software.ie> > --- Applied to clk-next but I fixed up the Fixes: tag to be on one line and next to the signed-off one.
diff --git a/drivers/clk/clk-conf.c b/drivers/clk/clk-conf.c index e0e02a6..7ec3672 100644 --- a/drivers/clk/clk-conf.c +++ b/drivers/clk/clk-conf.c @@ -109,7 +109,7 @@ static int __set_clk_rates(struct device_node *node, bool clk_supplier) rc = clk_set_rate(clk, rate); if (rc < 0) - pr_err("clk: couldn't set %s clk rate to %d (%d), current rate: %ld\n", + pr_err("clk: couldn't set %s clk rate to %u (%d), current rate: %lu\n", __clk_get_name(clk), rate, rc, clk_get_rate(clk)); clk_put(clk);
When failing to set a clock the printout emitted is incorrect. "u32 rate" is formatted as %d and should be %u whereas "unsigned long clk_set_rate()" is formatted as %ld and should be %lu as per Documentation/printk-formats.txt. Fixes: 2885c3b2a3da ("clk: Show correct information when fail to set clock rate") Signed-off-by: Bryan O'Donoghue <pure.logic@nexus-software.ie> --- drivers/clk/clk-conf.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)