From patchwork Mon May 15 10:58:59 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bryan O'Donoghue X-Patchwork-Id: 9726675 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 2839260380 for ; Mon, 15 May 2017 10:58:27 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 20BEA286E1 for ; Mon, 15 May 2017 10:58:27 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 157AD286F6; Mon, 15 May 2017 10:58:27 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.3 required=2.0 tests=BAYES_00,DKIM_SIGNED, RCVD_IN_DNSWL_HI, RCVD_IN_SORBS_SPAM, T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 362F8286E1 for ; Mon, 15 May 2017 10:58:26 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755657AbdEOK6Z (ORCPT ); Mon, 15 May 2017 06:58:25 -0400 Received: from mail-wm0-f54.google.com ([74.125.82.54]:36787 "EHLO mail-wm0-f54.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755408AbdEOK6Z (ORCPT ); Mon, 15 May 2017 06:58:25 -0400 Received: by mail-wm0-f54.google.com with SMTP id u65so77256362wmu.1 for ; Mon, 15 May 2017 03:58:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nexus-software-ie.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id; bh=bqaquWR02IEyhXEfEgCL4CtSTdkLczYYAj5bHHfOPOc=; b=z6WAuthmxP822usRuToa7MmSWt2eRIjVO2c5toxnKqbx9APgIfnnTeVkw8kQ0sgV/M yf+j0Vn/tOiKAM1HQ2x7sfOT/9dDjsuJLanoFBNeL/PeH/DSOJVNsLHmM3CH6jyWvbY5 qV8FTCSN8xPU++7CNR7ospxlYYmrQDSxNdlyrTIi4xD1Vgx8zxXbmXVFSUB70iAo2oMy Oxf/s3oixM0wauc5r/mmtyN1k1jAGxyP4GQg6YiTuhmMBJ5ER6+JrWwP9xcIzCZhjxTt GWZIapiGM3kyye87rY2AaUD74pRXJNJ8pngF9QiooHpnovmpgzwGy1Y2Zx9e8+bUB+we YP9Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=bqaquWR02IEyhXEfEgCL4CtSTdkLczYYAj5bHHfOPOc=; b=sCfR6RlahsdWSPGGKLoSjYtYibHXr53p9x7sq9lNr87ENE4wRM0p5wZpLPtqUFUVgm Zh/dkoJrlvrEmyhryuG1EOHABmrfF7O4UJqWvQTzqrCjVRG60Rijj6y+6G18/q91npBA j6UgcqrJ9maVxms8rfZnRr6v3fX4JPGb9g+dpMoDA/wf7JtHaNJAIARZ95pUWDP8leEE Sht6wGvwLWYrEedm4H327hRnd+PDwYBs1O9lVxuX4oGJnE3WH1hcuv8NBzf1kJtCevpR cSjTa32ynX22p9pdoCiIcLEF2XiRZmE9my662aVt5FZzinwKHWX7LCgqkzTv71QI9HQv I0xg== X-Gm-Message-State: AODbwcBgGYs/inhMH+d+lmvy4COBWbIWSdwWIrUgWSVJk1Xgdh7LEJl8 6YnGgTRn1i/wow== X-Received: by 10.28.212.78 with SMTP id l75mr3642182wmg.47.1494845901224; Mon, 15 May 2017 03:58:21 -0700 (PDT) Received: from localhost.localdomain ([176.61.103.53]) by smtp.gmail.com with ESMTPSA id a197sm9403388wma.1.2017.05.15.03.58.20 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Mon, 15 May 2017 03:58:20 -0700 (PDT) From: Bryan O'Donoghue To: mturquette@baylibre.com, sboyd@codeaurora.org, linux-clk@vger.kernel.org, cw00.choi@samsung.com Cc: Bryan O'Donoghue Subject: [PATCH] clk: Fix __set_clk_rates error print-string Date: Mon, 15 May 2017 11:58:59 +0100 Message-Id: <1494845939-30724-1-git-send-email-pure.logic@nexus-software.ie> X-Mailer: git-send-email 2.7.4 Sender: linux-clk-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-clk@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP When failing to set a clock the printout emitted is incorrect. "u32 rate" is formatted as %d and should be %u whereas "unsigned long clk_set_rate()" is formatted as %ld and should be %lu as per Documentation/printk-formats.txt. Fixes: 2885c3b2a3da ("clk: Show correct information when fail to set clock rate") Signed-off-by: Bryan O'Donoghue --- drivers/clk/clk-conf.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/clk/clk-conf.c b/drivers/clk/clk-conf.c index e0e02a6..7ec3672 100644 --- a/drivers/clk/clk-conf.c +++ b/drivers/clk/clk-conf.c @@ -109,7 +109,7 @@ static int __set_clk_rates(struct device_node *node, bool clk_supplier) rc = clk_set_rate(clk, rate); if (rc < 0) - pr_err("clk: couldn't set %s clk rate to %d (%d), current rate: %ld\n", + pr_err("clk: couldn't set %s clk rate to %u (%d), current rate: %lu\n", __clk_get_name(clk), rate, rc, clk_get_rate(clk)); clk_put(clk);