| Message ID | 1499392677-9100-1-git-send-email-vladimir.barinov@cogentembedded.com (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
On 07/07/2017 03:57 AM, Vladimir Barinov wrote: > From: Vladimir Barinov <vladimir.barinov+renesas@cogentembedded.com> > > IDT VersaClock 5 5P49V5925 has 4 clock outputs In 1/2 you said it has 4 FODs and 5 outputs (and it does have 5 outputs, 4 from FODs and 1 I2C_OUTB). >, 4 fractional dividers. > Input clock source can be taken only from external reference clock. > > Signed-off-by: Vladimir Barinov <vladimir.barinov+renesas@cogentembedded.com> You might want to rebase this on top of and retest against [1], there are 8 patches in total fixing some stuff and adding VC6 support. [1] https://patchwork.kernel.org/patch/9831797/ > --- > Documentation/devicetree/bindings/clock/idt,versaclock5.txt | 11 +++++++---- > 1 file changed, 7 insertions(+), 4 deletions(-) > > diff --git a/Documentation/devicetree/bindings/clock/idt,versaclock5.txt b/Documentation/devicetree/bindings/clock/idt,versaclock5.txt > index 53d7e50..a1ad9e0 100644 > --- a/Documentation/devicetree/bindings/clock/idt,versaclock5.txt > +++ b/Documentation/devicetree/bindings/clock/idt,versaclock5.txt > @@ -6,19 +6,21 @@ from 3 to 12 output clocks. > ==I2C device node== > > Required properties: > -- compatible: shall be one of "idt,5p49v5923" , "idt,5p49v5933" , > - "idt,5p49v5935". > +- compatible: shall be one of "idt,5p49v5923" , "idt,5p49v5925" , > + "idt,5p49v5933", "idt,5p49v5935". > - reg: i2c device address, shall be 0x68 or 0x6a. > - #clock-cells: from common clock binding; shall be set to 1. > - clocks: from common clock binding; list of parent clock handles, > - - 5p49v5923: (required) either or both of XTAL or CLKIN > + - 5p49v5923 and > + - 5p49v5925: (required) either or both of XTAL or CLKIN > reference clock. > - 5p49v5933 and > - 5p49v5935: (optional) property not present (internal > Xtal used) or CLKIN reference > clock. > - clock-names: from common clock binding; clock input names, can be > - - 5p49v5923: (required) either or both of "xin", "clkin". > + - 5p49v5923 and > + - 5p49v5925: (required) either or both of "xin", "clkin". > - 5p49v5933 and > - 5p49v5935: (optional) property not present or "clkin". > > @@ -37,6 +39,7 @@ clock specifier, the following mapping applies: > 1 -- OUT1 > 2 -- OUT4 > > +5P49V5925 and > 5P49V5935: > 0 -- OUT0_SEL_I2CB > 1 -- OUT1 >
On 09.07.2017 16:31, Marek Vasut wrote: > On 07/07/2017 03:57 AM, Vladimir Barinov wrote: >> From: Vladimir Barinov <vladimir.barinov+renesas@cogentembedded.com> >> >> IDT VersaClock 5 5P49V5925 has 4 clock outputs > In 1/2 you said it has 4 FODs and 5 outputs (and it does have 5 outputs, > 4 from FODs and 1 I2C_OUTB). That was a copy typo. Thank you for pointing to this. > >> , 4 fractional dividers. >> Input clock source can be taken only from external reference clock. >> >> Signed-off-by: Vladimir Barinov <vladimir.barinov+renesas@cogentembedded.com> > You might want to rebase this on top of and retest against [1], there > are 8 patches in total fixing some stuff and adding VC6 support. > > [1] https://patchwork.kernel.org/patch/9831797/ I've tested your patch series with ULCB board and HDMI display. I will rebase 5P49V5925 patches on top of them. Regards, Vladimir -- To unsubscribe from this list: send the line "unsubscribe linux-clk" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On 07/09/2017 07:38 PM, Vladimir Barinov wrote: > On 09.07.2017 16:31, Marek Vasut wrote: >> On 07/07/2017 03:57 AM, Vladimir Barinov wrote: >>> From: Vladimir Barinov <vladimir.barinov+renesas@cogentembedded.com> >>> >>> IDT VersaClock 5 5P49V5925 has 4 clock outputs >> In 1/2 you said it has 4 FODs and 5 outputs (and it does have 5 outputs, >> 4 from FODs and 1 I2C_OUTB). > That was a copy typo. Thank you for pointing to this. > >> >>> , 4 fractional dividers. >>> Input clock source can be taken only from external reference clock. >>> >>> Signed-off-by: Vladimir Barinov >>> <vladimir.barinov+renesas@cogentembedded.com> >> You might want to rebase this on top of and retest against [1], there >> are 8 patches in total fixing some stuff and adding VC6 support. >> >> [1] https://patchwork.kernel.org/patch/9831797/ > > I've tested your patch series with ULCB board and HDMI display. > I will rebase 5P49V5925 patches on top of them. Thanks! That makes things easy :)
diff --git a/Documentation/devicetree/bindings/clock/idt,versaclock5.txt b/Documentation/devicetree/bindings/clock/idt,versaclock5.txt index 53d7e50..a1ad9e0 100644 --- a/Documentation/devicetree/bindings/clock/idt,versaclock5.txt +++ b/Documentation/devicetree/bindings/clock/idt,versaclock5.txt @@ -6,19 +6,21 @@ from 3 to 12 output clocks. ==I2C device node== Required properties: -- compatible: shall be one of "idt,5p49v5923" , "idt,5p49v5933" , - "idt,5p49v5935". +- compatible: shall be one of "idt,5p49v5923" , "idt,5p49v5925" , + "idt,5p49v5933", "idt,5p49v5935". - reg: i2c device address, shall be 0x68 or 0x6a. - #clock-cells: from common clock binding; shall be set to 1. - clocks: from common clock binding; list of parent clock handles, - - 5p49v5923: (required) either or both of XTAL or CLKIN + - 5p49v5923 and + - 5p49v5925: (required) either or both of XTAL or CLKIN reference clock. - 5p49v5933 and - 5p49v5935: (optional) property not present (internal Xtal used) or CLKIN reference clock. - clock-names: from common clock binding; clock input names, can be - - 5p49v5923: (required) either or both of "xin", "clkin". + - 5p49v5923 and + - 5p49v5925: (required) either or both of "xin", "clkin". - 5p49v5933 and - 5p49v5935: (optional) property not present or "clkin". @@ -37,6 +39,7 @@ clock specifier, the following mapping applies: 1 -- OUT1 2 -- OUT4 +5P49V5925 and 5P49V5935: 0 -- OUT0_SEL_I2CB 1 -- OUT1