From patchwork Sat Dec 30 01:12:53 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bryan O'Donoghue X-Patchwork-Id: 10137565 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id B8D3E6037D for ; Sat, 30 Dec 2017 01:19:02 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id ABAFE2B551 for ; Sat, 30 Dec 2017 01:19:02 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 9F22F2B585; Sat, 30 Dec 2017 01:19:02 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=2.0 tests=BAYES_00,DKIM_SIGNED, RCVD_IN_DNSWL_HI,T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 13FDB2B551 for ; Sat, 30 Dec 2017 01:19:02 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751115AbdL3BNa (ORCPT ); Fri, 29 Dec 2017 20:13:30 -0500 Received: from mail-wm0-f67.google.com ([74.125.82.67]:43757 "EHLO mail-wm0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751064AbdL3BN1 (ORCPT ); Fri, 29 Dec 2017 20:13:27 -0500 Received: by mail-wm0-f67.google.com with SMTP id n138so50420711wmg.2 for ; Fri, 29 Dec 2017 17:13:27 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nexus-software-ie.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=BwDiVEid6HcKeoh/9ifAR804vVHKbBfeO2Pg5i8oREc=; b=zg7GhcMtmZIBFoi83mYcxyjOHU7yyZXZIkqcnFs8Q/o01Vr3CuBEAeGvXpWR8Z8gQm hlDYWa7/SHwhylArXrYI2SadD9l5GLpv9S+zaoyj9D8bsnMtrhOP7xx2cSBS1RVNVNyg 1GUtqWSKawSwWKielljVzmj3VHARENzi81m+QixTq0ljcGDIJPCjcGqoHnrjj4ZBzbws WRA9LkZvtYn7Y1JQtyoomxyUOI/3GIqeLXV/pRcKaDMEkVUPtHdTcH1u9MaIXbeDerbd FGZBGuu/m3jT2lM0vaIYEVUQhj8aKLBQCesGDn8CiQMUsZbw84efX6xNtx9lsNYFmCcX kyNA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=BwDiVEid6HcKeoh/9ifAR804vVHKbBfeO2Pg5i8oREc=; b=gcFh/T5HbrK7uPh+Lr2peAX9z8/jefrcxahUZprv4iNmpuXKPyMHk7r79RITs7OM5Z qhEe9dG7VIgZlKqInfrje+sxlI6+MS3+Qq+8q1FkKH31eR/RxSD+VZ6MX0KQTEA4Rtul gbEWgdH+RYX6ZTp+rnjb6q/Z+ry1IqCTb1so/LDO/RW58yFkAHWrmyeMgLx8PVuBFG2+ m8ANlR6ij4THDApZLxCJhfabXCqNKeH2yMCQyikNrp38ie99eUK55X9ok9EZ6N992IcU iIxxslMOZ2wTfBFs2aqLdnPlS+JjS2Y0TqpZ/u88C5fYjLUVfKbGD/Wwu9D1/TIGa8yz hqsA== X-Gm-Message-State: AKGB3mKoJyki8mN5+JB03hiGHWF4YAlL9AtHKcH8hSn2WCQD0juXuPWr KQfqPEngXCpmkb7IVB3pmbxtEQ== X-Google-Smtp-Source: ACJfBovX/pyD0ahO1ReX8a3pgA+jyalidhUe0xOR4Prxto4lRbyfFkKDooknM3MDktX9n05eX53L+A== X-Received: by 10.80.164.144 with SMTP id w16mr45419849edb.130.1514596406507; Fri, 29 Dec 2017 17:13:26 -0800 (PST) Received: from localhost.localdomain ([109.255.42.2]) by smtp.gmail.com with ESMTPSA id h4sm29818268edb.16.2017.12.29.17.13.25 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Fri, 29 Dec 2017 17:13:25 -0800 (PST) From: Bryan O'Donoghue To: mturquette@baylibre.com, sboyd@codeaurora.org, linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org Cc: pure.logic@nexus-software.ie, Marek Vasut , Vladimir Barinov , Alexey Firago Subject: [PATCH 14/33] clk: vc5: change vc5_mux_round_rate() return logic Date: Sat, 30 Dec 2017 01:12:53 +0000 Message-Id: <1514596392-22270-15-git-send-email-pure.logic@nexus-software.ie> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1514596392-22270-1-git-send-email-pure.logic@nexus-software.ie> References: <1514596392-22270-1-git-send-email-pure.logic@nexus-software.ie> Sender: linux-clk-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-clk@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP This patch updates the round_rate() logic here to return zero instead of a negative number on error. In conjunction with higher-level changes associated with acting on the return value of clk_ops->round_rate() it is then possible to have clk_ops->round_rate() return values from 1 Hz to ULONG_MAX Hz instead of the current limitation of 1 Hz to LONG_MAX Hz. Signed-off-by: Bryan O'Donoghue Cc: Marek Vasut Cc: Michael Turquette Cc: Stephen Boyd Cc: linux-clk@vger.kernel.org Cc: linux-kernel@vger.kernel.org Cc: Vladimir Barinov Cc: Alexey Firago --- drivers/clk/clk-versaclock5.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/clk/clk-versaclock5.c b/drivers/clk/clk-versaclock5.c index 2b8ea89..5e8a050 100644 --- a/drivers/clk/clk-versaclock5.c +++ b/drivers/clk/clk-versaclock5.c @@ -351,7 +351,7 @@ static unsigned long vc5_pfd_round_rate(struct clk_hw *hw, unsigned long rate, /* PLL cannot operate with input clock above 50 MHz. */ if (rate > 50000000) - return -EINVAL; + return 0; /* CLKIN within range of PLL input, feed directly to PLL. */ if (*parent_rate <= 50000000) @@ -359,7 +359,7 @@ static unsigned long vc5_pfd_round_rate(struct clk_hw *hw, unsigned long rate, idiv = DIV_ROUND_UP(*parent_rate, rate); if (idiv > 127) - return -EINVAL; + return 0; return *parent_rate / idiv; }