From patchwork Mon Jan 1 19:42:53 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bryan O'Donoghue X-Patchwork-Id: 10139511 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 9A86760362 for ; Mon, 1 Jan 2018 19:49:44 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 8B3CA286FB for ; Mon, 1 Jan 2018 19:49:44 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 7FE76286FE; Mon, 1 Jan 2018 19:49:44 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=2.0 tests=BAYES_00,DKIM_SIGNED, RCVD_IN_DNSWL_HI,T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 03D64286FB for ; Mon, 1 Jan 2018 19:49:44 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754480AbeAATtU (ORCPT ); Mon, 1 Jan 2018 14:49:20 -0500 Received: from mail-wm0-f68.google.com ([74.125.82.68]:46520 "EHLO mail-wm0-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753858AbeAATnb (ORCPT ); Mon, 1 Jan 2018 14:43:31 -0500 Received: by mail-wm0-f68.google.com with SMTP id r78so58606017wme.5 for ; Mon, 01 Jan 2018 11:43:31 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nexus-software-ie.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=EseY+79FL2a8XaZXj7nl2+ZqEMRnpeVbuWWerg15BgE=; b=lAvVp7WC9LgBiRD/DRpf2OG8UM2N0DgQAiCg1fyAqbHCMvgl9tJeaHUoCS+O2TbQme NLEzUzTUlE5KEvhSJbBy1kbw91kMWm4XlazlO8rT/JJ5c6Rl3rKUwveVwq0XO3eFWQcO ATNMTRV9WFLUG9lVyi+6nai6w4ViP8/tbhm+ayRUqjJK6gXSOPhusuHtyaDZ3C9k13Nl xzg9rVvsMqJn7+xiSrO24rbe46MNQJpETm457RccXCnEeJkG5eu0JWdMF1o5Hht+e9Nn DTE9M2czocooVb0/Kq+sz6eJE95fvymyUj7NRPnD6A7BssMCSPoh8eBz3W1sxXeVIuIy LZQw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=EseY+79FL2a8XaZXj7nl2+ZqEMRnpeVbuWWerg15BgE=; b=PMlm93yZwEKlGguSftw0sFrts+c62nvbJAftykzj3BeooPAG/epODYFFMu8gxtDspy 7tNxAIXJEjT/YXIXvDtUC2L+FgFFYliBbrFUIX9BHc2i+cWNy2Aq5ZVbnmEyk/FJlovC 37g8HRLjYr+BmWvAcPnT9+aMOcHT6oNvAgqPJG9B97V8083AbpmOLQkeZJk79gqe6Fwv oU1CSzhaR6EHZA89qK0e0TQ9tvZUB7DWkTa4vFHEfQX0ydkJzPLzhgTuBq7ieTuHLiJZ EPYgBgL07Ml/MKYBCvxh0e1YlCHw+G7ZWoLIejlhqZYrDkFib/GFxUgaAjh7FrG3qKJf B8cw== X-Gm-Message-State: AKGB3mITqs3llGIGrLsiaq83UT7z1ZdHngwU6qMQ1Z8hOhZiJWD++EXw G/LbOMFzvWJxEuwIAaAtrmXRJw== X-Google-Smtp-Source: ACJfBotJED3XDPJbYFbJ3HvO3RXHL7N/edxRnTAyqZ/Ed8oKY0L4C0w5eG7nQ2to9y0bJokhyJBQKw== X-Received: by 10.80.155.84 with SMTP id a20mr59821831edj.21.1514835810682; Mon, 01 Jan 2018 11:43:30 -0800 (PST) Received: from localhost.localdomain (D4CCACC7.cm-2.dynamic.ziggo.nl. [212.204.172.199]) by smtp.gmail.com with ESMTPSA id w2sm39361075edb.4.2018.01.01.11.43.29 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Mon, 01 Jan 2018 11:43:30 -0800 (PST) From: Bryan O'Donoghue To: mturquette@baylibre.com, sboyd@codeaurora.org, linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org Cc: Bryan O'Donoghue , Marek Vasut , Vladimir Barinov , Alexey Firago Subject: [PATCH v3 14/34] clk: vc5: change vc5_pfd_round_rate() return logic Date: Mon, 1 Jan 2018 19:42:53 +0000 Message-Id: <1514835793-1104-15-git-send-email-pure.logic@nexus-software.ie> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1514835793-1104-1-git-send-email-pure.logic@nexus-software.ie> References: <1514835793-1104-1-git-send-email-pure.logic@nexus-software.ie> Sender: linux-clk-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-clk@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP This patch updates the round_rate() logic here to return zero instead of a negative number on error. In conjunction with higher-level changes associated with acting on the return value of clk_ops->round_rate() it is then possible to have clk_ops->round_rate() return values from 1 Hz to ULONG_MAX Hz instead of the current limitation of 1 Hz to LONG_MAX Hz. Signed-off-by: Bryan O'Donoghue Cc: Marek Vasut Cc: Michael Turquette Cc: Stephen Boyd Cc: linux-clk@vger.kernel.org Cc: linux-kernel@vger.kernel.org Cc: Vladimir Barinov Cc: Alexey Firago --- drivers/clk/clk-versaclock5.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/clk/clk-versaclock5.c b/drivers/clk/clk-versaclock5.c index 7c7b369..9432122 100644 --- a/drivers/clk/clk-versaclock5.c +++ b/drivers/clk/clk-versaclock5.c @@ -351,7 +351,7 @@ static unsigned long vc5_pfd_round_rate(struct clk_hw *hw, unsigned long rate, /* PLL cannot operate with input clock above 50 MHz. */ if (rate > 50000000) - return -EINVAL; + return 0; /* CLKIN within range of PLL input, feed directly to PLL. */ if (*parent_rate <= 50000000) @@ -359,7 +359,7 @@ static unsigned long vc5_pfd_round_rate(struct clk_hw *hw, unsigned long rate, idiv = DIV_ROUND_UP(*parent_rate, rate); if (idiv > 127) - return -EINVAL; + return 0; return *parent_rate / idiv; }