From patchwork Mon Jan 1 19:42:58 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bryan O'Donoghue X-Patchwork-Id: 10139481 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id E85D760362 for ; Mon, 1 Jan 2018 19:47:59 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id D9DE1286FB for ; Mon, 1 Jan 2018 19:47:59 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id CEB0828700; Mon, 1 Jan 2018 19:47:59 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=2.0 tests=BAYES_00,DKIM_SIGNED, RCVD_IN_DNSWL_HI,T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 85C58286FB for ; Mon, 1 Jan 2018 19:47:58 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754253AbeAATr5 (ORCPT ); Mon, 1 Jan 2018 14:47:57 -0500 Received: from mail-wm0-f68.google.com ([74.125.82.68]:38087 "EHLO mail-wm0-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932108AbeAATng (ORCPT ); Mon, 1 Jan 2018 14:43:36 -0500 Received: by mail-wm0-f68.google.com with SMTP id 64so57931656wme.3 for ; Mon, 01 Jan 2018 11:43:35 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nexus-software-ie.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=pPAXGXZ93QbOy5wG9swfXAxSE9h/zyfswFK5EBERFeA=; b=mD3crRMXLVS3jcITr8KolhpgOMvIpwYV0+OVJy0lgy6wKFzHdRWUAUiVQjwquIqC5d HncQJAGhp0FHfOVKxyYWX5mRu232SwCsFJuJ5RVFvv8iOmcrwBvoKtaChmi+qgNPPMhh p3v3b/pMBUopc5NO0noFZlzpgIKKYxMkJbvYfDCf/05VI3RUiyixVJshYSNu2nMWtldF Z9rwVdJAEzj+QREnbXx/52ArVlKGHZdBST3eO+emjv2MR6Pi18ws+Wn6psNslqPJbl0Q AueGejg1fCbnaJWeXDe0CT5gOucKsHuRkd6Deg6ITWT+PQPTnZepz10CUb/9DIOIth6O QcyQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=pPAXGXZ93QbOy5wG9swfXAxSE9h/zyfswFK5EBERFeA=; b=VWISuxfi5nPNM9HJUGPVBoZMM/iB5410MMRo3GBvK7iKIWhG2jt3EzPH7TUjA4ibDO y4yzJpCheg2oxyEhhpmpvIkK2Kgw5tjaahSVdHsEr1weW1Phmmc6dROKXMG4QuxQysaA Umah8o/O+Su+RPtydKUFcDVXl7A9biA8rnIeZPkcqY7H6aBSvS/ifyKqM/DqInONk3TI eLc6U0QRRycv4zoN3W42KTjivFq2aGhV8PeBcorMaYJwLIS7zY2GHOQYtmKF9e53c3GH 7z6qmG7wS8Ga5avpRNmfG//xvngkXn3r9NNM3XTCk6/gnHyvMmuEY1lmCecvaweF5+WH +1dA== X-Gm-Message-State: AKGB3mJ74KdBJg/skNjQwFNaXHQ5Shb+faa2Bpv7H+kpFrrjw/xEVCxE 89JEsaKcD3rau4jaD2HlZM32m/wo X-Google-Smtp-Source: ACJfBotIl3KOeKYZCKdPYBuTdQEA6PlI25jAMHFiHUnBY4QMBqeE6YI423qi/J9/p1Mwo0EBDZzcEg== X-Received: by 10.80.215.89 with SMTP id i25mr60243739edj.274.1514835815145; Mon, 01 Jan 2018 11:43:35 -0800 (PST) Received: from localhost.localdomain (D4CCACC7.cm-2.dynamic.ziggo.nl. [212.204.172.199]) by smtp.gmail.com with ESMTPSA id w2sm39361075edb.4.2018.01.01.11.43.34 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Mon, 01 Jan 2018 11:43:34 -0800 (PST) From: Bryan O'Donoghue To: mturquette@baylibre.com, sboyd@codeaurora.org, linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org Cc: Bryan O'Donoghue , Shawn Guo Subject: [PATCH v3 19/34] clk: mxs: change clk_frac_round_rate() return logic Date: Mon, 1 Jan 2018 19:42:58 +0000 Message-Id: <1514835793-1104-20-git-send-email-pure.logic@nexus-software.ie> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1514835793-1104-1-git-send-email-pure.logic@nexus-software.ie> References: <1514835793-1104-1-git-send-email-pure.logic@nexus-software.ie> Sender: linux-clk-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-clk@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP This patch updates the round_rate() logic here to return zero instead of a negative number on error. In conjunction with higher-level changes associated with acting on the return value of clk_ops->round_rate() it is then possible to have clk_ops->round_rate() return values from 1 Hz to ULONG_MAX Hz instead of the current limitation of 1 Hz to LONG_MAX Hz. Signed-off-by: Bryan O'Donoghue Cc: Michael Turquette Cc: Stephen Boyd Cc: linux-clk@vger.kernel.org Cc: linux-kernel@vger.kernel.org Cc: Shawn Guo --- drivers/clk/mxs/clk-frac.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/clk/mxs/clk-frac.c b/drivers/clk/mxs/clk-frac.c index f57281f..9debf86 100644 --- a/drivers/clk/mxs/clk-frac.c +++ b/drivers/clk/mxs/clk-frac.c @@ -59,7 +59,7 @@ static unsigned long clk_frac_round_rate(struct clk_hw *hw, unsigned long rate, u64 tmp, tmp_rate, result; if (rate > parent_rate) - return -EINVAL; + return 0; tmp = rate; tmp <<= frac->width; @@ -67,7 +67,7 @@ static unsigned long clk_frac_round_rate(struct clk_hw *hw, unsigned long rate, div = tmp; if (!div) - return -EINVAL; + return 0; tmp_rate = (u64)parent_rate * div; result = tmp_rate >> frac->width;