| Message ID | 1550836779-6868-1-git-send-email-fabrizio.castro@bp.renesas.com (mailing list archive) |
|---|---|
| State | Accepted, archived |
| Headers | show |
| Series | clk: renesas: r8a774a1: Fix LAST_DT_CORE_CLK | expand |
> From: Fabrizio Castro <fabrizio.castro@bp.renesas.com> > Sent: 22 February 2019 12:00 > > Enum LAST_DT_CORE_CLK needs updating as R8A774A1_CLK_CANFD > was recently added and it's the core clock with the highest > index. > > Signed-off-by: Fabrizio Castro <fabrizio.castro@bp.renesas.com> Reviewed-by: Chris Paterson <chris.paterson2@renesas.com> > --- > drivers/clk/renesas/r8a774a1-cpg-mssr.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/clk/renesas/r8a774a1-cpg-mssr.c > b/drivers/clk/renesas/r8a774a1-cpg-mssr.c > index 5fcd6c5..8e7bb43 100644 > --- a/drivers/clk/renesas/r8a774a1-cpg-mssr.c > +++ b/drivers/clk/renesas/r8a774a1-cpg-mssr.c > @@ -21,7 +21,7 @@ > > enum clk_ids { > /* Core Clock Outputs exported to DT */ > - LAST_DT_CORE_CLK = R8A774A1_CLK_OSC, > + LAST_DT_CORE_CLK = R8A774A1_CLK_CANFD, > > /* External Input Clocks */ > CLK_EXTAL, > -- > 2.7.4
On Fri, Feb 22, 2019 at 12:01:21PM +0000, Chris Paterson wrote: > > > From: Fabrizio Castro <fabrizio.castro@bp.renesas.com> > > Sent: 22 February 2019 12:00 > > > > Enum LAST_DT_CORE_CLK needs updating as R8A774A1_CLK_CANFD > > was recently added and it's the core clock with the highest > > index. > > > > Signed-off-by: Fabrizio Castro <fabrizio.castro@bp.renesas.com> > Reviewed-by: Chris Paterson <chris.paterson2@renesas.com> I think this needs: Fixes: 9d034e151b40 ("clk: renesas: r8a774a1: Add missing CANFD clock") Reviewed-by: Simon Horman <horms+renesas@verge.net.au> > > > --- > > drivers/clk/renesas/r8a774a1-cpg-mssr.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/drivers/clk/renesas/r8a774a1-cpg-mssr.c > > b/drivers/clk/renesas/r8a774a1-cpg-mssr.c > > index 5fcd6c5..8e7bb43 100644 > > --- a/drivers/clk/renesas/r8a774a1-cpg-mssr.c > > +++ b/drivers/clk/renesas/r8a774a1-cpg-mssr.c > > @@ -21,7 +21,7 @@ > > > > enum clk_ids { > > /* Core Clock Outputs exported to DT */ > > - LAST_DT_CORE_CLK = R8A774A1_CLK_OSC, > > + LAST_DT_CORE_CLK = R8A774A1_CLK_CANFD, > > > > /* External Input Clocks */ > > CLK_EXTAL, > > -- > > 2.7.4 >
On Mon, Feb 25, 2019 at 10:27 AM Simon Horman <horms@verge.net.au> wrote: > On Fri, Feb 22, 2019 at 12:01:21PM +0000, Chris Paterson wrote: > > > From: Fabrizio Castro <fabrizio.castro@bp.renesas.com> > > > Sent: 22 February 2019 12:00 > > > > > > Enum LAST_DT_CORE_CLK needs updating as R8A774A1_CLK_CANFD > > > was recently added and it's the core clock with the highest > > > index. > > > > > > Signed-off-by: Fabrizio Castro <fabrizio.castro@bp.renesas.com> > > Reviewed-by: Chris Paterson <chris.paterson2@renesas.com> > > I think this needs: > > Fixes: 9d034e151b40 ("clk: renesas: r8a774a1: Add missing CANFD clock") Exactly. > Reviewed-by: Simon Horman <horms+renesas@verge.net.au> Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be> Mike/Stephen: can you please take this one directly, as it is a fix for clk-next? Thanks! Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds
Hello Simon, Geert Thank you for your feedback! > From: Simon Horman <horms@verge.net.au> > Sent: 25 February 2019 09:27 > Subject: Re: [PATCH] clk: renesas: r8a774a1: Fix LAST_DT_CORE_CLK > > On Fri, Feb 22, 2019 at 12:01:21PM +0000, Chris Paterson wrote: > > > > > From: Fabrizio Castro <fabrizio.castro@bp.renesas.com> > > > Sent: 22 February 2019 12:00 > > > > > > Enum LAST_DT_CORE_CLK needs updating as R8A774A1_CLK_CANFD > > > was recently added and it's the core clock with the highest > > > index. > > > > > > Signed-off-by: Fabrizio Castro <fabrizio.castro@bp.renesas.com> > > Reviewed-by: Chris Paterson <chris.paterson2@renesas.com> > > I think this needs: > > Fixes: 9d034e151b40 ("clk: renesas: r8a774a1: Add missing CANFD clock") I naively thought I could only refer to commits from Torvald's, which is clearly wrong, therefore thank you for fixing. Cheers, Fab > > Reviewed-by: Simon Horman <horms+renesas@verge.net.au> > > > > > > --- > > > drivers/clk/renesas/r8a774a1-cpg-mssr.c | 2 +- > > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > > > diff --git a/drivers/clk/renesas/r8a774a1-cpg-mssr.c > > > b/drivers/clk/renesas/r8a774a1-cpg-mssr.c > > > index 5fcd6c5..8e7bb43 100644 > > > --- a/drivers/clk/renesas/r8a774a1-cpg-mssr.c > > > +++ b/drivers/clk/renesas/r8a774a1-cpg-mssr.c > > > @@ -21,7 +21,7 @@ > > > > > > enum clk_ids { > > > /* Core Clock Outputs exported to DT */ > > > - LAST_DT_CORE_CLK = R8A774A1_CLK_OSC, > > > + LAST_DT_CORE_CLK = R8A774A1_CLK_CANFD, > > > > > > /* External Input Clocks */ > > > CLK_EXTAL, > > > -- > > > 2.7.4 > >
Hi Fabrizio, On Mon, Feb 25, 2019 at 10:44 AM Fabrizio Castro <fabrizio.castro@bp.renesas.com> wrote: > > From: Simon Horman <horms@verge.net.au> > > Sent: 25 February 2019 09:27 > > Subject: Re: [PATCH] clk: renesas: r8a774a1: Fix LAST_DT_CORE_CLK > > > > On Fri, Feb 22, 2019 at 12:01:21PM +0000, Chris Paterson wrote: > > > > > > > From: Fabrizio Castro <fabrizio.castro@bp.renesas.com> > > > > Sent: 22 February 2019 12:00 > > > > > > > > Enum LAST_DT_CORE_CLK needs updating as R8A774A1_CLK_CANFD > > > > was recently added and it's the core clock with the highest > > > > index. > > > > > > > > Signed-off-by: Fabrizio Castro <fabrizio.castro@bp.renesas.com> > > > Reviewed-by: Chris Paterson <chris.paterson2@renesas.com> > > > > I think this needs: > > > > Fixes: 9d034e151b40 ("clk: renesas: r8a774a1: Add missing CANFD clock") > > I naively thought I could only refer to commits from Torvald's, which is clearly wrong, > therefore thank you for fixing. FTR: You can refer to any commits in linux-next that are considered stable, i.e. on branches that are never rebased. This includes all for-next branches of maintainers who accept pull requests. Gr{oetje,eeting}s, Geert
Hello Geert, > From: linux-renesas-soc-owner@vger.kernel.org <linux-renesas-soc-owner@vger.kernel.org> On Behalf Of Geert Uytterhoeven > Sent: 25 February 2019 09:48 > Subject: Re: [PATCH] clk: renesas: r8a774a1: Fix LAST_DT_CORE_CLK > > Hi Fabrizio, > > On Mon, Feb 25, 2019 at 10:44 AM Fabrizio Castro > <fabrizio.castro@bp.renesas.com> wrote: > > > From: Simon Horman <horms@verge.net.au> > > > Sent: 25 February 2019 09:27 > > > Subject: Re: [PATCH] clk: renesas: r8a774a1: Fix LAST_DT_CORE_CLK > > > > > > On Fri, Feb 22, 2019 at 12:01:21PM +0000, Chris Paterson wrote: > > > > > > > > > From: Fabrizio Castro <fabrizio.castro@bp.renesas.com> > > > > > Sent: 22 February 2019 12:00 > > > > > > > > > > Enum LAST_DT_CORE_CLK needs updating as R8A774A1_CLK_CANFD > > > > > was recently added and it's the core clock with the highest > > > > > index. > > > > > > > > > > Signed-off-by: Fabrizio Castro <fabrizio.castro@bp.renesas.com> > > > > Reviewed-by: Chris Paterson <chris.paterson2@renesas.com> > > > > > > I think this needs: > > > > > > Fixes: 9d034e151b40 ("clk: renesas: r8a774a1: Add missing CANFD clock") > > > > I naively thought I could only refer to commits from Torvald's, which is clearly wrong, > > therefore thank you for fixing. > > FTR: You can refer to any commits in linux-next that are considered stable, > i.e. on branches that are never rebased. > This includes all for-next branches of maintainers who accept pull requests. I see, thank you for the explanation! Cheers, Fab > > Gr{oetje,eeting}s, > > Geert > > -- > Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org > > In personal conversations with technical people, I call myself a hacker. But > when I'm talking to journalists I just say "programmer" or something like that. > -- Linus Torvalds
Quoting Fabrizio Castro (2019-02-22 03:59:39) > Enum LAST_DT_CORE_CLK needs updating as R8A774A1_CLK_CANFD > was recently added and it's the core clock with the highest > index. > > Signed-off-by: Fabrizio Castro <fabrizio.castro@bp.renesas.com> > --- Applied to clk-next
diff --git a/drivers/clk/renesas/r8a774a1-cpg-mssr.c b/drivers/clk/renesas/r8a774a1-cpg-mssr.c index 5fcd6c5..8e7bb43 100644 --- a/drivers/clk/renesas/r8a774a1-cpg-mssr.c +++ b/drivers/clk/renesas/r8a774a1-cpg-mssr.c @@ -21,7 +21,7 @@ enum clk_ids { /* Core Clock Outputs exported to DT */ - LAST_DT_CORE_CLK = R8A774A1_CLK_OSC, + LAST_DT_CORE_CLK = R8A774A1_CLK_CANFD, /* External Input Clocks */ CLK_EXTAL,
Enum LAST_DT_CORE_CLK needs updating as R8A774A1_CLK_CANFD was recently added and it's the core clock with the highest index. Signed-off-by: Fabrizio Castro <fabrizio.castro@bp.renesas.com> --- drivers/clk/renesas/r8a774a1-cpg-mssr.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)