From patchwork Sun Aug 18 16:23:44 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stefan Wahren X-Patchwork-Id: 11099667 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id A194D112C for ; Sun, 18 Aug 2019 16:24:23 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 7887228455 for ; Sun, 18 Aug 2019 16:24:23 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 674B3286B9; Sun, 18 Aug 2019 16:24:23 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.0 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FROM,MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 0982728455 for ; Sun, 18 Aug 2019 16:24:23 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726742AbfHRQYW (ORCPT ); Sun, 18 Aug 2019 12:24:22 -0400 Received: from mout.gmx.net ([212.227.15.18]:57915 "EHLO mout.gmx.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726089AbfHRQYW (ORCPT ); Sun, 18 Aug 2019 12:24:22 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1566145453; bh=CzdbVQq8IrILnm9Q22KWEYU789AoTBUeM4pr8EHs4B0=; h=X-UI-Sender-Class:From:To:Cc:Subject:Date:In-Reply-To:References; b=BE9iF8C9awFP40knspDwDKei8JkqD7bb9v5Gi76ncS8K5jBzRguKhTSnq8tlqV+/x MwuCbxOZ47MpMMglpq9dybmhqtl4OZ86/UsZGS+/ZUpghSjnA3/r6lF2PwWD+EQRfA JpCiMyy6mD80XCggcJmH/vNZ4CR9MgEBRPC7W1U8= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Received: from localhost.localdomain ([37.4.249.106]) by mail.gmx.com (mrgmx003 [212.227.17.190]) with ESMTPSA (Nemesis) id 0LikE1-1iXL961U8j-00cwDf; Sun, 18 Aug 2019 18:24:13 +0200 From: Stefan Wahren To: Eric Anholt , Florian Fainelli , Ray Jui , Scott Branden , Rob Herring , Mark Rutland , Michael Turquette , Stephen Boyd Cc: linux-clk@vger.kernel.org, Stefan Wahren Subject: [PATCH 4/4] clk: bcm2835: Mark PLLD_PER as CRITICAL Date: Sun, 18 Aug 2019 18:23:44 +0200 Message-Id: <1566145424-3186-5-git-send-email-wahrenst@gmx.net> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1566145424-3186-1-git-send-email-wahrenst@gmx.net> References: <1566145424-3186-1-git-send-email-wahrenst@gmx.net> X-Provags-ID: V03:K1:Y5KnN3P4dN6rJKtSRnxV6bmbDrsIR6RJHsGa2SS5ZGPEIdDjLld m9M0ggJUPJlABn8hfTzpFBgFqiYKPW5JlB5RGi+IvwChqvpw7psC09DRv2MM+TDMNATZCE3 G4l1+YDGPkAM574T8IeaN/7Vdauxv9c2tqnK5l0dpWv3V8n2W2AV4q4FoKZvvePl5g6afXY itREXpAZkk6eV5xJwAMpw== X-UI-Out-Filterresults: notjunk:1;V03:K0:6nY4L7DJmR8=:qhqpx98PZ0Yv7ARb0iDSAf h2jl3qUYO/BYr+H/YYgmWcwtz1Iz6YTHj0jSXT4ri44f5vZsuYU5nCMsgzxakTYnSUnOCayXi 3jghAzsIWTwYXFfFmv+KKDhQMlTkBL0dleN9e5c34P4eVhPMNdtmfzZgjpQjPuj6O37VWU9Hl 8om56VkzvFVkHwRuugO/4+roZQLgg9QGexvtS7xsBcbm7MpltLKKqJ8KaVCNHFYAPSPWAt9Bk UxdjgujtrotUVTeWuKcKzSpwf9dVde15sXHtUKoHvBKWwLSypkxsKXU503ykjrD2peGxhWXz4 tVH6Dslruvn59VAL6MycATISgVL8EeMM/gERlOOh9MfF/yapVaUMXE14oxixsE4VrooWeOo/z 6fTILJZC9dssUEU8SzbvlH93OlGAjnePFjk+B2CJ7RSHX8NiJbWbOlFhEA7FU4RVL3eJZw6zY 5EQxckN9iUNzqv3Is1zhKJSWpQU951FYleYSo9KcB9jo6ZgXeHuGCEwIXCTsRdHZokZQ36dBZ DeAHtkuGuWNPhFiDn9bgNllVmoW6IyOI5TeIpPgcloH9aqsBJzn6F1i6U1cjRsiw6ba19FN8z AuJ9LWblHpgFsVZzY/1nDUloY6BUNlkYunlUHOf7sjP1PyDUMO7dNvW7+I6D6UgaGvV3RWfvy 74zmGfI780eyqA1BxJlcxkoWv6slxYY12jDw+85ItsYkf3CMo6J9seVW5Ge9em1Jy6FeQdNix 8zrITqCH+HiADIMXbpFoi70etb9NwIQ+z+t+ykhfBsi7eQV+B6uRdpOQl1Xfrd7jdo7tagYgK sJRGuyvumkKICNyaLyKC8h2SSbUdbyfaTDUE9x4qTYGDKU9n3WMyBusU0ekXAAjtGIXVEDJKl sgb5yn2VmWSd1dskSnkynpVsZQLu4rYs+Y2ntcByXXamfzfrTT3wpHL7Pi/rcI2dZOMXhXbG4 wSIl5eRxC42HjYGdgaQuKW1Im6z+T7JJaAKffe+varrIARFWFURLxj67BdT0Swiz28P0kmriK Ugte/8SCJsdJzDsvIPmhrLnHWQVHOcrrbXzi1CpF9xqZNQ8XxbtH6vhEJeCBJoHw5kqcsFVCm Ddp+Cw6a5hIaMTqsZpo1VXc2xV+pE+ryXSCqVf8J1NQNtTXbNySvuJB4X3bYGpnoBLaqbzyfC O0zwjoIsF8nN/La0J/60/xCWk455dDKt9r2EjdfFCO25se2g== Sender: linux-clk-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-clk@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP The VPU firmware assume that the PLLD_PER isn't modified by the ARM core. Otherwise this could cause firmware lookups. So mark the clock as critical to avoid this. Signed-off-by: Stefan Wahren Reviewed-by: Eric Anholt --- drivers/clk/bcm/clk-bcm2835.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) -- 2.7.4 diff --git a/drivers/clk/bcm/clk-bcm2835.c b/drivers/clk/bcm/clk-bcm2835.c index fdf672a..802e488 100644 --- a/drivers/clk/bcm/clk-bcm2835.c +++ b/drivers/clk/bcm/clk-bcm2835.c @@ -1776,6 +1776,11 @@ static const struct bcm2835_clk_desc clk_desc_array[] = { .hold_mask = CM_PLLD_HOLDCORE, .fixed_divider = 1, .flags = CLK_SET_RATE_PARENT), + /* + * VPU firmware assumes that PLLD_PER isn't disabled by the ARM core. + * Otherwise this could cause firmware lookups. That's why we mark + * it as critical. + */ [BCM2835_PLLD_PER] = REGISTER_PLL_DIV( SOC_ALL, .name = "plld_per", @@ -1785,7 +1790,7 @@ static const struct bcm2835_clk_desc clk_desc_array[] = { .load_mask = CM_PLLD_LOADPER, .hold_mask = CM_PLLD_HOLDPER, .fixed_divider = 1, - .flags = CLK_SET_RATE_PARENT), + .flags = CLK_IS_CRITICAL | CLK_SET_RATE_PARENT), [BCM2835_PLLD_DSI0] = REGISTER_PLL_DIV( SOC_ALL, .name = "plld_dsi0",