| Message ID | 1593410042-10598-11-git-send-email-Anson.Huang@nxp.com (mailing list archive) |
|---|---|
| State | Changes Requested, archived |
| Headers | show |
| Series | Support building i.MX8 SoCs clock driver as module | expand |
On Mon, Jun 29, 2020 at 8:06 AM Anson Huang <Anson.Huang@nxp.com> wrote: > > Support building i.MX8QXP clock driver as module. > > Signed-off-by: Anson Huang <Anson.Huang@nxp.com> I would just combine the per-soc patches into one, as they all have the same changelog text. > diff --git a/drivers/clk/imx/clk-imx8qxp-lpcg.c b/drivers/clk/imx/clk-imx8qxp-lpcg.c > index 04c8ee3..8afaefc 100644 > --- a/drivers/clk/imx/clk-imx8qxp-lpcg.c > +++ b/drivers/clk/imx/clk-imx8qxp-lpcg.c > @@ -232,3 +232,4 @@ static struct platform_driver imx8qxp_lpcg_clk_driver = { > }; > > builtin_platform_driver(imx8qxp_lpcg_clk_driver); > +MODULE_LICENSE("GPL v2"); Same thing here: please try to make it possible to unload these drivers, and add MODULE_AUTHOR/MODULE_DESCRIPTION tags in addition to MODULE_LICENSE. Arnd
Hi, Arnd > Subject: Re: [PATCH V3 10/10] clk: imx8qxp: Support module build > > On Mon, Jun 29, 2020 at 8:06 AM Anson Huang <Anson.Huang@nxp.com> > wrote: > > > > Support building i.MX8QXP clock driver as module. > > > > Signed-off-by: Anson Huang <Anson.Huang@nxp.com> > > I would just combine the per-soc patches into one, as they all have the same > changelog text. OK, I will merge those patches with same changelog text into one patch. But for i.MX8QXP clock driver, as I need to add more changes about module author etc., I will keep it as a separate patch. > > > diff --git a/drivers/clk/imx/clk-imx8qxp-lpcg.c > > b/drivers/clk/imx/clk-imx8qxp-lpcg.c > > index 04c8ee3..8afaefc 100644 > > --- a/drivers/clk/imx/clk-imx8qxp-lpcg.c > > +++ b/drivers/clk/imx/clk-imx8qxp-lpcg.c > > @@ -232,3 +232,4 @@ static struct platform_driver > > imx8qxp_lpcg_clk_driver = { }; > > > > builtin_platform_driver(imx8qxp_lpcg_clk_driver); > > +MODULE_LICENSE("GPL v2"); > > Same thing here: please try to make it possible to unload these drivers, and > add MODULE_AUTHOR/MODULE_DESCRIPTION tags in addition to > MODULE_LICENSE. > OK, will improve it in next patch series. Thanks, Anson
On Mon, Jun 29, 2020 at 1:43 PM Anson Huang <anson.huang@nxp.com> wrote: > > Subject: Re: [PATCH V3 10/10] clk: imx8qxp: Support module build > > > > On Mon, Jun 29, 2020 at 8:06 AM Anson Huang <Anson.Huang@nxp.com> > > wrote: > > > > > > Support building i.MX8QXP clock driver as module. > > > > > > Signed-off-by: Anson Huang <Anson.Huang@nxp.com> > > > > I would just combine the per-soc patches into one, as they all have the same > > changelog text. > > OK, I will merge those patches with same changelog text into one patch. > But for i.MX8QXP clock driver, as I need to add more changes about module author > etc., I will keep it as a separate patch. Ok, sounds good. Arnd
diff --git a/drivers/clk/imx/Kconfig b/drivers/clk/imx/Kconfig index 060f9c3..26cedbf 100644 --- a/drivers/clk/imx/Kconfig +++ b/drivers/clk/imx/Kconfig @@ -37,7 +37,7 @@ config CLK_IMX8MQ Build the driver for i.MX8MQ CCM Clock Driver config CLK_IMX8QXP - bool "IMX8QXP SCU Clock" + tristate "IMX8QXP SCU Clock" depends on ARCH_MXC && IMX_SCU && ARM64 select MXC_CLK_SCU help diff --git a/drivers/clk/imx/clk-imx8qxp-lpcg.c b/drivers/clk/imx/clk-imx8qxp-lpcg.c index 04c8ee3..8afaefc 100644 --- a/drivers/clk/imx/clk-imx8qxp-lpcg.c +++ b/drivers/clk/imx/clk-imx8qxp-lpcg.c @@ -232,3 +232,4 @@ static struct platform_driver imx8qxp_lpcg_clk_driver = { }; builtin_platform_driver(imx8qxp_lpcg_clk_driver); +MODULE_LICENSE("GPL v2"); diff --git a/drivers/clk/imx/clk-imx8qxp.c b/drivers/clk/imx/clk-imx8qxp.c index 5e2903e..a34c7c5 100644 --- a/drivers/clk/imx/clk-imx8qxp.c +++ b/drivers/clk/imx/clk-imx8qxp.c @@ -152,3 +152,4 @@ static struct platform_driver imx8qxp_clk_driver = { .probe = imx8qxp_clk_probe, }; builtin_platform_driver(imx8qxp_clk_driver); +MODULE_LICENSE("GPL v2");
Support building i.MX8QXP clock driver as module. Signed-off-by: Anson Huang <Anson.Huang@nxp.com> --- No change. --- drivers/clk/imx/Kconfig | 2 +- drivers/clk/imx/clk-imx8qxp-lpcg.c | 1 + drivers/clk/imx/clk-imx8qxp.c | 1 + 3 files changed, 3 insertions(+), 1 deletion(-)