| Message ID | 20170612194438.12298-10-jbrunet@baylibre.com (mailing list archive) |
|---|---|
| State | Changes Requested |
| Delegated to: | Stephen Boyd |
| Headers | show |
On 06/12, Jerome Brunet wrote: > ENOSYS is special and should only be used for incorrect syscall number. > It does not seem to be the case here. > > Reported by checkpatch.pl while working on clock protection. > > Signed-off-by: Jerome Brunet <jbrunet@baylibre.com> Could also go earlier in the series.
diff --git a/drivers/clk/clk.c b/drivers/clk/clk.c index 8d57e130c4e0..5d545954c48f 100644 --- a/drivers/clk/clk.c +++ b/drivers/clk/clk.c @@ -2032,7 +2032,7 @@ static int clk_core_set_parent_nolock(struct clk_core *core, /* verify ops for for multi-parent clks */ if ((core->num_parents > 1) && (!core->ops->set_parent)) - return -ENOSYS; + return -EPERM; /* check that we are allowed to re-parent if the clock is in use */ if ((core->flags & CLK_SET_PARENT_GATE) && core->prepare_count)
ENOSYS is special and should only be used for incorrect syscall number. It does not seem to be the case here. Reported by checkpatch.pl while working on clock protection. Signed-off-by: Jerome Brunet <jbrunet@baylibre.com> --- drivers/clk/clk.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)