| Message ID | 20170818142250.27867-1-georgi.djakov@linaro.org (mailing list archive) |
|---|---|
| State | Accepted, archived |
| Delegated to: | Stephen Boyd |
| Headers | show |
On 08/18, Georgi Djakov wrote: > The clock bimc_gpu_clk_src is incorrectly set to use the shared rcg2 > ops, which are for RCGs with child branches controlled by different > CPUs. > > The result of the incorrect ops is that the GPU's PM runtime may leave > this clock set at a very low rate. Fix this issue by using the correct > rcg2 ops. > > Fixes: a2e8272f3f89 ("clk: qcom: Add MSM8916 gpu clocks") > Signed-off-by: Georgi Djakov <georgi.djakov@linaro.org> > --- This is the only user of clk_rcg2_shared_ops. I'm totally lost why we added this in the first place.
On 08/24/2017 01:55 AM, Stephen Boyd wrote: > On 08/18, Georgi Djakov wrote: >> The clock bimc_gpu_clk_src is incorrectly set to use the shared rcg2 >> ops, which are for RCGs with child branches controlled by different >> CPUs. >> >> The result of the incorrect ops is that the GPU's PM runtime may leave >> this clock set at a very low rate. Fix this issue by using the correct >> rcg2 ops. >> >> Fixes: a2e8272f3f89 ("clk: qcom: Add MSM8916 gpu clocks") >> Signed-off-by: Georgi Djakov <georgi.djakov@linaro.org> >> --- > > This is the only user of clk_rcg2_shared_ops. I'm totally lost > why we added this in the first place. > Yes, this is the only user. It seems that the ops could be useful for a few other SoC that are not upstream yet, but for now i am sending a patch to remove the unused code. Thanks, Georgi -- To unsubscribe from this list: send the line "unsubscribe linux-clk" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/clk/qcom/gcc-msm8916.c b/drivers/clk/qcom/gcc-msm8916.c index 2cfe7000fc60..3410ee68d4bc 100644 --- a/drivers/clk/qcom/gcc-msm8916.c +++ b/drivers/clk/qcom/gcc-msm8916.c @@ -1176,7 +1176,7 @@ static struct clk_rcg2 bimc_gpu_clk_src = { .parent_names = gcc_xo_gpll0_bimc, .num_parents = 3, .flags = CLK_GET_RATE_NOCACHE, - .ops = &clk_rcg2_shared_ops, + .ops = &clk_rcg2_ops, }, };
The clock bimc_gpu_clk_src is incorrectly set to use the shared rcg2 ops, which are for RCGs with child branches controlled by different CPUs. The result of the incorrect ops is that the GPU's PM runtime may leave this clock set at a very low rate. Fix this issue by using the correct rcg2 ops. Fixes: a2e8272f3f89 ("clk: qcom: Add MSM8916 gpu clocks") Signed-off-by: Georgi Djakov <georgi.djakov@linaro.org> --- drivers/clk/qcom/gcc-msm8916.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- To unsubscribe from this list: send the line "unsubscribe linux-clk" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html